All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Amit Daniel kachhap <amit.daniel@samsung.com>
Subject: Re: [PATCH, RFC 12/22] thermal: cpu_cooling: fix stub function
Date: Thu, 2 May 2013 11:46:13 -0400	[thread overview]
Message-ID: <51828A45.60909@ti.com> (raw)
In-Reply-To: <1367507786-505303-13-git-send-email-arnd@arndb.de>

[-- Attachment #1: Type: text/plain, Size: 2195 bytes --]

On 02-05-2013 11:16, Arnd Bergmann wrote:
> The function stub for cpufreq_cooling_get_level introduced
> in 57df81069 "Thermal: exynos: fix cooling state translation"
> is not syntactically correct C and needs to be fixed to avoid
> this error:
> 
> In file included from drivers/thermal/db8500_thermal.c:20:0:
>  include/linux/cpu_cooling.h: In function 'cpufreq_cooling_get_level':
> include/linux/cpu_cooling.h:57:1:
>  error: parameter name omitted  unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int)  ^
>  include/linux/cpu_cooling.h:57:1: error: parameter name omitted
> 
> Cc: Eduardo Valentin <eduardo.valentin@ti.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Amit Daniel kachhap <amit.daniel@samsung.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/cpu_cooling.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h
> index 282e270..cf03111 100644
> --- a/include/linux/cpu_cooling.h
> +++ b/include/linux/cpu_cooling.h
> @@ -54,7 +54,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev)
>  	return;
>  }
>  static inline
> -unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int)
> +unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq)

While there, could you please also include the following (same, but on
the function declaration on line 44), just to keep the header in same style?
diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h
index 282e270..c023afa 100644
--- a/include/linux/cpu_cooling.h
+++ b/include/linux/cpu_cooling.h
@@ -41,7 +41,7 @@ cpufreq_cooling_register(const struct cpumask *clip_cpus);
  */
 void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev);

-unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int);
+unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int
freq);
 #else /* !CONFIG_CPU_THERMAL */
 static inline struct thermal_cooling_device *
 cpufreq_cooling_register(const struct cpumask *clip_cpus)


>  {
>  	return THERMAL_CSTATE_INVALID;
>  }
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: eduardo.valentin@ti.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH, RFC 12/22] thermal: cpu_cooling: fix stub function
Date: Thu, 2 May 2013 11:46:13 -0400	[thread overview]
Message-ID: <51828A45.60909@ti.com> (raw)
In-Reply-To: <1367507786-505303-13-git-send-email-arnd@arndb.de>

On 02-05-2013 11:16, Arnd Bergmann wrote:
> The function stub for cpufreq_cooling_get_level introduced
> in 57df81069 "Thermal: exynos: fix cooling state translation"
> is not syntactically correct C and needs to be fixed to avoid
> this error:
> 
> In file included from drivers/thermal/db8500_thermal.c:20:0:
>  include/linux/cpu_cooling.h: In function 'cpufreq_cooling_get_level':
> include/linux/cpu_cooling.h:57:1:
>  error: parameter name omitted  unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int)  ^
>  include/linux/cpu_cooling.h:57:1: error: parameter name omitted
> 
> Cc: Eduardo Valentin <eduardo.valentin@ti.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Amit Daniel kachhap <amit.daniel@samsung.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/cpu_cooling.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h
> index 282e270..cf03111 100644
> --- a/include/linux/cpu_cooling.h
> +++ b/include/linux/cpu_cooling.h
> @@ -54,7 +54,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev)
>  	return;
>  }
>  static inline
> -unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int)
> +unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq)

While there, could you please also include the following (same, but on
the function declaration on line 44), just to keep the header in same style?
diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h
index 282e270..c023afa 100644
--- a/include/linux/cpu_cooling.h
+++ b/include/linux/cpu_cooling.h
@@ -41,7 +41,7 @@ cpufreq_cooling_register(const struct cpumask *clip_cpus);
  */
 void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev);

-unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int);
+unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int
freq);
 #else /* !CONFIG_CPU_THERMAL */
 static inline struct thermal_cooling_device *
 cpufreq_cooling_register(const struct cpumask *clip_cpus)


>  {
>  	return THERMAL_CSTATE_INVALID;
>  }
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 295 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130502/91dc8c11/attachment.sig>

  reply	other threads:[~2013-05-02 15:46 UTC|newest]

Thread overview: 151+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 15:16 [PATCH, RFC 00/22] ARM randconfig bugs Arnd Bergmann
2013-05-02 15:16 ` Arnd Bergmann
2013-05-02 15:16 ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 01/22] can: move CONFIG_HAVE_CAN_FLEXCAN out of CAN_DEV Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-03  9:53   ` Marc Kleine-Budde
2013-05-03  9:53     ` Marc Kleine-Budde
2013-05-03 15:24     ` Arnd Bergmann
2013-05-03 15:24       ` Arnd Bergmann
2013-05-07  9:18       ` Marc Kleine-Budde
2013-05-07  9:18         ` Marc Kleine-Budde
2013-05-02 15:16 ` [PATCH, RFC 02/22] cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-03  4:51   ` Viresh Kumar
2013-05-03  4:51     ` Viresh Kumar
2013-05-03 12:15     ` Rafael J. Wysocki
2013-05-03 12:15       ` Rafael J. Wysocki
2013-05-03 13:01       ` Viresh Kumar
2013-05-03 13:01         ` Viresh Kumar
2013-05-03 19:27         ` Rafael J. Wysocki
2013-05-03 19:27           ` Rafael J. Wysocki
2013-05-04  6:39   ` Viresh Kumar
2013-05-04  6:39     ` Viresh Kumar
2013-05-08  0:26     ` Rafael J. Wysocki
2013-05-08  0:26       ` Rafael J. Wysocki
2013-05-02 15:16 ` [PATCH, RFC 03/22] cpuidle: calxeda: select ARM_CPU_SUSPEND Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 21:31   ` Daniel Lezcano
2013-05-02 21:31     ` Daniel Lezcano
2013-05-07 21:42   ` Rob Herring
2013-05-07 21:42     ` Rob Herring
2013-05-02 15:16 ` [PATCH, RFC 04/22] staging/drm: imx: add missing dependencies Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-03  2:16   ` Shawn Guo
2013-05-03  2:16     ` Shawn Guo
2013-05-03 15:21     ` Arnd Bergmann
2013-05-03 15:21       ` Arnd Bergmann
2013-05-04 12:35       ` Shawn Guo
2013-05-04 12:35         ` Shawn Guo
2013-05-02 15:16 ` [PATCH, RFC 05/22] drm: always provide debugfs function prototypes Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 06/22] gpu/drm: host1x: add dependency on Tegra Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-03 13:45   ` Thierry Reding
2013-05-03 13:45     ` Thierry Reding
2013-05-03 14:02     ` Arnd Bergmann
2013-05-03 14:02       ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 07/22] drm/tilcd: select BACKLIGHT_LCD_SUPPORT Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 08/22] OMAPDSS: DPI needs DSI Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:42   ` Tomi Valkeinen
2013-05-02 15:42     ` Tomi Valkeinen
2013-05-02 16:26     ` Arnd Bergmann
2013-05-02 16:26       ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 09/22] crypto: lz4: don't build on ARM Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 10/22] mfd: ab8500: debugfs code depends on gpadc Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:36   ` Lee Jones
2013-05-02 15:36     ` Lee Jones
2013-05-02 16:24     ` Arnd Bergmann
2013-05-02 16:24       ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 11/22] iwlegacy: il_pm_ops is only provided for PM_SLEEP Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-05 20:29   ` Borislav Petkov
2013-05-05 20:29     ` Borislav Petkov
2013-05-02 15:16 ` [PATCH, RFC 12/22] thermal: cpu_cooling: fix stub function Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:46   ` Eduardo Valentin [this message]
2013-05-02 15:46     ` Eduardo Valentin
2013-05-02 16:29     ` [PATCH v2] " Arnd Bergmann
2013-05-02 16:29       ` Arnd Bergmann
2013-05-02 16:54       ` Eduardo Valentin
2013-05-02 16:54         ` Eduardo Valentin
2013-05-08 12:12         ` Arnd Bergmann
2013-05-08 12:12           ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 13/22] staging/logger: use kuid_t internally Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 14/22] oprofile: always enable IRQ_WORK Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-03 11:53   ` Robert Richter
2013-05-03 11:53     ` Robert Richter
2013-05-03 13:30     ` Steven Rostedt
2013-05-03 13:30       ` Steven Rostedt
2013-05-03 15:14     ` Steven Rostedt
2013-05-03 15:14       ` Steven Rostedt
2013-05-03 21:26       ` Arnd Bergmann
2013-05-03 21:26         ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 15/22] USB: EHCI: remove bogus #error Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 17:34   ` Alan Stern
2013-05-02 17:34     ` Alan Stern
2013-05-02 17:55     ` Arnd Bergmann
2013-05-02 17:55       ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 16/22] USB: UHCI: clarify Kconfig dependencies Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 17:30   ` Alan Stern
2013-05-02 17:30     ` Alan Stern
2013-05-02 17:52     ` Arnd Bergmann
2013-05-02 17:52       ` Arnd Bergmann
2013-05-02 18:27       ` Alan Stern
2013-05-02 18:27         ` Alan Stern
2013-05-02 19:12         ` Arnd Bergmann
2013-05-02 19:12           ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 17/22] USB: OHCI: " Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 18/22] Xen: SWIOTLB is only used on x86 Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:38   ` Stefano Stabellini
2013-05-02 15:38     ` Stefano Stabellini
2013-05-02 18:13     ` Konrad Rzeszutek Wilk
2013-05-02 18:13       ` Konrad Rzeszutek Wilk
2013-05-02 18:16       ` Arnd Bergmann
2013-05-02 18:16         ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 19/22] staging/solo6x10: depend on CONFIG_FONTS Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-23 20:15   ` Geert Uytterhoeven
2013-05-23 20:15     ` Geert Uytterhoeven
2013-05-23 21:47     ` Arnd Bergmann
2013-05-23 21:47       ` Arnd Bergmann
2013-05-02 15:16 ` [PATCH, RFC 20/22] media: coda: select GENERIC_ALLOCATOR Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 17:20   ` Alexander Shiyan
2013-05-02 17:20     ` Alexander Shiyan
2013-05-02 19:53     ` Arnd Bergmann
2013-05-02 19:53       ` Arnd Bergmann
2013-05-03  2:33       ` Shawn Guo
2013-05-03  2:33         ` Shawn Guo
2013-05-02 15:16 ` [PATCH, RFC 21/22] davinci: vpfe_capture needs i2c Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-03 11:00   ` Prabhakar Lad
2013-05-03 11:00     ` Prabhakar Lad
2013-05-02 15:16 ` [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC Arnd Bergmann
2013-05-02 15:16   ` Arnd Bergmann
2013-05-02 15:24   ` edubezval
2013-05-02 15:24     ` edubezval at gmail.com
2013-05-02 16:25     ` Arnd Bergmann
2013-05-02 16:25       ` Arnd Bergmann
2013-05-02 17:37   ` Mauro Carvalho Chehab
2013-05-02 17:37     ` Mauro Carvalho Chehab
2013-05-02 17:57     ` Arnd Bergmann
2013-05-02 17:57       ` Arnd Bergmann
2013-05-02 18:53 ` [PATCH, RFC 00/22] ARM randconfig bugs Rafael J. Wysocki
2013-05-02 18:53   ` Rafael J. Wysocki
2013-05-02 18:53   ` Rafael J. Wysocki
2013-05-02 23:52 ` Re : [PATCH, RFC 09/22] crypto: lz4: don't build on ARM Chanho Min
2013-05-02 23:52   ` Chanho Min
2013-05-03 15:29   ` Re : " Arnd Bergmann
2013-05-03 15:29     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51828A45.60909@ti.com \
    --to=eduardo.valentin@ti.com \
    --cc=amit.daniel@samsung.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.