From: Sekhar Nori <nsekhar@ti.com>
To: Joel A Fernandes <joelagnel@ti.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>
Cc: Tony Lindgren <tony@atomide.com>, Matt Porter <matt@ohporter.com>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Benoit Cousson <b-cousson@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Rob Landley <rob@landley.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Kridner <jkridner@beagleboard.org>,
Koen Kooi <koen@beagleboard.org>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux SPI Devel List <spi-devel-general@lists.sourceforge.net>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding
Date: Mon, 17 Jun 2013 16:31:24 +0530 [thread overview]
Message-ID: <51BEEC84.1080102@ti.com> (raw)
In-Reply-To: <1371263570-9323-5-git-send-email-joelagnel@ti.com>
Grant, Rob,
Can one of you please take a look at this patch and see if you have any
comments on the binding definition?
Joel,
Ideally the bindings are described before they are used or along with
its usage. In that aspect, this patch is present too far back in the
series. Can you please fix this if you get to posting another version. I
think I gave the same comment on v9 as well.
On 6/15/2013 8:02 AM, Joel A Fernandes wrote:
> From: Matt Porter <mdp@ti.com>
>
> The binding definition is based on the generic DMA controller
> binding.
>
> Joel: Droped reserved and queue DT entries from Documentation
> for now from the original patch series.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
> Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
> ---
> Documentation/devicetree/bindings/dma/ti-edma.txt | 26 +++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt
> new file mode 100644
> index 0000000..ada0018
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
> @@ -0,0 +1,26 @@
> +TI EDMA
> +
> +Required properties:
> +- compatible : "ti,edma3"
> +- ti,hwmods: Name of the hwmods associated to the EDMA
ti,hwmods should be optional, no? hwmod is not present on DaVinci where
EDMA is also used. If it is not optional then these bindings wont work
there.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: Joel A Fernandes <joelagnel-l0cyMroinI0@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Cc: Linux DaVinci Kernel List
<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Linux Documentation List
<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Linux MMC List
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Koen Kooi <koen-hcmAuCOw+vXj4SYmN/TMmA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jason Kridner <jkridner-hcmAuCOw+vXj4SYmN/TMmA@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
Linux SPI Devel List
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linux OMAP List <linux-omap-u79uwXL29TY@public.gmane.org>
Subject: Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding
Date: Mon, 17 Jun 2013 16:31:24 +0530 [thread overview]
Message-ID: <51BEEC84.1080102@ti.com> (raw)
In-Reply-To: <1371263570-9323-5-git-send-email-joelagnel-l0cyMroinI0@public.gmane.org>
Grant, Rob,
Can one of you please take a look at this patch and see if you have any
comments on the binding definition?
Joel,
Ideally the bindings are described before they are used or along with
its usage. In that aspect, this patch is present too far back in the
series. Can you please fix this if you get to posting another version. I
think I gave the same comment on v9 as well.
On 6/15/2013 8:02 AM, Joel A Fernandes wrote:
> From: Matt Porter <mdp-l0cyMroinI0@public.gmane.org>
>
> The binding definition is based on the generic DMA controller
> binding.
>
> Joel: Droped reserved and queue DT entries from Documentation
> for now from the original patch series.
>
> Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Joel A Fernandes <joelagnel-l0cyMroinI0@public.gmane.org>
> ---
> Documentation/devicetree/bindings/dma/ti-edma.txt | 26 +++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt
> new file mode 100644
> index 0000000..ada0018
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
> @@ -0,0 +1,26 @@
> +TI EDMA
> +
> +Required properties:
> +- compatible : "ti,edma3"
> +- ti,hwmods: Name of the hwmods associated to the EDMA
ti,hwmods should be optional, no? hwmod is not present on DaVinci where
EDMA is also used. If it is not optional then these bindings wont work
there.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: Joel A Fernandes <joelagnel-l0cyMroinI0@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Cc: Linux DaVinci Kernel List
<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Linux Documentation List
<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Linux MMC List
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Koen Kooi <koen-hcmAuCOw+vXj4SYmN/TMmA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jason Kridner <jkridner-hcmAuCOw+vXj4SYmN/TMmA@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
Linux SPI Devel List
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linux OMAP List <linux-omap-u79uwXL29TY@public.gmane.org
Subject: Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding
Date: Mon, 17 Jun 2013 16:31:24 +0530 [thread overview]
Message-ID: <51BEEC84.1080102@ti.com> (raw)
In-Reply-To: <1371263570-9323-5-git-send-email-joelagnel-l0cyMroinI0@public.gmane.org>
Grant, Rob,
Can one of you please take a look at this patch and see if you have any
comments on the binding definition?
Joel,
Ideally the bindings are described before they are used or along with
its usage. In that aspect, this patch is present too far back in the
series. Can you please fix this if you get to posting another version. I
think I gave the same comment on v9 as well.
On 6/15/2013 8:02 AM, Joel A Fernandes wrote:
> From: Matt Porter <mdp-l0cyMroinI0@public.gmane.org>
>
> The binding definition is based on the generic DMA controller
> binding.
>
> Joel: Droped reserved and queue DT entries from Documentation
> for now from the original patch series.
>
> Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Joel A Fernandes <joelagnel-l0cyMroinI0@public.gmane.org>
> ---
> Documentation/devicetree/bindings/dma/ti-edma.txt | 26 +++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt
> new file mode 100644
> index 0000000..ada0018
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
> @@ -0,0 +1,26 @@
> +TI EDMA
> +
> +Required properties:
> +- compatible : "ti,edma3"
> +- ti,hwmods: Name of the hwmods associated to the EDMA
ti,hwmods should be optional, no? hwmod is not present on DaVinci where
EDMA is also used. If it is not optional then these bindings wont work
there.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding
Date: Mon, 17 Jun 2013 16:31:24 +0530 [thread overview]
Message-ID: <51BEEC84.1080102@ti.com> (raw)
In-Reply-To: <1371263570-9323-5-git-send-email-joelagnel@ti.com>
Grant, Rob,
Can one of you please take a look at this patch and see if you have any
comments on the binding definition?
Joel,
Ideally the bindings are described before they are used or along with
its usage. In that aspect, this patch is present too far back in the
series. Can you please fix this if you get to posting another version. I
think I gave the same comment on v9 as well.
On 6/15/2013 8:02 AM, Joel A Fernandes wrote:
> From: Matt Porter <mdp@ti.com>
>
> The binding definition is based on the generic DMA controller
> binding.
>
> Joel: Droped reserved and queue DT entries from Documentation
> for now from the original patch series.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
> Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
> ---
> Documentation/devicetree/bindings/dma/ti-edma.txt | 26 +++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt
> new file mode 100644
> index 0000000..ada0018
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
> @@ -0,0 +1,26 @@
> +TI EDMA
> +
> +Required properties:
> +- compatible : "ti,edma3"
> +- ti,hwmods: Name of the hwmods associated to the EDMA
ti,hwmods should be optional, no? hwmod is not present on DaVinci where
EDMA is also used. If it is not optional then these bindings wont work
there.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-06-17 11:02 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 2:32 [PATCH v10 1/8] ARM: edma: Add AM33XX support to the private EDMA API Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` [PATCH v10 2/8] ARM: edma: Add AM33XX EDMA crossbar event mux support Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` [PATCH v10 3/8] ARM: dts: add AM33XX EDMA support Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` [PATCH v10 4/8] dmaengine: edma: enable build for AM33XX Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-17 11:01 ` Sekhar Nori [this message]
2013-06-17 11:01 ` Sekhar Nori
2013-06-17 11:01 ` Sekhar Nori
2013-06-17 11:01 ` Sekhar Nori
2013-06-17 15:05 ` Fernandes, Joel A
2013-06-17 15:05 ` Fernandes, Joel A
2013-06-17 15:05 ` Fernandes, Joel A
2013-06-17 11:12 ` Arnd Bergmann
2013-06-17 11:12 ` Arnd Bergmann
2013-06-17 11:12 ` Arnd Bergmann
2013-06-17 15:40 ` Fernandes, Joel A
2013-06-17 15:40 ` Fernandes, Joel A
2013-06-17 15:40 ` Fernandes, Joel A
2013-06-17 15:40 ` Fernandes, Joel A
2013-06-17 16:19 ` Arnd Bergmann
2013-06-17 16:19 ` Arnd Bergmann
2013-06-17 16:19 ` Arnd Bergmann
2013-06-17 16:25 ` Fernandes, Joel A
2013-06-17 16:25 ` Fernandes, Joel A
2013-06-17 16:25 ` Fernandes, Joel A
2013-06-17 16:25 ` Fernandes, Joel A
2013-06-18 4:40 ` Sekhar Nori
2013-06-18 4:40 ` Sekhar Nori
2013-06-18 4:40 ` Sekhar Nori
2013-06-18 4:40 ` Sekhar Nori
2013-06-15 2:32 ` [PATCH v10 6/8] spi: omap2-mcspi: add generic DMA request support to the DT binding Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` [PATCH v10 7/8] spi: omap2-mcspi: convert to dma_request_slave_channel_compat() Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` [PATCH v10 8/8] ARM: dts: add AM33XX SPI DMA support Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
2013-06-15 2:32 ` Joel A Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BEEC84.1080102@ti.com \
--to=nsekhar@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jkridner@beagleboard.org \
--cc=joelagnel@ti.com \
--cc=koen@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@ohporter.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.