From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource()
Date: Thu, 27 Jun 2013 13:04:45 +0000 [thread overview]
Message-ID: <51CC386D.30309@cogentembedded.com> (raw)
In-Reply-To: <1372326574-4315-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 27-06-2013 13:49, Laurent Pinchart wrote:
> Replace the devm_request_mem_region() and devm_ioremap_nocache() calls
> with devm_ioremap_resource().
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 20 ++------------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 003b34e..24ab0ca 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
[...]
> @@ -129,24 +128,9 @@ static int rcar_du_load(struct drm_device *dev, unsigned long flags)
>
> /* I/O resources and clocks */
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
[...]
> + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem);
> + if (IS_ERR(rcdu->mmio))
> return -ENOMEM;
You should return PTR_ERR(rcdu->mmio).
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource()
Date: Thu, 27 Jun 2013 17:04:45 +0400 [thread overview]
Message-ID: <51CC386D.30309@cogentembedded.com> (raw)
In-Reply-To: <1372326574-4315-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 27-06-2013 13:49, Laurent Pinchart wrote:
> Replace the devm_request_mem_region() and devm_ioremap_nocache() calls
> with devm_ioremap_resource().
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 20 ++------------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 003b34e..24ab0ca 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
[...]
> @@ -129,24 +128,9 @@ static int rcar_du_load(struct drm_device *dev, unsigned long flags)
>
> /* I/O resources and clocks */
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
[...]
> + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem);
> + if (IS_ERR(rcdu->mmio))
> return -ENOMEM;
You should return PTR_ERR(rcdu->mmio).
WBR, Sergei
next prev parent reply other threads:[~2013-06-27 13:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 9:49 [PATCH 00/24] R-Car DU DRM support for R8A7790 Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 01/24] drm/rcar-du: Add missing alpha plane register definitions Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource() Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 13:04 ` Sergei Shtylyov [this message]
2013-06-27 13:04 ` Sergei Shtylyov
2013-07-01 14:30 ` Laurent Pinchart
2013-07-01 14:30 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 03/24] drm/rcar-du: Add platform module device table Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 04/24] drm/rcar-du: Don't ignore rcar_du_crtc_create() return value Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 05/24] drm/rcar-du: Support per-CRTC clock and IRQ Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 06/24] drm/rcar-du: Fix buffer pitch alignment Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 07/24] drm/rcar-du: Clarify comment regarding plane Y source coordinate Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 08/24] drm/rcar-du: Split LVDS encoder and connector Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 09/24] drm/rcar-du: Split VGA " Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 10/24] drm/rcar-du: Merge LVDS and VGA encoder code Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 11/24] drm/rcar-du: Rename platform data fields to match what they describe Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 12/24] drm/rcar-du: Create rcar_du_planes structure Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 13/24] drm/rcar-du: Rename rcar_du_plane_(init|register) to rcar_du_planes_* Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 14/24] drm/rcar-du: Introduce CRTCs groups Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 15/24] drm/rcar-du: Use dynamic number of CRTCs instead of CRTCs array size Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 16/24] drm/rcar-du: Remove register definitions for the second channel Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 17/24] drm/rcar-du: Move output routing configuration to group Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 18/24] drm/rcar-du: Add support for the R8A7790 DU Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 19/24] drm/rcar-du: Fix buffer pitch alignment for " Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 20/24] drm/rcar-du: Add support for multiple groups Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 21/24] drm/rcar-du: Add support for DEFR8 register Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 22/24] drm/rcar-du: Rework output routing support Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 23/24] drm/rcar-du: Configure RGB output routing to DPAD0 Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
2013-06-27 9:49 ` [PATCH 24/24] drm/rcar-du: Add internal LVDS encoder support Laurent Pinchart
2013-06-27 9:49 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC386D.30309@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.