All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: <linux-btrfs@vger.kernel.org>, <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V3
Date: Wed, 14 Aug 2013 15:48:03 -0500	[thread overview]
Message-ID: <520BED03.6040707@sgi.com> (raw)
In-Reply-To: <1376510872-9951-1-git-send-email-jbacik@fusionio.com>

On 08/14/2013 03:07 PM, Josef Bacik wrote:
> We were allowing users to delete their default subvolume, which is problematic.
> This test is a regression test to make sure we don't let that happen in the
> future.  Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> ---
> V2->V3: remove comment and abstract out the subvolid logic as per Eric's
>    suggestions
> V1->V2: address the comments made by Eric Sandeen.

Thanks for the patch Josef, this has been committed.

--Rich

commit f3df3fab7d3870aab222512126b06668d7db5d71
Author: Josef Bacik <jbacik@fusionio.com>
Date:   Wed Aug 14 20:07:52 2013 +0000

     xfstests: btrfs/009: regression test for subvol delete

     We were allowing users to delete their default subvolume, which is 
problematic.
     This test is a regression test to make sure we don't let that 
happen in the
     future.  Thanks,

     Signed-off-by: Josef Bacik <jbacik@fusionio.com>
     Reviewed-by: Eric Sandeen <sandeen@redhat.com>
     Signed-off-by: Rich Johnston <rjohnston@sgi.com>

     [rjohnston: renumbered test from 003 to 009]


WARNING: multiple messages have this Message-ID (diff)
From: Rich Johnston <rjohnston@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V3
Date: Wed, 14 Aug 2013 15:48:03 -0500	[thread overview]
Message-ID: <520BED03.6040707@sgi.com> (raw)
In-Reply-To: <1376510872-9951-1-git-send-email-jbacik@fusionio.com>

On 08/14/2013 03:07 PM, Josef Bacik wrote:
> We were allowing users to delete their default subvolume, which is problematic.
> This test is a regression test to make sure we don't let that happen in the
> future.  Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> ---
> V2->V3: remove comment and abstract out the subvolid logic as per Eric's
>    suggestions
> V1->V2: address the comments made by Eric Sandeen.

Thanks for the patch Josef, this has been committed.

--Rich

commit f3df3fab7d3870aab222512126b06668d7db5d71
Author: Josef Bacik <jbacik@fusionio.com>
Date:   Wed Aug 14 20:07:52 2013 +0000

     xfstests: btrfs/009: regression test for subvol delete

     We were allowing users to delete their default subvolume, which is 
problematic.
     This test is a regression test to make sure we don't let that 
happen in the
     future.  Thanks,

     Signed-off-by: Josef Bacik <jbacik@fusionio.com>
     Reviewed-by: Eric Sandeen <sandeen@redhat.com>
     Signed-off-by: Rich Johnston <rjohnston@sgi.com>

     [rjohnston: renumbered test from 003 to 009]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-08-14 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 20:07 [PATCH] xfstests: btrfs/003: regression test for subvol delete V3 Josef Bacik
2013-08-14 20:07 ` Josef Bacik
2013-08-14 20:23 ` Eric Sandeen
2013-08-14 20:23   ` Eric Sandeen
2013-08-14 20:48 ` Rich Johnston [this message]
2013-08-14 20:48   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520BED03.6040707@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.