Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, sstabellini@kernel.org,
	anthony.perard@citrix.com, paul@xen.org,
	xen-devel@lists.xenproject.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	John Snow <jsnow@redhat.com>,
	"open list:IDE" <qemu-block@nongnu.org>
Subject: Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()
Date: Mon, 30 May 2022 15:21:18 +0200	[thread overview]
Message-ID: <5220940a-8b7a-6f09-6270-a138f7281c6d@amsat.org> (raw)
In-Reply-To: <20220513180957.90514-4-shentey@gmail.com>

On 13/5/22 20:09, Bernhard Beschow wrote:
> This function was declared in a generic and public header, implemented
> in a device-specific source file but only used in xen_platform. Given its
> 'aux' parameter, this function is more xen-specific than piix-specific.
> Also, the hardcoded magic constants seem to be generic and related to
> PCIIDEState and IDEBus rather than piix.
> 
> Therefore, move this function to xen_platform, unexport it, and drop the
> "piix3" in the function name as well.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Paul Durrant <paul@xen.org>
> ---
>   hw/i386/xen/xen_platform.c | 48 +++++++++++++++++++++++++++++++++++++-
>   hw/ide/piix.c              | 46 ------------------------------------
>   include/hw/ide.h           |  3 ---
>   3 files changed, 47 insertions(+), 50 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>