All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Linus Walleij <linus.walleij@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Grant Likely <grant.likely@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Enric Balletbo i Serra <eballetbo@gmail.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Kevin Hilman <khilman@linaro.org>, Balaji T K <balajitk@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Jon Hunter <jgchunter@gmail.com>
Subject: Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs
Date: Thu, 12 Sep 2013 17:57:00 +0200	[thread overview]
Message-ID: <5231E44C.9070800@ahsoftware.de> (raw)
In-Reply-To: <5231DB88.90605@wwwdotorg.org>

Am 12.09.2013 17:19, schrieb Stephen Warren:
>
> IRQs, DMA channels, and GPIOs are all different things. Their bindings
> are defined independently. While it's good to define new types of
> bindings consistently with other bindings, this hasn't always happened,
> so you can make zero assumptions about the IRQ bindings by reading the
> documentation for any other kind of binding.
>
> Multiple interrupts are defined as follows:
>
> 	// Optional; otherwise inherited from parent/grand-parent/...
> 	interrupt-parent = <&gpio6>;
> 	// Must be in a fixed order, unless binding defines that the
> 	// optional interrupt-names property is to be used.
> 	interrupts = <1 IRQF_TRIGGER_HIGH> <2 IRQF_TRIGGER_LOW>;
> 	// Optional; binding for device defines whether it must
> 	// be present
> 	interrupt-names = "foo", "bar";
>
> If you need multiple interrupts, each with a different parent, you need
> to use an interrupt-map property (Google it for a more complete
> explanation I guess). Unlike "interrupts", "interrupt-map" has a phandle
> in each entry, and hence each entry can refer to a different IRQ
> controller. You end up defining a dummy interrupt controller node (which
> may be the leaf node with multiple IRQ outputs, which then points at
> itself as the interrupt parent), pointing the leaf node's
> interrupt-parent at that node, and then having interrupt-map "demux" the
> N interrupt outputs to the various interrupt controllers.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

What a mess. I assume that is the price that bindings don't have to change.

Thanks for clarifying that,

Alexander Holler

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Holler <holler@ahsoftware.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Kevin Hilman <khilman@linaro.org>, Balaji T K <balajitk@ti.com>,
	Enric Balletbo i Serra <eballetbo@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jon Hunter <jgchunter@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Grant Likely <grant.likely@linaro.org>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs
Date: Thu, 12 Sep 2013 17:57:00 +0200	[thread overview]
Message-ID: <5231E44C.9070800@ahsoftware.de> (raw)
In-Reply-To: <5231DB88.90605@wwwdotorg.org>

Am 12.09.2013 17:19, schrieb Stephen Warren:
>
> IRQs, DMA channels, and GPIOs are all different things. Their bindings
> are defined independently. While it's good to define new types of
> bindings consistently with other bindings, this hasn't always happened,
> so you can make zero assumptions about the IRQ bindings by reading the
> documentation for any other kind of binding.
>
> Multiple interrupts are defined as follows:
>
> 	// Optional; otherwise inherited from parent/grand-parent/...
> 	interrupt-parent = <&gpio6>;
> 	// Must be in a fixed order, unless binding defines that the
> 	// optional interrupt-names property is to be used.
> 	interrupts = <1 IRQF_TRIGGER_HIGH> <2 IRQF_TRIGGER_LOW>;
> 	// Optional; binding for device defines whether it must
> 	// be present
> 	interrupt-names = "foo", "bar";
>
> If you need multiple interrupts, each with a different parent, you need
> to use an interrupt-map property (Google it for a more complete
> explanation I guess). Unlike "interrupts", "interrupt-map" has a phandle
> in each entry, and hence each entry can refer to a different IRQ
> controller. You end up defining a dummy interrupt controller node (which
> may be the leaf node with multiple IRQ outputs, which then points at
> itself as the interrupt parent), pointing the leaf node's
> interrupt-parent at that node, and then having interrupt-map "demux" the
> N interrupt outputs to the various interrupt controllers.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

What a mess. I assume that is the price that bindings don't have to change.

Thanks for clarifying that,

Alexander Holler

WARNING: multiple messages have this Message-ID (diff)
From: holler@ahsoftware.de (Alexander Holler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RFC: interrupt consistency check for OF GPIO IRQs
Date: Thu, 12 Sep 2013 17:57:00 +0200	[thread overview]
Message-ID: <5231E44C.9070800@ahsoftware.de> (raw)
In-Reply-To: <5231DB88.90605@wwwdotorg.org>

Am 12.09.2013 17:19, schrieb Stephen Warren:
>
> IRQs, DMA channels, and GPIOs are all different things. Their bindings
> are defined independently. While it's good to define new types of
> bindings consistently with other bindings, this hasn't always happened,
> so you can make zero assumptions about the IRQ bindings by reading the
> documentation for any other kind of binding.
>
> Multiple interrupts are defined as follows:
>
> 	// Optional; otherwise inherited from parent/grand-parent/...
> 	interrupt-parent = <&gpio6>;
> 	// Must be in a fixed order, unless binding defines that the
> 	// optional interrupt-names property is to be used.
> 	interrupts = <1 IRQF_TRIGGER_HIGH> <2 IRQF_TRIGGER_LOW>;
> 	// Optional; binding for device defines whether it must
> 	// be present
> 	interrupt-names = "foo", "bar";
>
> If you need multiple interrupts, each with a different parent, you need
> to use an interrupt-map property (Google it for a more complete
> explanation I guess). Unlike "interrupts", "interrupt-map" has a phandle
> in each entry, and hence each entry can refer to a different IRQ
> controller. You end up defining a dummy interrupt controller node (which
> may be the leaf node with multiple IRQ outputs, which then points at
> itself as the interrupt parent), pointing the leaf node's
> interrupt-parent at that node, and then having interrupt-map "demux" the
> N interrupt outputs to the various interrupt controllers.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

What a mess. I assume that is the price that bindings don't have to change.

Thanks for clarifying that,

Alexander Holler

  reply	other threads:[~2013-09-12 15:57 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 12:36 [PATCH] RFC: interrupt consistency check for OF GPIO IRQs Linus Walleij
2013-07-30  4:30 ` Grant Likely
2013-07-30  4:30   ` Grant Likely
2013-07-30  4:30   ` Grant Likely
2013-07-30 23:44   ` Linus Walleij
2013-07-30 23:44     ` Linus Walleij
2013-07-30 23:44     ` Linus Walleij
2013-07-31  8:35     ` Javier Martinez Canillas
2013-07-31  8:35       ` Javier Martinez Canillas
2013-07-31  8:35       ` Javier Martinez Canillas
2013-08-02  9:57       ` Alexander Holler
2013-08-02  9:57         ` Alexander Holler
2013-08-02  9:57         ` Alexander Holler
2013-08-02 15:35         ` Alexander Holler
2013-08-02 15:35           ` Alexander Holler
2013-08-02 15:35           ` Alexander Holler
2013-08-03  7:23           ` Alexander Holler
2013-08-03  7:23             ` Alexander Holler
2013-08-03  7:23             ` Alexander Holler
2013-09-10  7:00       ` Joel Fernandes
2013-09-10  7:00         ` Joel Fernandes
2013-09-10  7:00         ` Joel Fernandes
2013-09-10 13:17         ` Javier Martinez Canillas
2013-09-10 13:17           ` Javier Martinez Canillas
2013-09-10 13:17           ` Javier Martinez Canillas
2013-09-10 15:00           ` Joel Fernandes
2013-09-10 15:00             ` Joel Fernandes
2013-09-10 15:00             ` Joel Fernandes
2013-09-10 15:48             ` Javier Martinez Canillas
2013-09-10 15:48               ` Javier Martinez Canillas
2013-09-10 15:48               ` Javier Martinez Canillas
2013-09-10 16:25               ` Joel Fernandes
2013-09-10 16:25                 ` Joel Fernandes
2013-09-10 16:25                 ` Joel Fernandes
2013-09-11  7:05             ` Alexander Holler
2013-09-11  7:05               ` Alexander Holler
2013-09-11  7:05               ` Alexander Holler
2013-09-11  7:16               ` Alexander Holler
2013-09-11  7:16                 ` Alexander Holler
2013-09-11  7:16                 ` Alexander Holler
2013-09-11  7:30                 ` Alexander Holler
2013-09-11  7:30                   ` Alexander Holler
2013-09-11  7:30                   ` Alexander Holler
2013-09-11  7:36                   ` Alexander Holler
2013-09-11  7:36                     ` Alexander Holler
2013-09-11  7:36                     ` Alexander Holler
2013-08-13  9:52     ` Lars Poeschel
2013-08-13  9:52       ` Lars Poeschel
2013-08-13  9:52       ` Lars Poeschel
2013-08-19 22:04     ` Laurent Pinchart
2013-08-19 22:04       ` Laurent Pinchart
2013-08-19 22:04       ` Laurent Pinchart
2013-08-21 22:02       ` Linus Walleij
2013-08-21 22:02         ` Linus Walleij
2013-08-21 22:02         ` Linus Walleij
2013-09-06 15:32         ` Laurent Pinchart
2013-09-06 15:32           ` Laurent Pinchart
2013-09-06 15:32           ` Laurent Pinchart
2013-09-11 15:30         ` Alexander Holler
2013-09-11 15:30           ` Alexander Holler
2013-09-11 15:30           ` Alexander Holler
2013-09-11 16:14           ` Javier Martinez Canillas
2013-09-11 16:14             ` Javier Martinez Canillas
2013-09-11 16:14             ` Javier Martinez Canillas
2013-09-11 17:42             ` Alexander Holler
2013-09-11 17:42               ` Alexander Holler
2013-09-11 17:42               ` Alexander Holler
2013-09-12  8:55               ` Alexander Holler
2013-09-12  8:55                 ` Alexander Holler
2013-09-12  8:55                 ` Alexander Holler
2013-09-12 10:11                 ` Javier Martinez Canillas
2013-09-12 10:11                   ` Javier Martinez Canillas
2013-09-12 10:11                   ` Javier Martinez Canillas
2013-09-12 10:28                   ` Alexander Holler
2013-09-12 10:28                     ` Alexander Holler
2013-09-12 10:28                     ` Alexander Holler
2013-09-12 11:09                     ` Alexander Holler
2013-09-12 11:09                       ` Alexander Holler
2013-09-12 11:09                       ` Alexander Holler
2013-09-12 11:26                       ` Alexander Holler
2013-09-12 11:26                         ` Alexander Holler
2013-09-12 11:26                         ` Alexander Holler
2013-09-12 11:37                         ` Alexander Holler
2013-09-12 11:37                           ` Alexander Holler
2013-09-12 11:37                           ` Alexander Holler
2013-09-12 15:19                           ` Stephen Warren
2013-09-12 15:19                             ` Stephen Warren
2013-09-12 15:19                             ` Stephen Warren
2013-09-12 15:57                             ` Alexander Holler [this message]
2013-09-12 15:57                               ` Alexander Holler
2013-09-12 15:57                               ` Alexander Holler
2013-09-18  0:36                               ` Grant Likely
2013-09-18  0:36                                 ` Grant Likely
2013-09-18  0:36                                 ` Grant Likely
2013-10-20 12:41                                 ` Laurent Pinchart
2013-10-20 12:41                                   ` Laurent Pinchart
2013-10-20 12:41                                   ` Laurent Pinchart
2013-10-20 15:51                                   ` Tony Lindgren
2013-10-20 15:51                                     ` Tony Lindgren
2013-10-20 15:51                                     ` Tony Lindgren
2013-10-20 21:35                                   ` Stephen Warren
2013-10-20 21:35                                     ` Stephen Warren
2013-10-20 21:35                                     ` Stephen Warren
2013-10-21 23:26                                     ` Laurent Pinchart
2013-10-21 23:26                                       ` Laurent Pinchart
2013-10-21 23:26                                       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5231E44C.9070800@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=balajitk@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eballetbo@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=jgchunter@gmail.com \
    --cc=khilman@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.