Re: [linux-cifs-client] [PATCH] cifs: wrap cifs_dnotify_thread in CONFIG_BROKEN

From: Steve French <smfrench@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Layton <jlayton@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org,
	linux-kernel@vger.kernel.org
Subject: Re: [linux-cifs-client] [PATCH] cifs: wrap cifs_dnotify_thread in  CONFIG_BROKEN
Date: Thu, 22 Jan 2009 17:13:37 -0600	[thread overview]
Message-ID: <524f69650901221513m7857488by6713eca64ee31681@mail.gmail.com> (raw)
In-Reply-To: <20090122210655.GA6065@infradead.org>

The thread may be renamed/rewritten etc. - but we badly need to finish
the dnotify / inotify code ... removing the start on this that someone
wrote in the past isn't getting us any closer to this.

dnotify/inotify support was added to Linux in the first place because
Samba used it to handle this common operation (it is commonly used by
OTHER cifs clients) ... but none of the Linux cluster/network file
systems have had time to finish the code ... we need to finish this -
the network protocol portion of this is now well documented (and we
presumably will need a thread to process the dnotify multishot
notification responses so we don't clog up the demultiplex thread
waiting on kde and gnoe)

On Thu, Jan 22, 2009 at 3:06 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Jan 22, 2009 at 11:34:38AM -0500, Jeff Layton wrote:
>> This thread never actually did anything useful, so comment it out by
>> #ifdef'ing it in CONFIG_BROKEN. My preference would be to remove it
>> altogether, but it's not my call.
>
> Please just kill it.  It's not only useless but also ugly, so keeping it
> around it a double disservice to the mother nature.
>
>

-- 
Thanks,

Steve