From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Eric B??nard <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Lothar Wa??mann
<LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Subject: Re: [PATCHv4] video: backlight: gpio-backlight: Add DT support.
Date: Wed, 23 Oct 2013 17:51:13 +0100 [thread overview]
Message-ID: <5267FE81.3070201@wwwdotorg.org> (raw)
In-Reply-To: <20131022200141.GA8037@mithrandir>
On 10/22/2013 09:01 PM, Thierry Reding wrote:
> On Tue, Oct 22, 2013 at 05:34:45PM +0200, Jean-Christophe
> PLAGNIOL-VILLARD wrote:
...
>> I'm sorry but the blacklight descibe in DT have nothing to do
>> with the common pratice that the current driver have today
>
> That's not at all what I said. What I said was that the majority
> of backlight drivers currently default to turning the backlight on
> when probed. Therefore I think it would be consistent if this
> driver did the same.
>
> I also said that I don't think it's a very good default, but at the
> same time we can't just go and change the default behaviour at will
> because people may rely on it.
It may well be reasonable to change the default behaviour for devices
instantiated from DT. If it's not possible to instantiate the device
from DT yet, then it's not possible for anyone to be relying on the
default behaviour yet, since there is none. So, perhaps the default
could be:
* If device instantiated from a board file, default to on, for
backwards-compatibility.
* If device instantiated from DT, there is no backwards compatibility
to be concerned with, since this is a new feature, hence default to
off, since we think that's the correct thing to do.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4] video: backlight: gpio-backlight: Add DT support.
Date: Wed, 23 Oct 2013 17:51:13 +0100 [thread overview]
Message-ID: <5267FE81.3070201@wwwdotorg.org> (raw)
In-Reply-To: <20131022200141.GA8037@mithrandir>
On 10/22/2013 09:01 PM, Thierry Reding wrote:
> On Tue, Oct 22, 2013 at 05:34:45PM +0200, Jean-Christophe
> PLAGNIOL-VILLARD wrote:
...
>> I'm sorry but the blacklight descibe in DT have nothing to do
>> with the common pratice that the current driver have today
>
> That's not at all what I said. What I said was that the majority
> of backlight drivers currently default to turning the backlight on
> when probed. Therefore I think it would be consistent if this
> driver did the same.
>
> I also said that I don't think it's a very good default, but at the
> same time we can't just go and change the default behaviour at will
> because people may rely on it.
It may well be reasonable to change the default behaviour for devices
instantiated from DT. If it's not possible to instantiate the device
from DT yet, then it's not possible for anyone to be relying on the
default behaviour yet, since there is none. So, perhaps the default
could be:
* If device instantiated from a board file, default to on, for
backwards-compatibility.
* If device instantiated from DT, there is no backwards compatibility
to be concerned with, since this is a new feature, hence default to
off, since we think that's the correct thing to do.
next prev parent reply other threads:[~2013-10-23 16:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 15:04 [PATCH 01/11] of: add vendor prefix for Eukréa Electromatique Denis Carikli
2013-10-18 15:04 ` Denis Carikli
2013-10-18 15:04 ` [PATCH 02/11] video: imxfb: Introduce regulator support Denis Carikli
2013-10-18 15:04 ` Denis Carikli
2013-10-19 10:45 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-19 10:45 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20131019104555.GI18477-HVbc7XotTAhnXn40ka+A6Q@public.gmane.org>
2013-10-21 9:13 ` [PATCHv4] video: backlight: gpio-backlight: Add DT support Denis Carikli
2013-10-21 9:13 ` Denis Carikli
[not found] ` <1382346813-8449-1-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
2013-10-21 22:48 ` Laurent Pinchart
2013-10-21 22:48 ` Laurent Pinchart
2013-10-22 5:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-22 5:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-22 4:58 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-22 4:58 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20131022045833.GB17512-HVbc7XotTAhnXn40ka+A6Q@public.gmane.org>
2013-10-22 7:23 ` Thierry Reding
2013-10-22 7:23 ` Thierry Reding
2013-10-22 15:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-22 15:34 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20131022153445.GD17512-HVbc7XotTAhnXn40ka+A6Q@public.gmane.org>
2013-10-22 20:01 ` Thierry Reding
2013-10-22 20:01 ` Thierry Reding
2013-10-23 13:42 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-23 13:42 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20131023134236.GE17512-HVbc7XotTAhnXn40ka+A6Q@public.gmane.org>
2013-10-23 16:49 ` Stephen Warren
2013-10-23 16:49 ` Stephen Warren
[not found] ` <5267FE02.6000001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-23 20:08 ` Thierry Reding
2013-10-23 20:08 ` Thierry Reding
2013-10-23 16:51 ` Stephen Warren [this message]
2013-10-23 16:51 ` Stephen Warren
[not found] ` <5267FE81.3070201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-23 20:20 ` Thierry Reding
2013-10-23 20:20 ` Thierry Reding
2013-10-23 22:38 ` Laurent Pinchart
2013-10-23 22:38 ` Laurent Pinchart
2013-10-24 11:05 ` Thierry Reding
2013-10-24 11:05 ` Thierry Reding
[not found] ` <20131024110524.GB11296-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-10-25 13:57 ` Laurent Pinchart
2013-10-25 13:57 ` Laurent Pinchart
2013-10-31 23:44 ` Jingoo Han
2013-10-31 23:44 ` Jingoo Han
[not found] ` <003701ced693$2f856150$8e9023f0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-01 9:57 ` Thierry Reding
2013-11-01 9:57 ` Thierry Reding
[not found] ` <20131101095754.GJ27864-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-11-04 0:20 ` Jingoo Han
2013-11-04 0:20 ` Jingoo Han
2013-10-31 23:37 ` Jingoo Han
2013-10-31 23:37 ` Jingoo Han
[not found] ` <001e01ced692$267a6d90$736f48b0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-01 10:13 ` Thierry Reding
2013-11-01 10:13 ` Thierry Reding
[not found] ` <20131101101346.GK27864-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-11-06 0:08 ` Laurent Pinchart
2013-11-06 0:08 ` Laurent Pinchart
2013-10-25 20:10 ` Grant Likely
2013-10-25 20:10 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5267FE81.3070201@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org \
--cc=denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.