From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH] clk: Properly initialize reference count
Date: Thu, 31 Oct 2013 13:09:11 -0600 [thread overview]
Message-ID: <5272AAD7.9050305@wwwdotorg.org> (raw)
In-Reply-To: <1383220962-26836-1-git-send-email-treding@nvidia.com>
On 10/31/2013 06:02 AM, Thierry Reding wrote:
> Commit a336ed7 (clk: Implement clk_unregister()) initializes the kref in
> clk_set_parent(), which is obviously the wrong place. Further research
> shows that the original patches initialized it correctly, so it probably
> ended up in clk_set_parent() by mistake during manual application of the
> patch.
Tested-by: Stephen Warren <swarren@nvidia.com>
BTW, it'd be nice to Cc fixes like this to linux-next@vger.kernel.org; I
/might/ have avoided doing a bisect if I'd seen this patch first!
I see the benefit of that "linux-next plus today's accumulated
bug-fixes" tree that I think you proposed:-)
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Properly initialize reference count
Date: Thu, 31 Oct 2013 13:09:11 -0600 [thread overview]
Message-ID: <5272AAD7.9050305@wwwdotorg.org> (raw)
In-Reply-To: <1383220962-26836-1-git-send-email-treding@nvidia.com>
On 10/31/2013 06:02 AM, Thierry Reding wrote:
> Commit a336ed7 (clk: Implement clk_unregister()) initializes the kref in
> clk_set_parent(), which is obviously the wrong place. Further research
> shows that the original patches initialized it correctly, so it probably
> ended up in clk_set_parent() by mistake during manual application of the
> patch.
Tested-by: Stephen Warren <swarren@nvidia.com>
BTW, it'd be nice to Cc fixes like this to linux-next at vger.kernel.org; I
/might/ have avoided doing a bisect if I'd seen this patch first!
I see the benefit of that "linux-next plus today's accumulated
bug-fixes" tree that I think you proposed:-)
next prev parent reply other threads:[~2013-10-31 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 12:02 [PATCH] clk: Properly initialize reference count Thierry Reding
2013-10-31 19:09 ` Stephen Warren [this message]
2013-10-31 19:09 ` Stephen Warren
2013-11-01 9:23 ` Thierry Reding
2013-11-01 9:23 ` Thierry Reding
2013-10-31 20:03 ` Fabio Estevam
2013-11-04 8:47 ` Jonas Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5272AAD7.9050305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.