From: Stephen Boyd <sboyd@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Rohit Vaswani <rvaswani@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2 1/9] devicetree: bindings: Document Krait/Scorpion cpus and enable-method
Date: Wed, 08 Jan 2014 15:21:49 -0800 [thread overview]
Message-ID: <52CDDD8D.5090100@codeaurora.org> (raw)
In-Reply-To: <20140108142139.GJ6701@e106331-lin.cambridge.arm.com>
On 01/08/14 06:21, Mark Rutland wrote:
> On Tue, Dec 24, 2013 at 12:39:45AM +0000, Stephen Boyd wrote:
>> From: Rohit Vaswani <rvaswani@codeaurora.org>
>>
>> Scorpion and Krait don't use the spin-table enable-method.
>> Instead they rely on mmio register accesses to enable power and
>> clocks to bring CPUs out of reset. Document their enable-methods.
>>
>> Cc: <devicetree@vger.kernel.org>
>> Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
>> [sboyd: Split off into separate patch, renamed methods to
>> match compatible nodes]
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/arm/cpus.txt | 25 ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
>> index 9130435..333f4ae 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.txt
>> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
>> @@ -180,7 +180,11 @@ nodes to be present and contain the properties described below.
>> be one of:
>> "spin-table"
>> "psci"
>> - # On ARM 32-bit systems this property is optional.
>> + # On ARM 32-bit systems this property is optional and
>> + can be one of:
>> + "qcom,gcc-msm8660"
>> + "qcom,kpss-acc-v1"
>> + "qcom,kpss-acc-v2"
> It would be nice to document "psci" here as valid for 32-bit.
>
> Currently the PSCI code doesn't inspect the enable-method and assumes it
> if there's a psci node, but KVM tool and others set enable-method to
> "psci", and if we change the way the PSCI code probes it will require
> enable-method to be set for PSCI to work.
Sure. I'll squash it in if I resend, or send a follow-up patch later on.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] devicetree: bindings: Document Krait/Scorpion cpus and enable-method
Date: Wed, 08 Jan 2014 15:21:49 -0800 [thread overview]
Message-ID: <52CDDD8D.5090100@codeaurora.org> (raw)
In-Reply-To: <20140108142139.GJ6701@e106331-lin.cambridge.arm.com>
On 01/08/14 06:21, Mark Rutland wrote:
> On Tue, Dec 24, 2013 at 12:39:45AM +0000, Stephen Boyd wrote:
>> From: Rohit Vaswani <rvaswani@codeaurora.org>
>>
>> Scorpion and Krait don't use the spin-table enable-method.
>> Instead they rely on mmio register accesses to enable power and
>> clocks to bring CPUs out of reset. Document their enable-methods.
>>
>> Cc: <devicetree@vger.kernel.org>
>> Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
>> [sboyd: Split off into separate patch, renamed methods to
>> match compatible nodes]
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/arm/cpus.txt | 25 ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
>> index 9130435..333f4ae 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.txt
>> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
>> @@ -180,7 +180,11 @@ nodes to be present and contain the properties described below.
>> be one of:
>> "spin-table"
>> "psci"
>> - # On ARM 32-bit systems this property is optional.
>> + # On ARM 32-bit systems this property is optional and
>> + can be one of:
>> + "qcom,gcc-msm8660"
>> + "qcom,kpss-acc-v1"
>> + "qcom,kpss-acc-v2"
> It would be nice to document "psci" here as valid for 32-bit.
>
> Currently the PSCI code doesn't inspect the enable-method and assumes it
> if there's a psci node, but KVM tool and others set enable-method to
> "psci", and if we change the way the PSCI code probes it will require
> enable-method to be set for PSCI to work.
Sure. I'll squash it in if I resend, or send a follow-up patch later on.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-01-08 23:21 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 0:39 [PATCH v2 0/9] CPU enable method based SMP/hotplug + MSM conversion Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 1/9] devicetree: bindings: Document Krait/Scorpion cpus and enable-method Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
[not found] ` <1387845593-10050-2-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-08 14:21 ` Mark Rutland
2014-01-08 14:21 ` Mark Rutland
2014-01-08 14:21 ` Mark Rutland
2014-01-08 23:21 ` Stephen Boyd [this message]
2014-01-08 23:21 ` Stephen Boyd
2014-01-08 23:21 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 2/9] devicetree: bindings: Document qcom,kpss-acc Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2014-01-08 14:25 ` Mark Rutland
2014-01-08 14:25 ` Mark Rutland
2014-01-08 14:25 ` Mark Rutland
2014-01-08 14:32 ` Mark Rutland
2014-01-08 14:32 ` Mark Rutland
2014-01-08 14:32 ` Mark Rutland
2014-01-08 23:02 ` Stephen Boyd
2014-01-08 23:02 ` Stephen Boyd
2014-01-08 23:02 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 3/9] devicetree: bindings: Document qcom,saw2 node Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2014-01-08 14:36 ` Mark Rutland
2014-01-08 14:36 ` Mark Rutland
2014-01-08 14:36 ` Mark Rutland
2014-01-08 15:21 ` Mark Rutland
2014-01-08 15:21 ` Mark Rutland
2014-01-08 15:21 ` Mark Rutland
2013-12-24 0:39 ` [PATCH v2 4/9] ARM: Introduce CPU_METHOD_OF_DECLARE() for cpu hotplug/smp Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2014-01-08 15:06 ` Mark Rutland
2014-01-08 15:06 ` Mark Rutland
2014-01-08 15:06 ` Mark Rutland
2013-12-24 0:39 ` [PATCH v2 5/9] ARM: msm: Remove pen_release usage Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 6/9] ARM: msm: Re-organize platsmp to make it extensible Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 7/9] ARM: msm: Add SMP support for KPSSv1 Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 8/9] ARM: msm: Add SMP support for KPSSv2 Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
2013-12-24 0:39 ` [PATCH v2 9/9] ARM: dts: msm: Add nodes necessary for SMP boot Stephen Boyd
2013-12-24 0:39 ` Stephen Boyd
[not found] ` <1387845593-10050-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-06 22:19 ` [PATCH v2 0/9] CPU enable method based SMP/hotplug + MSM conversion Stephen Boyd
2014-01-06 22:19 ` Stephen Boyd
2014-01-06 22:19 ` Stephen Boyd
2014-01-08 15:20 ` Mark Rutland
2014-01-08 15:20 ` Mark Rutland
2014-01-08 15:20 ` Mark Rutland
2014-01-08 21:37 ` Arnd Bergmann
2014-01-08 21:37 ` Arnd Bergmann
2014-01-09 1:50 ` Stephen Boyd
2014-01-09 1:50 ` Stephen Boyd
[not found] ` <52CE005A.3070802-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-23 22:04 ` Kumar Gala
2014-01-23 22:04 ` Kumar Gala
2014-01-23 22:04 ` Kumar Gala
2014-02-07 21:13 ` [PATCH v2 10/9] ARM: msm: Remove board-dt.c Stephen Boyd
2014-02-07 21:13 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CDDD8D.5090100@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.