From: Tomasz Figa <tomasz.figa@gmail.com> To: "Heiko Stübner" <heiko@sntech.de> Cc: Kukjin Kim <kgene.kim@samsung.com>, t.figa@samsung.com, mturquette@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Stephen Warren <swarren@wwwdotorg.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, devicetree@vger.kernel.org Subject: Re: [PATCH 02/12] dt-bindings: document s3c24xx controller for external clock output Date: Sun, 16 Feb 2014 21:51:04 +0100 [thread overview] Message-ID: <530124B8.9050209@gmail.com> (raw) In-Reply-To: <5620516.DA2mHk7Kko@phil> On 16.02.2014 21:33, Heiko Stübner wrote: > Am Sonntag, 9. Februar 2014, 02:54:40 schrieb Tomasz Figa: >> Hi Heiko, >> >> On 13.12.2013 13:59, Heiko Stübner wrote: >>> The clock settings are distributed over a regular register and parts >>> of the misccr register. >>> >>> Signed-off-by: Heiko Stuebner <heiko@sntech.de> >>> --- >>> >>> .../bindings/clock/samsung,s3c2410-dclk.txt | 53 >>> ++++++++++++++++++++ 1 file changed, 53 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt> >>> diff --git >>> a/Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt >>> b/Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt new >>> file mode 100644 >>> index 0000000..0a1f7b1 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt >>> @@ -0,0 +1,53 @@ >>> +* Samsung S3C24XX External Clock Output Controller >>> + >>> +The S3C24XX series can generate clock signals on two clock output pads. >>> +The clock binding described here is applicable to all SoCs in >>> +the s3c24x family. >>> + >>> +Required Properties: >>> + >>> +- compatible: should be one of the following. >>> + - "samsung,s3c2410-dclk" - controller in S3C2410 SoCs. >>> + - "samsung,s3c2412-dclk" - controller in S3C2412 SoCs. >>> + - "samsung,s3c2440-dclk" - controller in S3C2440 and S3C2442 SoCs. >>> + - "samsung,s3c2443-dclk" - controller in S3C2443 and later SoCs. >>> +- reg: physical base address of the controller and length of memory >>> mapped >>> + region. >>> +- #clock-cells: should be 1. >>> +- samsung,misccr: phandle to the syscon managing the misccr register, >>> which + holds configuration settings for different soc-components >>> (clocks, usb, ...). >> Hmm, looking at the datasheet, DCLK and CLKOUT registers seem to be part >> of the pin controller. I wonder if there is really a need for different >> driver and device node to handle them. >> >> Could this be simply made a part of the s3c24xx pinctrl driver, >> extending it to register also a clock provider under the same DT node? > > it could, but of course the non-dt platforms would not be able to use it in > this case. Hmm, that's true. > So I guess, we could get rid of this dt binding, implement the clkout handling > in the pinctrl driver for dt platforms, but use the platform-driver this > binding described for the time we're still handling non-dt s3c24xx machines. I guess you could make this a separate driver that would be instantiated by pinctrl driver registering another platform device in DT case and a static platform device registered by board files in non-DT case. Best regards, Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/12] dt-bindings: document s3c24xx controller for external clock output Date: Sun, 16 Feb 2014 21:51:04 +0100 [thread overview] Message-ID: <530124B8.9050209@gmail.com> (raw) In-Reply-To: <5620516.DA2mHk7Kko@phil> On 16.02.2014 21:33, Heiko St?bner wrote: > Am Sonntag, 9. Februar 2014, 02:54:40 schrieb Tomasz Figa: >> Hi Heiko, >> >> On 13.12.2013 13:59, Heiko St?bner wrote: >>> The clock settings are distributed over a regular register and parts >>> of the misccr register. >>> >>> Signed-off-by: Heiko Stuebner <heiko@sntech.de> >>> --- >>> >>> .../bindings/clock/samsung,s3c2410-dclk.txt | 53 >>> ++++++++++++++++++++ 1 file changed, 53 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt> >>> diff --git >>> a/Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt >>> b/Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt new >>> file mode 100644 >>> index 0000000..0a1f7b1 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt >>> @@ -0,0 +1,53 @@ >>> +* Samsung S3C24XX External Clock Output Controller >>> + >>> +The S3C24XX series can generate clock signals on two clock output pads. >>> +The clock binding described here is applicable to all SoCs in >>> +the s3c24x family. >>> + >>> +Required Properties: >>> + >>> +- compatible: should be one of the following. >>> + - "samsung,s3c2410-dclk" - controller in S3C2410 SoCs. >>> + - "samsung,s3c2412-dclk" - controller in S3C2412 SoCs. >>> + - "samsung,s3c2440-dclk" - controller in S3C2440 and S3C2442 SoCs. >>> + - "samsung,s3c2443-dclk" - controller in S3C2443 and later SoCs. >>> +- reg: physical base address of the controller and length of memory >>> mapped >>> + region. >>> +- #clock-cells: should be 1. >>> +- samsung,misccr: phandle to the syscon managing the misccr register, >>> which + holds configuration settings for different soc-components >>> (clocks, usb, ...). >> Hmm, looking at the datasheet, DCLK and CLKOUT registers seem to be part >> of the pin controller. I wonder if there is really a need for different >> driver and device node to handle them. >> >> Could this be simply made a part of the s3c24xx pinctrl driver, >> extending it to register also a clock provider under the same DT node? > > it could, but of course the non-dt platforms would not be able to use it in > this case. Hmm, that's true. > So I guess, we could get rid of this dt binding, implement the clkout handling > in the pinctrl driver for dt platforms, but use the platform-driver this > binding described for the time we're still handling non-dt s3c24xx machines. I guess you could make this a separate driver that would be instantiated by pinctrl driver registering another platform device in DT case and a static platform device registered by board files in non-DT case. Best regards, Tomasz
next prev parent reply other threads:[~2014-02-16 20:51 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-12-13 12:56 [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework Heiko Stübner 2013-12-13 12:56 ` Heiko Stübner 2013-12-13 12:57 ` [PATCH 01/12] ARM: S3C24XX: cpufreq-utils: don't write raw values to MPLLCON when using ccf Heiko Stübner 2013-12-13 12:57 ` Heiko Stübner 2014-02-08 20:23 ` Tomasz Figa 2014-02-08 20:23 ` Tomasz Figa 2013-12-13 12:59 ` [PATCH 02/12] dt-bindings: document s3c24xx controller for external clock output Heiko Stübner 2013-12-13 12:59 ` Heiko Stübner 2014-02-09 1:54 ` Tomasz Figa 2014-02-09 1:54 ` Tomasz Figa 2014-02-16 20:33 ` Heiko Stübner 2014-02-16 20:33 ` Heiko Stübner 2014-02-16 20:51 ` Tomasz Figa [this message] 2014-02-16 20:51 ` Tomasz Figa 2013-12-13 12:59 ` [PATCH 03/12] clk: samsung: add clock driver for external clock outputs Heiko Stübner 2013-12-13 12:59 ` Heiko Stübner 2013-12-31 19:46 ` Mike Turquette 2013-12-31 19:46 ` Mike Turquette 2014-02-09 2:25 ` Tomasz Figa 2014-02-09 2:25 ` Tomasz Figa 2013-12-13 13:00 ` [PATCH 04/12] ARM: S3C24XX: enable usage of common dclk if common clock framework is enabled Heiko Stübner 2013-12-13 13:00 ` Heiko Stübner 2013-12-13 13:00 ` [PATCH 05/12] ARM: S3C24XX: only store clock registers when old clock code is active Heiko Stübner 2013-12-13 13:00 ` Heiko Stübner 2013-12-13 13:00 ` [PATCH 06/12] clk: samsung: add plls used by the early s3c24xx cpus Heiko Stübner 2013-12-13 13:00 ` Heiko Stübner 2013-12-31 19:45 ` Mike Turquette 2013-12-31 19:45 ` Mike Turquette 2013-12-13 13:01 ` [PATCH 08/12] clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442 Heiko Stübner 2013-12-13 13:01 ` Heiko Stübner 2014-02-06 14:12 ` Mike Turquette 2014-02-06 14:12 ` Mike Turquette 2014-02-09 19:34 ` Tomasz Figa 2014-02-09 19:34 ` Tomasz Figa 2014-02-17 21:05 ` Heiko Stübner 2014-02-17 21:05 ` Heiko Stübner 2014-02-17 22:37 ` Tomasz Figa 2014-02-17 22:37 ` Tomasz Figa 2014-02-17 22:48 ` Heiko Stübner 2014-02-17 22:48 ` Heiko Stübner 2013-12-13 13:02 ` [PATCH 09/12] ARM: S3C24XX: add platform code for conversion to the common clock framework Heiko Stübner 2013-12-13 13:02 ` Heiko Stübner 2013-12-13 13:02 ` [PATCH 10/12] ARM: S3C24XX: convert s3c2440 and s3c2442 to " Heiko Stübner 2013-12-13 13:02 ` Heiko Stübner 2013-12-13 13:03 ` [PATCH 11/12] ARM: S3C24XX: convert s3c2410 " Heiko Stübner 2013-12-13 13:03 ` Heiko Stübner 2013-12-13 13:03 ` [PATCH 12/12] ARM: S3C24XX: remove legacy clock code Heiko Stübner 2013-12-13 13:03 ` Heiko Stübner 2014-02-09 19:56 ` [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework Tomasz Figa 2014-02-09 19:56 ` Tomasz Figa 2014-02-11 6:16 ` Kukjin Kim 2014-02-11 6:16 ` Kukjin Kim 2014-02-11 9:20 ` Heiko Stübner 2014-02-11 9:20 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=530124B8.9050209@gmail.com \ --to=tomasz.figa@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@linaro.org \ --cc=pawel.moll@arm.com \ --cc=rob.herring@calxeda.com \ --cc=swarren@wwwdotorg.org \ --cc=t.figa@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.