From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] xen-pciback: Use pci_enable_msix_range() instead of pci_enable_msix()
Date: Wed, 19 Feb 2014 10:22:49 -0500 [thread overview]
Message-ID: <5304CC49.7020000@oracle.com> (raw)
In-Reply-To: <1392804931-30671-10-git-send-email-agordeev@redhat.com>
On 02/19/2014 05:15 AM, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/xen/xen-pciback/pciback_ops.c | 16 ++++++++++------
> 1 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 64eb0cd..f5b4c3e 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -213,9 +213,15 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
> entries[i].vector = op->msix_entries[i].vector;
> }
>
> - result = pci_enable_msix(dev, entries, op->value);
> + result = pci_enable_msix_range(dev, entries, op->value, op->value);
> + if (result < op->value) {
I think it would be better to have 'if (result != op->value)', in case
op->value is negative (which presumably it should never be).
-boris
> + if (result > 0)
> + pci_disable_msix(dev);
>
> - if (result == 0) {
> + pr_warn_ratelimited("%s: error enabling MSI-X for guest %u: err %d!\n",
> + pci_name(dev), pdev->xdev->otherend_id,
> + result);
> + } else {
> for (i = 0; i < op->value; i++) {
> op->msix_entries[i].entry = entries[i].entry;
> if (entries[i].vector)
> @@ -227,10 +233,8 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
> pci_name(dev), i,
> op->msix_entries[i].vector);
> }
> - } else
> - pr_warn_ratelimited("%s: error enabling MSI-X for guest %u: err %d!\n",
> - pci_name(dev), pdev->xdev->otherend_id,
> - result);
> + }
> +
> kfree(entries);
>
> op->value = result;
next prev parent reply other threads:[~2014-02-19 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 10:15 [PATCH] xen-pciback: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-19 15:22 ` Boris Ostrovsky [this message]
2014-02-19 15:40 ` Boris Ostrovsky
2014-02-19 16:05 ` Alexander Gordeev
2014-02-19 16:24 ` Boris Ostrovsky
2014-02-21 16:52 ` Alexander Gordeev
2014-02-21 16:53 ` [PATCH v2] xen-pciback: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-21 17:02 ` Alexander Gordeev
2014-02-21 18:33 ` Boris Ostrovsky
2014-02-21 18:58 ` Alexander Gordeev
2014-02-21 19:09 ` Boris Ostrovsky
2014-02-21 21:15 ` Konrad Rzeszutek Wilk
2014-02-24 19:18 ` Konrad Rzeszutek Wilk
2014-02-25 8:32 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304CC49.7020000@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=agordeev@redhat.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.