Re: [PATCH v2] xen-pciback: Use pci_enable_msix_exact() instead of pci_enable_msix()

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] xen-pciback: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Fri, 21 Feb 2014 13:33:34 -0500	[thread overview]
Message-ID: <53079BFE.3010702@oracle.com> (raw)
In-Reply-To: <20140221165340.GG17353@dhcp-26-207.brq.redhat.com>

On 02/21/2014 11:53 AM, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range()  or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: linux-pci@vger.kernel.org

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

> ---
>   drivers/xen/xen-pciback/pciback_ops.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 64eb0cd..929dd46 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -213,8 +213,7 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
>   		entries[i].vector = op->msix_entries[i].vector;
>   	}
>   
> -	result = pci_enable_msix(dev, entries, op->value);
> -
> +	result = pci_enable_msix_exact(dev, entries, op->value);
>   	if (result == 0) {
>   		for (i = 0; i < op->value; i++) {
>   			op->msix_entries[i].entry = entries[i].entry;