Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync

From: Nishanth Menon <nm@ti.com>
To: Joachim Eastwood <manabian@gmail.com>
Cc: Joel Fernandes <joelf@ti.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <balbi@ti.com>
Subject: Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync
Date: Tue, 15 Apr 2014 12:18:08 -0500	[thread overview]
Message-ID: <534D69D0.207@ti.com> (raw)
In-Reply-To: <CAGhQ9Vxv682wD982sNDtc5-Zk4y7H2eULWcm8CJ2SiG=s7V=Pg@mail.gmail.com>

On 04/15/2014 12:06 PM, Joachim Eastwood wrote:
> On 15 April 2014 18:58, Nishanth Menon <nm@ti.com> wrote:
>> pm_runtime_get_sync may not always succeed depending on SoC involved.
>> So handle the error appropriately ensuring usage_count is accurate in
>> case of failure.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> V2:
>>         - review fixes, print function names in error log as well.
>>
>> V1: https://patchwork.kernel.org/patch/3993861/
>>  drivers/crypto/omap-des.c |   26 +++++++++++++++++++++++---
>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>
> 
> Fixes the runtime warning from omap_l3_noc when omap-des is built-in
> on my VAR-SOM-OM44 (OMAP4460) board.
> 
> Tested-by: Joachim Eastwood <manabian@gmail.com>

Thanks Joachim. Looks like in my hurry, I missed proper
acknowledgement of your report. adding the following for patchworks to
pickup.

Reported-by: Joachim Eastwood <manabian@gmail.com>

-- 
Regards,
Nishanth Menon