From: Tomasz Figa <t.figa@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>
Cc: kgene.kim@samsung.com, linux-kernel@vger.kernel.org,
linux@arm.linux.org.uk, ben-linux@fluff.org, arnd@arndb.de,
olof@lixom.net, marc.zyngier@arm.com, thomas.abraham@linaro.org,
kyungmin.park@samsung.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, hyunhee.kim@samsung.com,
yj44.cho@samsung.com, chanho61.park@samsung.com,
sajjan.linux@gmail.com, tushar.behera@linaro.org,
sachin.kamat@linaro.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Jaehoon Chung <jh80.chung@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250
Date: Fri, 09 May 2014 10:01:39 +0200 [thread overview]
Message-ID: <536C8B63.3000400@samsung.com> (raw)
In-Reply-To: <536C7F65.50503@samsung.com>
On 09.05.2014 09:10, Chanwoo Choi wrote:
> Hi Tomasz,
>
> On 05/09/2014 02:02 PM, Tomasz Figa wrote:
>> Hi Chanwoo,
>>
>> On 09.05.2014 03:06, Chanwoo Choi wrote:
>>> On 04/26/2014 09:51 AM, Tomasz Figa wrote:
>>>> On 25.04.2014 03:16, Chanwoo Choi wrote:
>>
>> [snip]
>>
>>>>> + cpus {
>>>>> + #address-cells = <1>;
>>>>> + #size-cells = <0>;
>>>>> +
>>>>> + cpu@0 {
>>>>> + device_type = "cpu";
>>>>> + compatible = "arm,cortex-a7";
>>>>> + reg = <0>;
>>>>> + clock-frequency = <1000000000>;
>>>>> + };
>>>>
>>>> Why only one CPU? I believe Exynos3250 is dual core.
>>>
>>> I'll add cpu1 information.
>>>
>>>> Also are physical IDs of the cores really 0 and 1? On Exynos4210 for example they are 0x900 and 0x901, while on Exynos4212 they are 0xa00 and 0xa01. Please check this.
>>>
>>> The 'reg' property means only hardware id(hwid) of CPU.
>>> You can check it on arm_dt_init_cpu_maps() in arch/arm/kernel/devtree.c.h.
>>> or Documentation/devicetree/bindings/arm/cpus.txt.
>>>
>>
>> Well, as described in Documentation/devicetree/bindings/arm/cpus.txt, on 32-bit ARM v7 or later CPUs the "reg" property should be equal to the lower 24-bits of MPIDR value of given CPU, which in addition to core ID includes also cluster ID, which can be non-zero, even on single cluster SoCs (like it is on Exynos4210 and 4x12).
>
> I checked the lower 24-bit of MPIDR value for Exynos3250 in arm_dt_init_cpu_maps().
> - the lower 24-bit of MPIDR for CPU0 is '0x0'.
Fair enough. Thanks.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
marc.zyngier-5wv7dgnIgG8@public.gmane.org,
thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
hyunhee.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
yj44.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
chanho61.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
sajjan.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jaehoon Chung
<jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250
Date: Fri, 09 May 2014 10:01:39 +0200 [thread overview]
Message-ID: <536C8B63.3000400@samsung.com> (raw)
In-Reply-To: <536C7F65.50503-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On 09.05.2014 09:10, Chanwoo Choi wrote:
> Hi Tomasz,
>
> On 05/09/2014 02:02 PM, Tomasz Figa wrote:
>> Hi Chanwoo,
>>
>> On 09.05.2014 03:06, Chanwoo Choi wrote:
>>> On 04/26/2014 09:51 AM, Tomasz Figa wrote:
>>>> On 25.04.2014 03:16, Chanwoo Choi wrote:
>>
>> [snip]
>>
>>>>> + cpus {
>>>>> + #address-cells = <1>;
>>>>> + #size-cells = <0>;
>>>>> +
>>>>> + cpu@0 {
>>>>> + device_type = "cpu";
>>>>> + compatible = "arm,cortex-a7";
>>>>> + reg = <0>;
>>>>> + clock-frequency = <1000000000>;
>>>>> + };
>>>>
>>>> Why only one CPU? I believe Exynos3250 is dual core.
>>>
>>> I'll add cpu1 information.
>>>
>>>> Also are physical IDs of the cores really 0 and 1? On Exynos4210 for example they are 0x900 and 0x901, while on Exynos4212 they are 0xa00 and 0xa01. Please check this.
>>>
>>> The 'reg' property means only hardware id(hwid) of CPU.
>>> You can check it on arm_dt_init_cpu_maps() in arch/arm/kernel/devtree.c.h.
>>> or Documentation/devicetree/bindings/arm/cpus.txt.
>>>
>>
>> Well, as described in Documentation/devicetree/bindings/arm/cpus.txt, on 32-bit ARM v7 or later CPUs the "reg" property should be equal to the lower 24-bits of MPIDR value of given CPU, which in addition to core ID includes also cluster ID, which can be non-zero, even on single cluster SoCs (like it is on Exynos4210 and 4x12).
>
> I checked the lower 24-bit of MPIDR value for Exynos3250 in arm_dt_init_cpu_maps().
> - the lower 24-bit of MPIDR for CPU0 is '0x0'.
Fair enough. Thanks.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250
Date: Fri, 09 May 2014 10:01:39 +0200 [thread overview]
Message-ID: <536C8B63.3000400@samsung.com> (raw)
In-Reply-To: <536C7F65.50503@samsung.com>
On 09.05.2014 09:10, Chanwoo Choi wrote:
> Hi Tomasz,
>
> On 05/09/2014 02:02 PM, Tomasz Figa wrote:
>> Hi Chanwoo,
>>
>> On 09.05.2014 03:06, Chanwoo Choi wrote:
>>> On 04/26/2014 09:51 AM, Tomasz Figa wrote:
>>>> On 25.04.2014 03:16, Chanwoo Choi wrote:
>>
>> [snip]
>>
>>>>> + cpus {
>>>>> + #address-cells = <1>;
>>>>> + #size-cells = <0>;
>>>>> +
>>>>> + cpu at 0 {
>>>>> + device_type = "cpu";
>>>>> + compatible = "arm,cortex-a7";
>>>>> + reg = <0>;
>>>>> + clock-frequency = <1000000000>;
>>>>> + };
>>>>
>>>> Why only one CPU? I believe Exynos3250 is dual core.
>>>
>>> I'll add cpu1 information.
>>>
>>>> Also are physical IDs of the cores really 0 and 1? On Exynos4210 for example they are 0x900 and 0x901, while on Exynos4212 they are 0xa00 and 0xa01. Please check this.
>>>
>>> The 'reg' property means only hardware id(hwid) of CPU.
>>> You can check it on arm_dt_init_cpu_maps() in arch/arm/kernel/devtree.c.h.
>>> or Documentation/devicetree/bindings/arm/cpus.txt.
>>>
>>
>> Well, as described in Documentation/devicetree/bindings/arm/cpus.txt, on 32-bit ARM v7 or later CPUs the "reg" property should be equal to the lower 24-bits of MPIDR value of given CPU, which in addition to core ID includes also cluster ID, which can be non-zero, even on single cluster SoCs (like it is on Exynos4210 and 4x12).
>
> I checked the lower 24-bit of MPIDR value for Exynos3250 in arm_dt_init_cpu_maps().
> - the lower 24-bit of MPIDR for CPU0 is '0x0'.
Fair enough. Thanks.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-09 8:01 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 1:16 [PATCHv4 0/7] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 1/7] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-26 0:40 ` Tomasz Figa
2014-04-26 0:40 ` Tomasz Figa
2014-04-25 1:16 ` [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-26 0:42 ` Tomasz Figa
2014-04-26 0:42 ` Tomasz Figa
2014-04-26 10:49 ` Kukjin Kim
2014-04-26 10:49 ` Kukjin Kim
2014-04-26 10:49 ` Kukjin Kim
2014-04-25 1:16 ` [PATCHv4 3/7] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 4:30 ` Tushar Behera
2014-04-25 4:30 ` Tushar Behera
2014-04-25 5:43 ` Chanwoo Choi
2014-04-25 5:43 ` Chanwoo Choi
2014-04-25 5:54 ` Tushar Behera
2014-04-25 5:54 ` Tushar Behera
2014-04-25 5:56 ` Chanwoo Choi
2014-04-25 5:56 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-26 0:25 ` Tomasz Figa
2014-04-26 0:25 ` Tomasz Figa
2014-04-26 0:25 ` Tomasz Figa
2014-04-26 0:30 ` Russell King - ARM Linux
2014-04-26 0:30 ` Russell King - ARM Linux
2014-04-30 8:00 ` Chanwoo Choi
2014-04-30 8:00 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 5/7] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-26 0:39 ` Tomasz Figa
2014-04-26 0:39 ` Tomasz Figa
2014-04-26 0:39 ` Tomasz Figa
2014-05-13 11:49 ` Chanwoo Choi
2014-05-13 11:49 ` Chanwoo Choi
2014-05-13 16:28 ` Tomasz Figa
2014-05-13 16:28 ` Tomasz Figa
2014-05-13 16:28 ` Tomasz Figa
2014-05-14 6:57 ` Chanwoo Choi
2014-05-14 6:57 ` Chanwoo Choi
2014-05-14 6:57 ` Chanwoo Choi
2014-05-14 13:45 ` Tomasz Figa
2014-05-14 13:45 ` Tomasz Figa
2014-05-14 13:45 ` Tomasz Figa
2014-04-25 1:16 ` [PATCHv4 6/7] dt-bindings: add documentation for Exynos3250 clock controller Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-25 1:16 ` Chanwoo Choi
2014-04-25 4:38 ` Tushar Behera
2014-04-25 4:38 ` Tushar Behera
2014-04-25 5:03 ` Chanwoo Choi
2014-04-25 5:03 ` Chanwoo Choi
2014-04-26 0:51 ` Tomasz Figa
2014-04-26 0:51 ` Tomasz Figa
2014-04-26 11:38 ` Tomasz Figa
2014-04-26 11:38 ` Tomasz Figa
2014-04-26 11:38 ` Tomasz Figa
2014-05-09 6:49 ` Chanwoo Choi
2014-05-09 6:49 ` Chanwoo Choi
2014-05-09 8:01 ` Tomasz Figa
2014-05-09 8:01 ` Tomasz Figa
2014-05-09 8:15 ` Chanwoo Choi
2014-05-09 8:15 ` Chanwoo Choi
2014-05-09 1:06 ` Chanwoo Choi
2014-05-09 1:06 ` Chanwoo Choi
2014-05-09 5:02 ` Tomasz Figa
2014-05-09 5:02 ` Tomasz Figa
2014-05-09 7:10 ` Chanwoo Choi
2014-05-09 7:10 ` Chanwoo Choi
2014-05-09 8:01 ` Tomasz Figa [this message]
2014-05-09 8:01 ` Tomasz Figa
2014-05-09 8:01 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C8B63.3000400@samsung.com \
--to=t.figa@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hyunhee.kim@samsung.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sajjan.linux@gmail.com \
--cc=sw0312.kim@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tushar.behera@linaro.org \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.