Re: [PATCH -next 25/26] fbdev: Use dma_zalloc_coherent

From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Joe Perches <joe@perches.com>, <linux-kernel@vger.kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH -next 25/26] fbdev: Use dma_zalloc_coherent
Date: Mon, 23 Jun 2014 14:53:45 +0300	[thread overview]
Message-ID: <53A81549.40206@ti.com> (raw)
In-Reply-To: <881b8f8d85c96b6e9d8735aa10bbf18468688b9d.1402863905.git.joe@perches.com>

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

On 15/06/14 23:37, Joe Perches wrote:
> Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/video/fbdev/da8xx-fb.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
> index a8484f7..788f6b3 100644
> --- a/drivers/video/fbdev/da8xx-fb.c
> +++ b/drivers/video/fbdev/da8xx-fb.c
> @@ -1447,18 +1447,15 @@ static int fb_probe(struct platform_device *device)
>  		da8xx_fb_fix.line_length - 1;
>  
>  	/* allocate palette buffer */
> -	par->v_palette_base = dma_alloc_coherent(NULL,
> -					       PALETTE_SIZE,
> -					       (resource_size_t *)
> -					       &par->p_palette_base,
> -					       GFP_KERNEL | GFP_DMA);
> +	par->v_palette_base = dma_zalloc_coherent(NULL, PALETTE_SIZE,
> +						  (resource_size_t *)&par->p_palette_base,
> +						  GFP_KERNEL | GFP_DMA);
>  	if (!par->v_palette_base) {
>  		dev_err(&device->dev,
>  			"GLCD: kmalloc for palette buffer failed\n");
>  		ret = -EINVAL;
>  		goto err_release_fb_mem;
>  	}
> -	memset(par->v_palette_base, 0, PALETTE_SIZE);
>  
>  	par->irq = platform_get_irq(device, 0);
>  	if (par->irq < 0) {
> 

Thanks, queued for 3.17.

 Tomi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]