From: Archit Taneja <archit@ti.com> To: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org Cc: Jyri Sarha <jsarha@ti.com>, Rob Clark <robdclark@gmail.com> Subject: Re: [PATCH 15/15] drm/omap: Add infoframe & dvi/hdmi mode support Date: Wed, 25 Jun 2014 11:15:49 +0000 [thread overview] Message-ID: <53AAAC95.3070409@ti.com> (raw) In-Reply-To: <1403604240-16738-16-git-send-email-tomi.valkeinen@ti.com> Hi, On Tuesday 24 June 2014 03:34 PM, Tomi Valkeinen wrote: > Make the omapdrm driver use the new HDMI ops when possible. > > omapdrm will call set_hdmi_mode (when available) to tell the encoder > driver whether the monitor is a DVI or HDMI monitor, and if it's an HDMI > monitor, omapdrm will call set_hdmi_infoframe to to set the AVI > infoframe. <snip> > @@ -89,6 +91,31 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder, > struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode) > { > + struct drm_device *dev = encoder->dev; > + struct omap_encoder *omap_encoder = to_omap_encoder(encoder); > + struct omap_dss_device *dssdev = omap_encoder->dssdev; > + struct drm_connector *connector; > + bool hdmi_mode; > + int r; > + > + hdmi_mode = false; > + list_for_each_entry(connector, &dev->mode_config.connector_list, head) { > + if (connector->encoder = encoder) { > + hdmi_mode = omap_connector_get_hdmi_mode(connector); > + break; > + } > + } > + > + if (dssdev->driver->set_hdmi_mode) > + dssdev->driver->set_hdmi_mode(dssdev, hdmi_mode); When a HDMI monitor is replaced with a DVI one, we call the set_hdmi_mode() driver op to set the mode to DVI. But we don't call set_hdmi_infoframe() when the mode is set back to DVI. Do we need to set avi infoframe registers back to a default value, or are those registers just ignored in DVI mode? > + > + if (hdmi_mode && dssdev->driver->set_hdmi_infoframe) { > + struct hdmi_avi_infoframe avi; > + > + r = drm_hdmi_avi_infoframe_from_display_mode(&avi, adjusted_mode); > + if (r = 0) > + dssdev->driver->set_hdmi_infoframe(dssdev, &avi); > + } > } > Archit
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <archit@ti.com> To: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org Cc: Jyri Sarha <jsarha@ti.com>, Rob Clark <robdclark@gmail.com> Subject: Re: [PATCH 15/15] drm/omap: Add infoframe & dvi/hdmi mode support Date: Wed, 25 Jun 2014 16:33:49 +0530 [thread overview] Message-ID: <53AAAC95.3070409@ti.com> (raw) In-Reply-To: <1403604240-16738-16-git-send-email-tomi.valkeinen@ti.com> Hi, On Tuesday 24 June 2014 03:34 PM, Tomi Valkeinen wrote: > Make the omapdrm driver use the new HDMI ops when possible. > > omapdrm will call set_hdmi_mode (when available) to tell the encoder > driver whether the monitor is a DVI or HDMI monitor, and if it's an HDMI > monitor, omapdrm will call set_hdmi_infoframe to to set the AVI > infoframe. <snip> > @@ -89,6 +91,31 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder, > struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode) > { > + struct drm_device *dev = encoder->dev; > + struct omap_encoder *omap_encoder = to_omap_encoder(encoder); > + struct omap_dss_device *dssdev = omap_encoder->dssdev; > + struct drm_connector *connector; > + bool hdmi_mode; > + int r; > + > + hdmi_mode = false; > + list_for_each_entry(connector, &dev->mode_config.connector_list, head) { > + if (connector->encoder == encoder) { > + hdmi_mode = omap_connector_get_hdmi_mode(connector); > + break; > + } > + } > + > + if (dssdev->driver->set_hdmi_mode) > + dssdev->driver->set_hdmi_mode(dssdev, hdmi_mode); When a HDMI monitor is replaced with a DVI one, we call the set_hdmi_mode() driver op to set the mode to DVI. But we don't call set_hdmi_infoframe() when the mode is set back to DVI. Do we need to set avi infoframe registers back to a default value, or are those registers just ignored in DVI mode? > + > + if (hdmi_mode && dssdev->driver->set_hdmi_infoframe) { > + struct hdmi_avi_infoframe avi; > + > + r = drm_hdmi_avi_infoframe_from_display_mode(&avi, adjusted_mode); > + if (r == 0) > + dssdev->driver->set_hdmi_infoframe(dssdev, &avi); > + } > } > Archit
next prev parent reply other threads:[~2014-06-25 11:15 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-24 10:03 [PATCH 00/15] OMAPDSS: HDMI infoframe & cleanup Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 01/15] OMAPDSS: DISPC: fix debugfs reg dump Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 02/15] OMAPDSS: DISPC: reject interlace for lcd out Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 03/15] OMAPDSS: DISPC: clean up dispc_mgr_timings_ok Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 04/15] OMAPDSS: HDMI: fix name conflict Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 05/15] OMAPDSS: Kconfig: select HDMI Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 06/15] OMAPDSS: HDMI4: use common AVI infoframe support Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 07/15] OMAPDSS: HDMI5: " Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 08/15] OMAPDSS: HDMI: remove custom avi infoframe Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 09/15] OMAPDSS: add hdmi ops to hdmi_ops and omap_dss_driver Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 10/15] OMAPDSS: add hdmi ops to hdmi-connector and tpd12s015 Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 11/15] OMAPDSS: HDMI: add infoframe and hdmi_dvi_mode fields Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 12/15] OMAPDSS: HDMI4: add support to set infoframe & HDMI mode Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 13/15] OMAPDSS: HDMI5: " Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-24 10:03 ` [PATCH 14/15] OMAPDSS: HDMI: remove the unused code Tomi Valkeinen 2014-06-24 10:03 ` Tomi Valkeinen 2014-06-26 19:05 ` Jyri Sarha 2014-06-26 19:05 ` Jyri Sarha 2014-06-27 10:16 ` Tomi Valkeinen 2014-06-27 10:16 ` Tomi Valkeinen 2014-06-27 10:20 ` Tomi Valkeinen 2014-06-27 10:20 ` Tomi Valkeinen 2014-06-24 10:04 ` [PATCH 15/15] drm/omap: Add infoframe & dvi/hdmi mode support Tomi Valkeinen 2014-06-24 10:04 ` Tomi Valkeinen 2014-06-25 11:03 ` Archit Taneja [this message] 2014-06-25 11:15 ` Archit Taneja 2014-06-25 11:29 ` Tomi Valkeinen 2014-06-25 11:29 ` Tomi Valkeinen 2014-07-03 5:55 ` Tomi Valkeinen 2014-07-03 5:55 ` Tomi Valkeinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53AAAC95.3070409@ti.com \ --to=archit@ti.com \ --cc=jsarha@ti.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.