From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mikko Perttunen
<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
mlongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree
Date: Mon, 30 Jun 2014 14:48:32 -0600 [thread overview]
Message-ID: <53B1CD20.3010008@wwwdotorg.org> (raw)
In-Reply-To: <1403856699-2140-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 06/27/2014 02:11 AM, Mikko Perttunen wrote:
> This adds the soctherm thermal sensing and management unit to the
> Tegra124 device tree along with the four thermal zones it exports.
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> + thermal-zones {
> + cpu {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
I think we should still define a polling delay so that if there's SW
that doesn't support HW trip points/interrupts, it still knows how often
it should reasonably check the sensor.
Perhaps a delay of 0 is used to determine whether to use HW trip points
vs polling (I haven't read patch 1 yet)? If so, I'd prefer not to do
that. Rather, the driver should advertize its ability to provide HW trip
points, and it would be up to the core to then make use of them. The DT
should just describe the HW, not assume it can influence SW's choice of
whether to use HW trip points.
> + soctherm: soctherm@0,700e2000 {
...
> + reset-names = "soctherm";
> +
> + #thermal-sensor-cells = <1>;
I don't see any real need for that blank line. If there was, there would
probably be more blank lines in the big list of properties above.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mikko Perttunen <mperttunen@nvidia.com>,
rui.zhang@intel.com, edubezval@gmail.com,
thierry.reding@gmail.com, pdeschrijver@nvidia.com,
mlongnecker@nvidia.com
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree
Date: Mon, 30 Jun 2014 14:48:32 -0600 [thread overview]
Message-ID: <53B1CD20.3010008@wwwdotorg.org> (raw)
In-Reply-To: <1403856699-2140-5-git-send-email-mperttunen@nvidia.com>
On 06/27/2014 02:11 AM, Mikko Perttunen wrote:
> This adds the soctherm thermal sensing and management unit to the
> Tegra124 device tree along with the four thermal zones it exports.
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> + thermal-zones {
> + cpu {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
I think we should still define a polling delay so that if there's SW
that doesn't support HW trip points/interrupts, it still knows how often
it should reasonably check the sensor.
Perhaps a delay of 0 is used to determine whether to use HW trip points
vs polling (I haven't read patch 1 yet)? If so, I'd prefer not to do
that. Rather, the driver should advertize its ability to provide HW trip
points, and it would be up to the core to then make use of them. The DT
should just describe the HW, not assume it can influence SW's choice of
whether to use HW trip points.
> + soctherm: soctherm@0,700e2000 {
...
> + reset-names = "soctherm";
> +
> + #thermal-sensor-cells = <1>;
I don't see any real need for that blank line. If there was, there would
probably be more blank lines in the big list of properties above.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree
Date: Mon, 30 Jun 2014 14:48:32 -0600 [thread overview]
Message-ID: <53B1CD20.3010008@wwwdotorg.org> (raw)
In-Reply-To: <1403856699-2140-5-git-send-email-mperttunen@nvidia.com>
On 06/27/2014 02:11 AM, Mikko Perttunen wrote:
> This adds the soctherm thermal sensing and management unit to the
> Tegra124 device tree along with the four thermal zones it exports.
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> + thermal-zones {
> + cpu {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
I think we should still define a polling delay so that if there's SW
that doesn't support HW trip points/interrupts, it still knows how often
it should reasonably check the sensor.
Perhaps a delay of 0 is used to determine whether to use HW trip points
vs polling (I haven't read patch 1 yet)? If so, I'd prefer not to do
that. Rather, the driver should advertize its ability to provide HW trip
points, and it would be up to the core to then make use of them. The DT
should just describe the HW, not assume it can influence SW's choice of
whether to use HW trip points.
> + soctherm: soctherm at 0,700e2000 {
...
> + reset-names = "soctherm";
> +
> + #thermal-sensor-cells = <1>;
I don't see any real need for that blank line. If there was, there would
probably be more blank lines in the big list of properties above.
next prev parent reply other threads:[~2014-06-30 20:48 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 8:11 [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` [PATCH 1/6] thermal: of: Add support for hardware-tracked trip points Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-30 21:08 ` Stephen Warren
2014-06-30 21:08 ` Stephen Warren
2014-07-01 7:27 ` Mikko Perttunen
2014-07-01 7:27 ` Mikko Perttunen
2014-07-01 7:27 ` Mikko Perttunen
2014-07-01 18:15 ` Stephen Warren
2014-07-01 18:15 ` Stephen Warren
2014-07-01 18:15 ` Stephen Warren
2014-07-03 14:15 ` Mikko Perttunen
2014-07-03 14:15 ` Mikko Perttunen
2014-07-03 14:15 ` Mikko Perttunen
2014-07-21 23:53 ` Matthew Longnecker
2014-07-30 14:16 ` Eduardo Valentin
2014-07-30 14:16 ` Eduardo Valentin
2014-08-01 11:42 ` Mikko Perttunen
2014-08-01 11:42 ` Mikko Perttunen
2014-08-01 11:42 ` Mikko Perttunen
[not found] ` <53DB7D0D.1070508-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-01 13:15 ` edubezval-Re5JQEeQqe8AvxtiuMwx3w
2014-08-01 13:15 ` edubezval at gmail.com
2014-08-01 13:15 ` edubezval
2014-06-27 8:11 ` [PATCH 2/6] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
[not found] ` <1403856699-2140-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-30 20:40 ` Stephen Warren
2014-06-30 20:40 ` Stephen Warren
2014-06-30 20:40 ` Stephen Warren
2014-06-27 8:11 ` [PATCH 3/6] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-30 20:45 ` Stephen Warren
2014-06-30 20:45 ` Stephen Warren
2014-06-27 8:11 ` [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
[not found] ` <1403856699-2140-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-30 20:48 ` Stephen Warren [this message]
2014-06-30 20:48 ` Stephen Warren
2014-06-30 20:48 ` Stephen Warren
2014-07-01 7:49 ` Mikko Perttunen
2014-07-01 7:49 ` Mikko Perttunen
2014-07-01 7:49 ` Mikko Perttunen
2014-07-21 23:12 ` Matthew Longnecker
2014-07-21 23:13 ` Matthew Longnecker
2014-07-21 23:13 ` Matthew Longnecker
2014-07-21 23:13 ` Matthew Longnecker
[not found] ` <1403856699-2140-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-27 8:11 ` [PATCH 5/6] clk: tegra: Add soctherm and tsensor clocks to Tegra124 init table Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 12:18 ` Peter De Schrijver
2014-06-27 12:18 ` Peter De Schrijver
2014-06-27 12:18 ` Peter De Schrijver
2014-06-27 8:11 ` [PATCH 6/6] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-27 8:11 ` Mikko Perttunen
2014-06-30 21:23 ` Stephen Warren
2014-06-30 21:23 ` Stephen Warren
2014-07-01 8:06 ` Mikko Perttunen
2014-07-01 8:06 ` Mikko Perttunen
2014-07-01 8:06 ` Mikko Perttunen
[not found] ` <53B26BF2.7090009-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-01 18:26 ` Stephen Warren
2014-07-01 18:26 ` Stephen Warren
2014-07-01 18:26 ` Stephen Warren
2014-07-03 13:51 ` Mikko Perttunen
2014-07-03 13:51 ` Mikko Perttunen
2014-07-03 13:51 ` Mikko Perttunen
[not found] ` <1403856699-2140-7-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-01 23:47 ` Tuomas Tynkkynen
2014-07-04 8:43 ` Wei Ni
2014-07-04 8:43 ` Wei Ni
2014-07-04 8:43 ` Wei Ni
2014-07-04 11:52 ` Mikko Perttunen
2014-07-04 11:52 ` Mikko Perttunen
2014-07-04 11:52 ` Mikko Perttunen
2014-07-21 7:42 ` [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Zhang Rui
2014-07-21 7:42 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B1CD20.3010008@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mlongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.