From: Jyri Sarha <jsarha@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
broonie@kernel.org, liam.r.girdwood@linux.intel.com,
detheridge@ti.com, jyri.sarha@iki.fi
Subject: Re: [PATCH v2 04/13] OMAPDSS: hdmi: Make hdmi structure public
Date: Thu, 07 Aug 2014 09:29:47 +0000 [thread overview]
Message-ID: <53E3470B.4090902@ti.com> (raw)
In-Reply-To: <53E324FB.7060000@ti.com>
On 08/07/2014 10:04 AM, Tomi Valkeinen wrote:
> On 27/06/14 21:38, Jyri Sarha wrote:
>> Name the anonymous hdmi struct as omap_hdmi. Move the struct definition to
>> hdmi.h and turn core member into a pointer to deal with it's different
>> definitions for omap4 and omap5. Make associated changes to hdmi4.c
>> and hdmi5.c.
>
> I didn't understand this one. Why did you make struct hdmi_core_data a
> pointer?
>
That is because there is no point to it :)... my mistake made in a
hurry. I'll fix that.
Cheers,
Jyri
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
broonie@kernel.org, liam.r.girdwood@linux.intel.com,
detheridge@ti.com, jyri.sarha@iki.fi
Subject: Re: [PATCH v2 04/13] OMAPDSS: hdmi: Make hdmi structure public
Date: Thu, 7 Aug 2014 12:29:47 +0300 [thread overview]
Message-ID: <53E3470B.4090902@ti.com> (raw)
In-Reply-To: <53E324FB.7060000@ti.com>
On 08/07/2014 10:04 AM, Tomi Valkeinen wrote:
> On 27/06/14 21:38, Jyri Sarha wrote:
>> Name the anonymous hdmi struct as omap_hdmi. Move the struct definition to
>> hdmi.h and turn core member into a pointer to deal with it's different
>> definitions for omap4 and omap5. Make associated changes to hdmi4.c
>> and hdmi5.c.
>
> I didn't understand this one. Why did you make struct hdmi_core_data a
> pointer?
>
That is because there is no point to it :)... my mistake made in a
hurry. I'll fix that.
Cheers,
Jyri
next prev parent reply other threads:[~2014-08-07 9:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 18:38 [PATCH v2 00/13] Rework OMAP4+ HDMI audio support Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 01/13] ARM: OMAP2+: Remove non working OMAP HDMI audio initialization Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-30 7:24 ` Tony Lindgren
2014-06-30 7:24 ` Tony Lindgren
2014-06-27 18:38 ` [PATCH v2 02/13] OMAPDSS: hdmi.h: Add HDMI_AUDIO_LAYOUT_6CH enum value Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 03/13] OMAPDSS: hdmi_wp: Add function for getting audio dma address Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 04/13] OMAPDSS: hdmi: Make hdmi structure public Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-08-07 7:04 ` Tomi Valkeinen
2014-08-07 7:04 ` Tomi Valkeinen
2014-08-07 9:29 ` Jyri Sarha [this message]
2014-08-07 9:29 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 05/13] OMAPDSS: hdmi_audio: Integrated ASoC DAI component driver implementation Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 06/13] OMAPDSS: Kconfig: Update OMAP4_DSS_HDMI_AUDIO option Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 07/13] OMAPDSS: hdmi4: Register HDMI audio ASoC drivers from HDMI driver Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 08/13] OMAPDSS: Kconfig: Update OMAP5_DSS_HDMI_AUDIO option Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 09/13] OMAPDSS: hdmi5: Register HDMI audio ASoC drivers from HDMI driver Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 10/13] ASoC: omap: Remove obsolete HDMI audio code and Kconfig options Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 11/13] OMAPDSS: hdmi4: Remove callbacks for an external ASoC DAI driver Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 12/13] OMAPDSS: hdmi5: " Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
2014-06-27 18:38 ` [PATCH v2 13/13] OMAPDSS: Remove all references to obsolete HDMI audio callbacks Jyri Sarha
2014-06-27 18:38 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E3470B.4090902@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=detheridge@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.