From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>, Inki Dae <inki.dae@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
dri-devel@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/S5P EXYNOS AR..."
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH 03/15] drm/exynos/ipp: move file reference from memory to command node
Date: Tue, 26 Aug 2014 11:59:36 +0900 [thread overview]
Message-ID: <53FBF818.70407@samsung.com> (raw)
In-Reply-To: <53FBF71B.7070107@samsung.com>
On 08/26/2014 11:55 AM, Joonyoung Shim wrote:
> Hi Andrzej,
>
> On 08/22/2014 04:52 PM, Andrzej Hajda wrote:
>> Command node should contain file reference to distinguish commands
>> created by different processes.
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 ++---
>> drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2 ++
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
>> index 9770966..bbe9968 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
>> @@ -75,7 +75,6 @@ struct drm_exynos_ipp_mem_node {
>> u32 prop_id;
>> u32 buf_id;
>> struct drm_exynos_ipp_buf_info buf_info;
>> - struct drm_file *filp;
>> };
>>
>> /*
>> @@ -448,6 +447,7 @@ int exynos_drm_ipp_set_property(struct drm_device *drm_dev, void *data,
>> c_node->dev = dev;
>> c_node->property = *property;
>> c_node->state = IPP_STATE_IDLE;
>> + c_node->filp = file;
>>
>> c_node->start_work = ipp_create_cmd_work();
>> if (IS_ERR(c_node->start_work)) {
>> @@ -645,7 +645,6 @@ static struct drm_exynos_ipp_mem_node
>> }
>> }
>>
>> - m_node->filp = file;
>> mutex_lock(&c_node->mem_lock);
>> list_add_tail(&m_node->list, &c_node->mem_list[qbuf->ops_id]);
>> mutex_unlock(&c_node->mem_lock);
>> @@ -677,7 +676,7 @@ static int ipp_put_mem_node(struct drm_device *drm_dev,
>
> Then, could you remove file argument from exynos_drm_ipp_queue_buf() and
> ipp_get_event()?
sorry, i mean ipp_put_mem_node() instead of exynos_drm_ipp_queue_buf().
>
>> unsigned long handle = m_node->buf_info.handles[i];
>> if (handle)
>> exynos_drm_gem_put_dma_addr(drm_dev, handle,
>> - m_node->filp);
>> + c_node->filp);
>> }
>>
>> /* delete list in queue */
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.h b/drivers/gpu/drm/exynos/exynos_drm_ipp.h
>> index 6f48d62..0311035 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.h
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.h
>> @@ -62,6 +62,7 @@ struct drm_exynos_ipp_cmd_work {
>> * @stop_work: stop command work structure.
>> * @event_work: event work structure.
>> * @state: state of command node.
>> + * @filp: associated file pointer.
>> */
>> struct drm_exynos_ipp_cmd_node {
>> struct device *dev;
>> @@ -78,6 +79,7 @@ struct drm_exynos_ipp_cmd_node {
>> struct drm_exynos_ipp_cmd_work *stop_work;
>> struct drm_exynos_ipp_event_work *event_work;
>> enum drm_exynos_ipp_state state;
>> + struct drm_file *filp;
>> };
>>
>> /*
>>
>
>
next prev parent reply other threads:[~2014-08-26 2:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 7:52 [PATCH 00/15] drm/exynos/ipp: image post processing fixes and improvements, part four Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 01/15] drm/exynos/ipp: remove fake pm callbacks Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 02/15] drm/exynos/ipp: cancel works before command node clean Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 03/15] drm/exynos/ipp: move file reference from memory to command node Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-26 2:55 ` Joonyoung Shim
2014-08-26 2:55 ` Joonyoung Shim
2014-08-26 2:59 ` Joonyoung Shim [this message]
2014-08-26 2:59 ` Joonyoung Shim
2014-08-26 6:16 ` Andrzej Hajda
2014-08-26 6:16 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 04/15] drm/exynos/ipp: remove only related commands on file close Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 05/15] drm/exynos/ipp: remove unused field in command node Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 06/15] drm/exynos/ipp: free partially allocated resources on error Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-26 5:00 ` Joonyoung Shim
2014-08-26 5:00 ` Joonyoung Shim
2014-08-27 10:27 ` Andrzej Hajda
2014-08-27 10:27 ` Andrzej Hajda
2014-08-27 23:59 ` Joonyoung Shim
2014-08-27 23:59 ` Joonyoung Shim
2014-08-22 7:52 ` [PATCH 07/15] drm/exynos/ipp: move nodes cleaning to separate function Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 08/15] drm/exynos/ipp: clean memory nodes on command node cleaning Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 09/15] drm/exynos/ipp: replace work_struct casting with better constructs Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 10/15] drm/exynos/ipp: stop hardware before freeing memory Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 11/15] drm/exynos/ipp: remove events during command cleaning Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 12/15] drm/exynos/fimc: avoid clearing overflow bits Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 13/15] drm/exynos/fimc: do not enable fimc twice Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 14/15] drm/exynos/fimc: simplify buffer queuing Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-26 5:53 ` Joonyoung Shim
2014-08-26 5:53 ` Joonyoung Shim
2014-08-26 6:20 ` Andrzej Hajda
2014-08-26 6:20 ` Andrzej Hajda
2014-08-27 11:07 ` [PATCH v2 " Andrzej Hajda
2014-08-27 11:07 ` Andrzej Hajda
2014-08-22 7:52 ` [PATCH 15/15] drm/exynos/fimc: fix source buffer registers Andrzej Hajda
2014-08-22 7:52 ` Andrzej Hajda
2014-08-26 5:57 ` Joonyoung Shim
2014-08-26 5:57 ` Joonyoung Shim
2014-08-26 6:35 ` Andrzej Hajda
2014-08-26 6:35 ` Andrzej Hajda
2014-08-26 6:47 ` Joonyoung Shim
2014-08-26 6:47 ` Joonyoung Shim
2014-08-26 6:52 ` [PATCH 00/15] drm/exynos/ipp: image post processing fixes and improvements, part four Joonyoung Shim
2014-08-26 6:52 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FBF818.70407@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.