From: Shuah Khan <shuah@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>, corbet@lwn.net
Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] doc: dev-tools: kselftest.rst: update contributing new tests
Date: Fri, 29 Jun 2018 06:09:45 -0600 [thread overview]
Message-ID: <53d599f2-44a1-c366-4a5c-2ca6cd19b031@kernel.org> (raw)
In-Reply-To: <20180629100248.11560-1-anders.roxell@linaro.org>
On 06/29/2018 04:02 AM, Anders Roxell wrote:
> Add a description that kernel config options should be added into a
> config file that is placed next to the newly added test.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> Documentation/dev-tools/kselftest.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index 3bf371a938d0..4c546a35bd58 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -156,6 +156,9 @@ Contributing new tests (details)
> installed by the distro on the system should be the primary focus to be able
> to find regressions.
>
> + * If a new test needs specific kernel options, they should be enabled in
get rid of new
> + then config file in the same directory where the test is added.
"the config" instead of "then config"
Rephrasing this might be better:
"If a test needs specific kernel config options enabled, add a config file in the
test directory to enable them.
e.g: tools/testing/selftests/android/ion/config
> +
> Test Harness
> ============
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuah@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>, corbet@lwn.net
Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] doc: dev-tools: kselftest.rst: update contributing new tests
Date: Fri, 29 Jun 2018 06:09:45 -0600 [thread overview]
Message-ID: <53d599f2-44a1-c366-4a5c-2ca6cd19b031@kernel.org> (raw)
In-Reply-To: <20180629100248.11560-1-anders.roxell@linaro.org>
On 06/29/2018 04:02 AM, Anders Roxell wrote:
> Add a description that kernel config options should be added into a
> config file that is placed next to the newly added test.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> Documentation/dev-tools/kselftest.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index 3bf371a938d0..4c546a35bd58 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -156,6 +156,9 @@ Contributing new tests (details)
> installed by the distro on the system should be the primary focus to be able
> to find regressions.
>
> + * If a new test needs specific kernel options, they should be enabled in
get rid of new
> + then config file in the same directory where the test is added.
"the config" instead of "then config"
Rephrasing this might be better:
"If a test needs specific kernel config options enabled, add a config file in the
test directory to enable them.
e.g: tools/testing/selftests/android/ion/config
> +
> Test Harness
> ============
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (Shuah Khan)
Subject: [PATCH] doc: dev-tools: kselftest.rst: update contributing new tests
Date: Fri, 29 Jun 2018 06:09:45 -0600 [thread overview]
Message-ID: <53d599f2-44a1-c366-4a5c-2ca6cd19b031@kernel.org> (raw)
In-Reply-To: <20180629100248.11560-1-anders.roxell@linaro.org>
On 06/29/2018 04:02 AM, Anders Roxell wrote:
> Add a description that kernel config options should be added into a
> config file that is placed next to the newly added test.
>
> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
> ---
> Documentation/dev-tools/kselftest.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index 3bf371a938d0..4c546a35bd58 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -156,6 +156,9 @@ Contributing new tests (details)
> installed by the distro on the system should be the primary focus to be able
> to find regressions.
>
> + * If a new test needs specific kernel options, they should be enabled in
get rid of new
> + then config file in the same directory where the test is added.
"the config" instead of "then config"
Rephrasing this might be better:
"If a test needs specific kernel config options enabled, add a config file in the
test directory to enable them.
e.g: tools/testing/selftests/android/ion/config
> +
> Test Harness
> ============
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (Shuah Khan)
Subject: [PATCH] doc: dev-tools: kselftest.rst: update contributing new tests
Date: Fri, 29 Jun 2018 06:09:45 -0600 [thread overview]
Message-ID: <53d599f2-44a1-c366-4a5c-2ca6cd19b031@kernel.org> (raw)
Message-ID: <20180629120945.Z0UF_XYJlEBPWUGewU-TwarRfSQpNLmsVnztskPVcSw@z> (raw)
In-Reply-To: <20180629100248.11560-1-anders.roxell@linaro.org>
On 06/29/2018 04:02 AM, Anders Roxell wrote:
> Add a description that kernel config options should be added into a
> config file that is placed next to the newly added test.
>
> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
> ---
> Documentation/dev-tools/kselftest.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index 3bf371a938d0..4c546a35bd58 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -156,6 +156,9 @@ Contributing new tests (details)
> installed by the distro on the system should be the primary focus to be able
> to find regressions.
>
> + * If a new test needs specific kernel options, they should be enabled in
get rid of new
> + then config file in the same directory where the test is added.
"the config" instead of "then config"
Rephrasing this might be better:
"If a test needs specific kernel config options enabled, add a config file in the
test directory to enable them.
e.g: tools/testing/selftests/android/ion/config
> +
> Test Harness
> ============
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-29 12:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 10:02 [PATCH] doc: dev-tools: kselftest.rst: update contributing new tests Anders Roxell
2018-06-29 10:02 ` Anders Roxell
2018-06-29 10:02 ` anders.roxell
2018-06-29 10:02 ` Anders Roxell
2018-06-29 12:09 ` Shuah Khan [this message]
2018-06-29 12:09 ` Shuah Khan
2018-06-29 12:09 ` shuah
2018-06-29 12:09 ` Shuah Khan
2018-06-29 12:47 ` Anders Roxell
2018-06-29 12:47 ` Anders Roxell
2018-06-29 12:47 ` anders.roxell
2018-06-29 12:47 ` Anders Roxell
2018-06-29 12:52 ` [PATCH v2] " Anders Roxell
2018-06-29 12:52 ` Anders Roxell
2018-06-29 12:52 ` anders.roxell
2018-06-29 12:52 ` Anders Roxell
2018-06-29 13:29 ` Shuah Khan
2018-06-29 13:29 ` Shuah Khan
2018-06-29 13:29 ` shuah
2018-06-29 13:29 ` Shuah Khan
2018-06-29 15:02 ` Jonathan Corbet
2018-06-29 15:02 ` Jonathan Corbet
2018-06-29 15:02 ` corbet
2018-06-29 15:02 ` Jonathan Corbet
-- strict thread matches above, loose matches on Subject: below --
2018-04-17 8:46 [PATCH] " Anders Roxell
2018-04-17 8:46 ` Anders Roxell
2018-04-17 8:46 ` anders.roxell
2018-04-17 8:46 ` Anders Roxell
2018-04-18 14:48 ` Shuah Khan
2018-04-18 14:48 ` Shuah Khan
2018-04-18 14:48 ` shuah
2018-04-18 14:48 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53d599f2-44a1-c366-4a5c-2ca6cd19b031@kernel.org \
--to=shuah@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.