From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Aaron Tomlin <atomlin@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@osdl.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Tue, 22 Mar 2016 23:31:11 +0100 [thread overview]
Message-ID: <54039485.X1biSGXPBa@vostro.rjw.lan> (raw)
In-Reply-To: <1458667179-19630-5-git-send-email-cmetcalf@mellanox.com>
On Tuesday, March 22, 2016 01:19:39 PM Chris Metcalf wrote:
> When doing an nmi backtrace of many cores, most of which are idle,
> the output is a little overwhelming and very uninformative. Suppress
> messages for cpus that are idling when they are interrupted and just
> emit one line, "NMI backtrace for N skipped: idling at pc 0xNNN".
>
> We do this by grouping all the cpuidle code together into a new
> .cpuidle.text section, and then checking the address of the
> interrupted PC to see if it lies within that section.
>
> This commit suitably tags x86, arm64, and tile idle routines,
> and only adds in the minimal framework for other architectures.
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
[cut]
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index cd4510a63375..924554f920fb 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -725,8 +725,8 @@ static struct cpuidle_state avn_cstates[] = {
> *
> * Must be called under local_irq_disable().
> */
> -static int intel_idle(struct cpuidle_device *dev,
> - struct cpuidle_driver *drv, int index)
> +static __cpuidle int intel_idle(struct cpuidle_device *dev,
> + struct cpuidle_driver *drv, int index)
> {
> unsigned long ecx = 1; /* break on interrupt flag */
> struct cpuidle_state *state = &drv->states[index];
Well, what about intel_idle_freeze()? Or do we not care?
And analogous stuff in processor_idle.c for that matter?
acpi_idle_enter()/acpi_idle_enter_freeze() plus stuff called by those?
Thanks,
Rafael
WARNING: multiple messages have this Message-ID (diff)
From: rjw@rjwysocki.net (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Tue, 22 Mar 2016 23:31:11 +0100 [thread overview]
Message-ID: <54039485.X1biSGXPBa@vostro.rjw.lan> (raw)
In-Reply-To: <1458667179-19630-5-git-send-email-cmetcalf@mellanox.com>
On Tuesday, March 22, 2016 01:19:39 PM Chris Metcalf wrote:
> When doing an nmi backtrace of many cores, most of which are idle,
> the output is a little overwhelming and very uninformative. Suppress
> messages for cpus that are idling when they are interrupted and just
> emit one line, "NMI backtrace for N skipped: idling at pc 0xNNN".
>
> We do this by grouping all the cpuidle code together into a new
> .cpuidle.text section, and then checking the address of the
> interrupted PC to see if it lies within that section.
>
> This commit suitably tags x86, arm64, and tile idle routines,
> and only adds in the minimal framework for other architectures.
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
[cut]
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index cd4510a63375..924554f920fb 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -725,8 +725,8 @@ static struct cpuidle_state avn_cstates[] = {
> *
> * Must be called under local_irq_disable().
> */
> -static int intel_idle(struct cpuidle_device *dev,
> - struct cpuidle_driver *drv, int index)
> +static __cpuidle int intel_idle(struct cpuidle_device *dev,
> + struct cpuidle_driver *drv, int index)
> {
> unsigned long ecx = 1; /* break on interrupt flag */
> struct cpuidle_state *state = &drv->states[index];
Well, what about intel_idle_freeze()? Or do we not care?
And analogous stuff in processor_idle.c for that matter?
acpi_idle_enter()/acpi_idle_enter_freeze() plus stuff called by those?
Thanks,
Rafael
next prev parent reply other threads:[~2016-03-22 22:29 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 21:40 [PATCH 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-02-29 21:40 ` Chris Metcalf
2016-02-29 21:40 ` [PATCH 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-02-29 21:40 ` Chris Metcalf
2016-02-29 21:40 ` [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-01 14:23 ` Daniel Thompson
2016-03-01 16:01 ` Chris Metcalf
2016-03-07 8:26 ` Daniel Thompson
2016-03-07 17:05 ` Chris Metcalf
2016-03-07 9:48 ` Peter Zijlstra
2016-03-07 17:38 ` Chris Metcalf
2016-03-07 20:43 ` Peter Zijlstra
2016-03-16 17:02 ` [PATCH v2 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-16 17:02 ` [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-17 19:36 ` Peter Zijlstra
2016-03-17 19:36 ` Peter Zijlstra
2016-03-17 22:31 ` Chris Metcalf
2016-03-17 22:31 ` Chris Metcalf
2016-03-17 22:38 ` Peter Zijlstra
2016-03-17 22:38 ` Peter Zijlstra
2016-03-17 22:41 ` Chris Metcalf
2016-03-17 22:41 ` Chris Metcalf
2016-03-17 23:14 ` Peter Zijlstra
2016-03-17 23:14 ` Peter Zijlstra
2016-03-17 22:55 ` Paul E. McKenney
2016-03-17 22:55 ` Paul E. McKenney
2016-03-17 23:09 ` Peter Zijlstra
2016-03-17 23:09 ` Peter Zijlstra
2016-03-17 23:11 ` Peter Zijlstra
2016-03-17 23:11 ` Peter Zijlstra
2016-03-18 0:28 ` Paul E. McKenney
2016-03-18 0:28 ` Paul E. McKenney
2016-03-18 0:17 ` Chris Metcalf
2016-03-18 0:17 ` Chris Metcalf
2016-03-18 0:33 ` Paul E. McKenney
2016-03-18 0:33 ` Paul E. McKenney
2016-03-18 9:40 ` Daniel Thompson
2016-03-18 9:40 ` Daniel Thompson
2016-03-18 23:54 ` Paul E. McKenney
2016-03-18 23:54 ` Paul E. McKenney
2016-03-16 17:02 ` [PATCH v2 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-16 17:02 ` [PATCH v2 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-16 17:02 ` [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-16 17:02 ` Chris Metcalf
2016-03-16 18:46 ` kbuild test robot
2016-03-16 18:46 ` kbuild test robot
2016-03-16 18:46 ` kbuild test robot
2016-03-16 18:46 ` kbuild test robot
2016-03-21 15:38 ` Peter Zijlstra
2016-03-21 15:38 ` Peter Zijlstra
2016-03-21 15:38 ` Peter Zijlstra
2016-03-21 15:46 ` Chris Metcalf
2016-03-21 15:46 ` Chris Metcalf
2016-03-21 15:46 ` Chris Metcalf
2016-03-21 15:46 ` Chris Metcalf
2016-03-21 15:42 ` Peter Zijlstra
2016-03-21 15:42 ` Peter Zijlstra
2016-03-21 16:15 ` Chris Metcalf
2016-03-21 16:15 ` Chris Metcalf
2016-03-21 16:15 ` Chris Metcalf
2016-03-21 16:32 ` Peter Zijlstra
2016-03-21 16:32 ` Peter Zijlstra
2016-03-21 17:12 ` Chris Metcalf
2016-03-21 17:12 ` Chris Metcalf
2016-03-21 17:12 ` Chris Metcalf
2016-03-21 17:12 ` Chris Metcalf
2016-03-21 17:17 ` Peter Zijlstra
2016-03-21 17:17 ` Peter Zijlstra
2016-03-21 16:48 ` Peter Zijlstra
2016-03-21 16:48 ` Peter Zijlstra
2016-03-21 21:49 ` Peter Zijlstra
2016-03-21 21:49 ` Peter Zijlstra
2016-03-22 17:19 ` [PATCH v3 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:19 ` [PATCH v3 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:19 ` [PATCH v3 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:19 ` [PATCH v3 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-22 17:19 ` [PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:19 ` Chris Metcalf
2016-03-22 17:30 ` Peter Zijlstra
2016-03-22 17:30 ` Peter Zijlstra
2016-03-22 22:28 ` Rafael J. Wysocki
2016-03-22 22:28 ` Rafael J. Wysocki
2016-03-22 22:31 ` Rafael J. Wysocki [this message]
2016-03-22 22:31 ` Rafael J. Wysocki
2016-03-22 22:45 ` Peter Zijlstra
2016-03-22 22:45 ` Peter Zijlstra
2016-03-23 0:50 ` Rafael J. Wysocki
2016-03-23 0:50 ` Rafael J. Wysocki
2016-03-23 7:53 ` Peter Zijlstra
2016-03-23 7:53 ` Peter Zijlstra
2016-03-30 17:16 ` [PATCH v4 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-03-30 17:16 ` [PATCH v4 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-03-30 17:16 ` [PATCH v4 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-03-30 17:16 ` [PATCH v4 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-30 17:16 ` [PATCH v4 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-03-30 17:16 ` Chris Metcalf
2016-02-29 21:40 ` [PATCH 3/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-02-29 21:40 ` Chris Metcalf
2016-02-29 21:40 ` [PATCH 4/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-01 0:49 ` [PATCH 0/4] improvements to the nmi_backtrace code Andrew Morton
2016-03-01 0:49 ` Andrew Morton
2016-03-01 10:01 ` Petr Mladek
2016-03-01 10:01 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54039485.X1biSGXPBa@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=akpm@osdl.org \
--cc=atomlin@redhat.com \
--cc=cmetcalf@mellanox.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.