From: Jon Masters <jcm@redhat.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Tanmay Inamdar <tinamdar@apm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Rob Landley <rob@landley.net>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@apm.com" <patches@apm.com>
Subject: Re: [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver
Date: Thu, 18 Sep 2014 20:21:30 -0400 [thread overview]
Message-ID: <541B770A.8070502@redhat.com> (raw)
In-Reply-To: <20140917160337.GA15261@e104818-lin.cambridge.arm.com>
On 09/17/2014 12:03 PM, Catalin Marinas wrote:
> So for arm64 currently we have some hooks in dma-mapping.c to intercept
> when a device is added to a bus. What I need to do though is check
> recursively whether the parent (bus) had the 'dma-coherent' property
> (pointed out by Jon). I think something like this would do (not tested):
We've got a patch now that I posted internally and we've tested. I've
asked Mark Salter to send it upstream (but hey, you'll probably just
want to switch the default over to recurse up the tree and then simply
add a new notifier register for pci_bus_type). For this stuff to work,
we need v10 of the APM X-Gene patches because (as I noticed earlier when
going through their code and testing on a board with an actual card -
and a modified devicetree node for the PCI root) that's the point they
add a call to setup the root of_nodes correctly via pci_scan_root_bus.
Prior to that the trivially obvious patch for dma-coherent doesn't work.
Today, there are two platform PCIe devices that do it right, plus the
latest APM rev of their driver just posted.
Jon.
WARNING: multiple messages have this Message-ID (diff)
From: jcm@redhat.com (Jon Masters)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver
Date: Thu, 18 Sep 2014 20:21:30 -0400 [thread overview]
Message-ID: <541B770A.8070502@redhat.com> (raw)
In-Reply-To: <20140917160337.GA15261@e104818-lin.cambridge.arm.com>
On 09/17/2014 12:03 PM, Catalin Marinas wrote:
> So for arm64 currently we have some hooks in dma-mapping.c to intercept
> when a device is added to a bus. What I need to do though is check
> recursively whether the parent (bus) had the 'dma-coherent' property
> (pointed out by Jon). I think something like this would do (not tested):
We've got a patch now that I posted internally and we've tested. I've
asked Mark Salter to send it upstream (but hey, you'll probably just
want to switch the default over to recurse up the tree and then simply
add a new notifier register for pci_bus_type). For this stuff to work,
we need v10 of the APM X-Gene patches because (as I noticed earlier when
going through their code and testing on a board with an actual card -
and a modified devicetree node for the PCI root) that's the point they
add a call to setup the root of_nodes correctly via pci_scan_root_bus.
Prior to that the trivially obvious patch for dma-coherent doesn't work.
Today, there are two platform PCIe devices that do it right, plus the
latest APM rev of their driver just posted.
Jon.
next prev parent reply other threads:[~2014-09-19 0:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 22:57 [PATCH v8 0/4] APM X-Gene PCIe host controller Tanmay Inamdar
2014-09-11 22:57 ` Tanmay Inamdar
2014-09-11 22:57 ` [PATCH v8 1/4] pci:host: APM X-Gene PCIe host controller driver Tanmay Inamdar
2014-09-11 22:57 ` Tanmay Inamdar
2014-09-12 9:18 ` Liviu Dudau
2014-09-12 9:18 ` Liviu Dudau
2014-09-12 9:18 ` Liviu Dudau
2014-09-16 20:02 ` Tanmay Inamdar
2014-09-16 20:02 ` Tanmay Inamdar
2014-09-16 20:02 ` Tanmay Inamdar
2014-09-16 21:17 ` Liviu Dudau
2014-09-16 21:17 ` Liviu Dudau
2014-09-16 21:17 ` Liviu Dudau
2014-09-16 22:14 ` Tanmay Inamdar
2014-09-16 22:14 ` Tanmay Inamdar
2014-09-16 22:14 ` Tanmay Inamdar
2014-09-16 22:14 ` Tanmay Inamdar
2014-09-17 16:03 ` Catalin Marinas
2014-09-17 16:03 ` Catalin Marinas
2014-09-17 16:03 ` Catalin Marinas
2014-09-17 16:18 ` Jon Masters
2014-09-17 16:18 ` Jon Masters
2014-09-19 0:21 ` Jon Masters [this message]
2014-09-19 0:21 ` Jon Masters
2014-09-19 0:21 ` Jon Masters
2014-09-11 22:57 ` [PATCH v8 2/4] arm64: dts: APM X-Gene PCIe device tree nodes Tanmay Inamdar
2014-09-11 22:57 ` Tanmay Inamdar
2014-09-11 22:57 ` Tanmay Inamdar
2014-09-11 22:57 ` [PATCH v8 3/4] dt-bindings: pci: xgene pcie device tree bindings Tanmay Inamdar
2014-09-11 22:57 ` Tanmay Inamdar
2014-09-11 22:57 ` [PATCH v8 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver Tanmay Inamdar
2014-09-11 22:57 ` Tanmay Inamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B770A.8070502@redhat.com \
--to=jcm@redhat.com \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=patches@apm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.