All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Shuge <shuge@allwinnertech.com>,
	Meng Zhang <kevin@allwinnertech.com>, yhf <yhf@merrii.com>,
	ctl <ctl@merrii.com>, linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi
Date: Wed, 24 Sep 2014 14:36:12 +0200	[thread overview]
Message-ID: <5422BABC.7020906@free-electrons.com> (raw)
In-Reply-To: <CAGb2v64yGmdLeWmA=+nxD85DbQf_xxUNx3n3oedFZi51uc50+w@mail.gmail.com>

Hi Chen-Yu,


> 
> Thanks for the tip. Before I send v2, I do have a question. I'm using
> 
>     ranges = <0 0 0 0x20000000>;
> 
> in the clocks and soc node to avoid having to use 64bit values for all
> addresses and sizes. Would this be undesirable, even bad practice maybe?

We did something like that for all the internal registers too as they are all
under 4GB. In our case the use of a range really makes sens because the hardware
addresses were configurable. You don't have such requirement so I can't say if
it is a bad practice. From my point of view it seems sensible but I am not an
DT expert.


Grégory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Shuge <shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org>,
	Meng Zhang
	<kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org>,
	yhf <yhf-HcjymKqD97rQT0dZR+AlfA@public.gmane.org>,
	ctl <ctl-HcjymKqD97rQT0dZR+AlfA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: Re: [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi
Date: Wed, 24 Sep 2014 14:36:12 +0200	[thread overview]
Message-ID: <5422BABC.7020906@free-electrons.com> (raw)
In-Reply-To: <CAGb2v64yGmdLeWmA=+nxD85DbQf_xxUNx3n3oedFZi51uc50+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Chen-Yu,


> 
> Thanks for the tip. Before I send v2, I do have a question. I'm using
> 
>     ranges = <0 0 0 0x20000000>;
> 
> in the clocks and soc node to avoid having to use 64bit values for all
> addresses and sizes. Would this be undesirable, even bad practice maybe?

We did something like that for all the internal registers too as they are all
under 4GB. In our case the use of a range really makes sens because the hardware
addresses were configurable. You don't have such requirement so I can't say if
it is a bad practice. From my point of view it seems sensible but I am not an
DT expert.


Grégory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi
Date: Wed, 24 Sep 2014 14:36:12 +0200	[thread overview]
Message-ID: <5422BABC.7020906@free-electrons.com> (raw)
In-Reply-To: <CAGb2v64yGmdLeWmA=+nxD85DbQf_xxUNx3n3oedFZi51uc50+w@mail.gmail.com>

Hi Chen-Yu,


> 
> Thanks for the tip. Before I send v2, I do have a question. I'm using
> 
>     ranges = <0 0 0 0x20000000>;
> 
> in the clocks and soc node to avoid having to use 64bit values for all
> addresses and sizes. Would this be undesirable, even bad practice maybe?

We did something like that for all the internal registers too as they are all
under 4GB. In our case the use of a range really makes sens because the hardware
addresses were configurable. You don't have such requirement so I can't say if
it is a bad practice. From my point of view it seems sensible but I am not an
DT expert.


Gr?gory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2014-09-24 12:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21 14:58 [PATCH 0/6] ARM: sunxi: Add basic support for Allwinner A80 SoC Chen-Yu Tsai
2014-09-21 14:58 ` Chen-Yu Tsai
2014-09-21 14:58 ` Chen-Yu Tsai
2014-09-21 14:58 ` [PATCH 1/6] ARM: sunxi: Introduce Allwinner A80 support Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58 ` [PATCH 2/6] ARM: sunxi: Add debug uart used by sun9i (Allwinner A80) Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-24  6:39   ` Maxime Ripard
2014-09-24  6:39     ` Maxime Ripard
2014-09-24  6:39     ` Maxime Ripard
2014-09-21 14:58 ` [PATCH 3/6] ARM: dts: sunxi: Add Allwinner A80 dtsi Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-24  6:37   ` Maxime Ripard
2014-09-24  6:37     ` Maxime Ripard
2014-09-24  6:37     ` Maxime Ripard
2014-09-24  7:14     ` [linux-sunxi] " Chen-Yu Tsai
2014-09-24  7:14       ` Chen-Yu Tsai
2014-09-24  7:14       ` Chen-Yu Tsai
2014-09-24  7:18       ` [linux-sunxi] " Gregory CLEMENT
2014-09-24  7:18         ` Gregory CLEMENT
2014-09-24  7:18         ` Gregory CLEMENT
2014-09-24  7:27         ` [linux-sunxi] " Chen-Yu Tsai
2014-09-24  7:27           ` Chen-Yu Tsai
2014-09-24  7:27           ` Chen-Yu Tsai
2014-09-24 11:53         ` [linux-sunxi] " Chen-Yu Tsai
2014-09-24 11:53           ` Chen-Yu Tsai
2014-09-24 11:53           ` Chen-Yu Tsai
2014-09-24 12:36           ` Gregory CLEMENT [this message]
2014-09-24 12:36             ` [linux-sunxi] " Gregory CLEMENT
2014-09-24 12:36             ` Gregory CLEMENT
2014-09-21 14:58 ` [PATCH 4/6] ARM: dts: sun9i: Add A80 Optimus Board support Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58 ` [PATCH 5/6] devicetree: bindings: Add vendor prefix for Merrii Technology Co., Ltd Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58 ` [PATCH 6/6] devicetree: bindings: Document supported Allwinner sunxi SoCs Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-21 14:58   ` Chen-Yu Tsai
2014-09-24  6:41 ` [PATCH 0/6] ARM: sunxi: Add basic support for Allwinner A80 SoC Maxime Ripard
2014-09-24  6:41   ` Maxime Ripard
2014-09-24  6:41   ` Maxime Ripard
2014-09-24 10:40   ` Chen-Yu Tsai
2014-09-24 10:40     ` Chen-Yu Tsai
2014-09-24 10:40     ` Chen-Yu Tsai
2014-09-24 13:28     ` Maxime Ripard
2014-09-24 13:28       ` Maxime Ripard
2014-09-24 13:28       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422BABC.7020906@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=ctl@merrii.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kevin@allwinnertech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shuge@allwinnertech.com \
    --cc=wens@csie.org \
    --cc=yhf@merrii.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.