From: Caesar Wang <caesar.wang@rock-chips.com> To: Doug Anderson <dianders@chromium.org> Cc: "Heiko Stübner" <heiko@sntech.de>, "Zhang Rui" <rui.zhang@intel.com>, "Eduardo Valentin" <edubezval@gmail.com>, "Arnd Bergmann" <arnd@arndb.de>, zyf <zyf@rock-chips.com>, linux-rockchip@lists.infradead.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>, "Eddie Cai" <cf@rock-chips.com>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Derek Basehore" <dbasehore@chromium.org>, "Tao Huang" <huangtao@rock-chips.com>, 陈渐飞 <cjf@rock-chips.com>, "Shunqian Zheng" <zhengsq@rock-chips.com> Subject: Re: [PATCH v9 1/5] thermal: rockchip: add driver for thermal Date: Tue, 14 Oct 2014 22:03:00 +0800 [thread overview] Message-ID: <543D2D14.7000706@rock-chips.com> (raw) In-Reply-To: <CAD=FV=XHe65wwf8Q9RA0ZDgb5oQLdyjuZDFy4mD01_t6G6WnHQ@mail.gmail.com> Doug, 在 2014年10月14日 00:11, Doug Anderson 写道: > Caesar, > > On Sat, Oct 11, 2014 at 12:29 AM, Caesar Wang > <caesar.wang@rock-chips.com> wrote: > >> +static void rk_tsadcv2_initialize(int reset_mode, int chn, void __iomem *regs, >> + unsigned long hw_shut_temp) >> +{ >> + u32 shutdown_value; >> + >> + shutdown_value = rk_tsadcv2_temp_to_code(hw_shut_temp); >> + >> + /* Enable measurements at ~ 10 Hz */ >> + writel_relaxed(0 | TSADCV2_AUTO_TSHUT_POLARITY_HIGH, regs + >> + TSADCV2_AUTO_CON); >> + writel_relaxed(TSADCV2_AUTO_PERIOD_TIME, regs + TSADCV2_AUTO_PERIOD); >> + writel_relaxed(TSADCV2_AUTO_PERIOD_HT_TIME, regs + >> + TSADCV2_AUTO_PERIOD_HT); >> + writel_relaxed(shutdown_value, regs + TSADCV2_COMP_SHUT(chn)); >> + writel_relaxed(TSADCV2_HIGHT_INT_DEBOUNCE_TIME, regs + >> + TSADCV2_HIGHT_INT_DEBOUNCE); >> + writel_relaxed(TSADCV2_HIGHT_TSHUT_DEBOUNCE_TIME, regs + >> + TSADCV2_HIGHT_TSHUT_DEBOUNCE); >> + >> + if (reset_mode == GPIO) >> + writel_relaxed(TSADCV2_SHUT_2GPIO_SRC_EN(chn) | >> + TSADCV2_INT_SRC_EN(chn), regs + >> + TSADCV2_INT_EN); >> + else >> + writel_relaxed(TSADCV2_SHUT_2CRU_SRC_EN(chn) | >> + TSADCV2_INT_SRC_EN(chn) , regs + >> + TSADCV2_INT_EN); >> + >> + writel_relaxed(TSADCV2_AUTO_SRC_EN(chn) | TSADCV2_AUTO_EN, regs + >> + TSADCV2_AUTO_CON); > Aren't you clobbering the polarity here? > > NOTE: I didn't do a full review of this driver, just noticed that > while looking at another patch and figure'd I'd respond here, too. > Fixed. Maybe I should fix as follows: /** * rk_tsadcv2_get_tshut_polarity - get the tshut polarity * the bit 8 is tshut polarity,default is low active. * 0: low active, 1: high active */ static bool rk_tsadcv2_get_tshut_polarity(void __iomem *regs) { u32 val; bool tshut_polarity; val = readl_relaxed(regs + TSADCV2_AUTO_CON); tshut_polarity = (val & BIT(8))? 1 : 0; return tshut_polarity; } ... .... writel_relaxed(TSADCV2_AUTO_SRC_EN(chn) & (tshut_polarity << 8) | TSADCV2_AUTO_EN, regs + TSADCV2_AUTO_CON); > -- Best regards, Caesar
WARNING: multiple messages have this Message-ID (diff)
From: caesar.wang@rock-chips.com (Caesar Wang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 1/5] thermal: rockchip: add driver for thermal Date: Tue, 14 Oct 2014 22:03:00 +0800 [thread overview] Message-ID: <543D2D14.7000706@rock-chips.com> (raw) In-Reply-To: <CAD=FV=XHe65wwf8Q9RA0ZDgb5oQLdyjuZDFy4mD01_t6G6WnHQ@mail.gmail.com> Doug, ? 2014?10?14? 00:11, Doug Anderson ??: > Caesar, > > On Sat, Oct 11, 2014 at 12:29 AM, Caesar Wang > <caesar.wang@rock-chips.com> wrote: > >> +static void rk_tsadcv2_initialize(int reset_mode, int chn, void __iomem *regs, >> + unsigned long hw_shut_temp) >> +{ >> + u32 shutdown_value; >> + >> + shutdown_value = rk_tsadcv2_temp_to_code(hw_shut_temp); >> + >> + /* Enable measurements at ~ 10 Hz */ >> + writel_relaxed(0 | TSADCV2_AUTO_TSHUT_POLARITY_HIGH, regs + >> + TSADCV2_AUTO_CON); >> + writel_relaxed(TSADCV2_AUTO_PERIOD_TIME, regs + TSADCV2_AUTO_PERIOD); >> + writel_relaxed(TSADCV2_AUTO_PERIOD_HT_TIME, regs + >> + TSADCV2_AUTO_PERIOD_HT); >> + writel_relaxed(shutdown_value, regs + TSADCV2_COMP_SHUT(chn)); >> + writel_relaxed(TSADCV2_HIGHT_INT_DEBOUNCE_TIME, regs + >> + TSADCV2_HIGHT_INT_DEBOUNCE); >> + writel_relaxed(TSADCV2_HIGHT_TSHUT_DEBOUNCE_TIME, regs + >> + TSADCV2_HIGHT_TSHUT_DEBOUNCE); >> + >> + if (reset_mode == GPIO) >> + writel_relaxed(TSADCV2_SHUT_2GPIO_SRC_EN(chn) | >> + TSADCV2_INT_SRC_EN(chn), regs + >> + TSADCV2_INT_EN); >> + else >> + writel_relaxed(TSADCV2_SHUT_2CRU_SRC_EN(chn) | >> + TSADCV2_INT_SRC_EN(chn) , regs + >> + TSADCV2_INT_EN); >> + >> + writel_relaxed(TSADCV2_AUTO_SRC_EN(chn) | TSADCV2_AUTO_EN, regs + >> + TSADCV2_AUTO_CON); > Aren't you clobbering the polarity here? > > NOTE: I didn't do a full review of this driver, just noticed that > while looking at another patch and figure'd I'd respond here, too. > Fixed. Maybe I should fix as follows: /** * rk_tsadcv2_get_tshut_polarity - get the tshut polarity * the bit 8 is tshut polarity,default is low active. * 0: low active, 1: high active */ static bool rk_tsadcv2_get_tshut_polarity(void __iomem *regs) { u32 val; bool tshut_polarity; val = readl_relaxed(regs + TSADCV2_AUTO_CON); tshut_polarity = (val & BIT(8))? 1 : 0; return tshut_polarity; } ... .... writel_relaxed(TSADCV2_AUTO_SRC_EN(chn) & (tshut_polarity << 8) | TSADCV2_AUTO_EN, regs + TSADCV2_AUTO_CON); > -- Best regards, Caesar
next prev parent reply other threads:[~2014-10-14 14:03 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-11 7:29 [PATCH v9 0/5] Rockchip soc thermal driver Caesar Wang 2014-10-11 7:29 ` Caesar Wang 2014-10-11 7:29 ` [PATCH v9 1/5] thermal: rockchip: add driver for thermal Caesar Wang 2014-10-11 7:29 ` Caesar Wang 2014-10-13 16:11 ` Doug Anderson 2014-10-13 16:11 ` Doug Anderson 2014-10-14 14:03 ` Caesar Wang [this message] 2014-10-14 14:03 ` Caesar Wang 2014-10-11 7:29 ` [PATCH v9 2/5] dt-bindings: document Rockchip thermal Caesar Wang 2014-10-11 7:29 ` Caesar Wang 2014-10-11 7:29 ` [PATCH v9 3/5] ARM: dts: add RK3288 Thermal data Caesar Wang 2014-10-11 7:29 ` Caesar Wang 2014-10-11 7:29 ` [PATCH v9 4/5] ARM: dts: add main Thermal info to rk3288 Caesar Wang 2014-10-11 7:29 ` Caesar Wang 2014-10-11 7:29 ` [PATCH v9 5/5] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang 2014-10-11 7:29 ` Caesar Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=543D2D14.7000706@rock-chips.com \ --to=caesar.wang@rock-chips.com \ --cc=arnd@arndb.de \ --cc=cf@rock-chips.com \ --cc=cjf@rock-chips.com \ --cc=dbasehore@chromium.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=edubezval@gmail.com \ --cc=heiko@sntech.de \ --cc=huangtao@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=rui.zhang@intel.com \ --cc=zhengsq@rock-chips.com \ --cc=zyf@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.