From: Varka Bhadram <varkabhadram@gmail.com> To: "jinkun.hong" <jinkun.hong@rock-chips.com>, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Cc: Russell King <linux@arm.linux.org.uk>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Grant Likely <grant.likely@linaro.org>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>, linux-doc@vger.kernel.org, dianders@chromium.org, Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org, Ulf Hansson <ulf.hansson@linaro.org>, Jack Dai <jack.dai@rock-chips.com> Subject: Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform Date: Mon, 20 Oct 2014 14:39:48 +0530 [thread overview] Message-ID: <5444D15C.4030308@gmail.com> (raw) In-Reply-To: <1413795824-3453-2-git-send-email-jinkun.hong@rock-chips.com> On 10/20/2014 02:33 PM, jinkun.hong wrote: > From: "jinkun.hong" <jinkun.hong@rock-chips.com> > > Add power domain drivers based on generic power domain for Rockchip platform, > and support RK3288. > > Signed-off-by: Jack Dai <jack.dai@rock-chips.com> > Signed-off-by: jinkun.hong <jinkun.hong@rock-chips.com> > > --- > (...) > +static int rockchip_pd_power(struct rockchip_domain *pd, bool power_on) > +{ > + int i = 0; > + int ret = 0; > + struct rockchip_dev_entry *de; > + > + spin_lock_irq(&pd->dev_lock); > + > + list_for_each_entry(de, &pd->dev_list, node) { > + i += 1; > + pm_clk_resume(pd->dev); > + } > + > + /* no clk, set power domain will fail */ > + if (i == 0) { > + pr_err("%s: failed to on/off power domain!", __func__); Missed terminating new line :-) > + spin_unlock_irq(&pd->dev_lock); > + return ret; > + } > + > + ret = rockchip_pmu_set_power_domain(pd, power_on); > + > + list_for_each_entry(de, &pd->dev_list, node) { > + pm_clk_suspend(pd->dev); > + } > + > + spin_unlock_irq(&pd->dev_lock); > + > + return ret; > +} > + (...) > +static int rockchip_pm_domain_probe(struct platform_device *pdev) > +{ > + struct device_node *node; > + struct regmap *regmap_pmu; > + struct rockchip_domain *pd; > + const struct of_device_id *match; > + > + match = of_match_node(rockchip_pm_domain_dt_match, pdev->dev.of_node); > + pd = (struct rockchip_domain *)match->data; > + Unnecessary one line space.. > + if (!pd) > + return -ENOMEM; > + > + node = of_parse_phandle(pdev->dev.of_node, "rockchip,pmu", 0); > + regmap_pmu = syscon_node_to_regmap(node); > + of_node_put(node); > + if (IS_ERR(regmap_pmu)) { > + pr_err("%s: failed to get regmap_pmu", __func__); Terminating new line missed... :-) > + return PTR_ERR(regmap_pmu); > + } > + > + pd->regmap_pmu = regmap_pmu; > + pd->dev = &pdev->dev; > + > + INIT_LIST_HEAD(&pd->dev_list); > + > + spin_lock_init(&pd->idle_lock); > + spin_lock_init(&pd->pmu_lock); > + spin_lock_init(&pd->dev_lock); > + > + pm_genpd_init(&pd->base, NULL, false); > + > + return of_genpd_add_provider_simple(pdev->dev.of_node, &pd->base); > +} > + > -- Thanks and Regards, Varka Bhadram.
WARNING: multiple messages have this Message-ID (diff)
From: varkabhadram@gmail.com (Varka Bhadram) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform Date: Mon, 20 Oct 2014 14:39:48 +0530 [thread overview] Message-ID: <5444D15C.4030308@gmail.com> (raw) In-Reply-To: <1413795824-3453-2-git-send-email-jinkun.hong@rock-chips.com> On 10/20/2014 02:33 PM, jinkun.hong wrote: > From: "jinkun.hong" <jinkun.hong@rock-chips.com> > > Add power domain drivers based on generic power domain for Rockchip platform, > and support RK3288. > > Signed-off-by: Jack Dai <jack.dai@rock-chips.com> > Signed-off-by: jinkun.hong <jinkun.hong@rock-chips.com> > > --- > (...) > +static int rockchip_pd_power(struct rockchip_domain *pd, bool power_on) > +{ > + int i = 0; > + int ret = 0; > + struct rockchip_dev_entry *de; > + > + spin_lock_irq(&pd->dev_lock); > + > + list_for_each_entry(de, &pd->dev_list, node) { > + i += 1; > + pm_clk_resume(pd->dev); > + } > + > + /* no clk, set power domain will fail */ > + if (i == 0) { > + pr_err("%s: failed to on/off power domain!", __func__); Missed terminating new line :-) > + spin_unlock_irq(&pd->dev_lock); > + return ret; > + } > + > + ret = rockchip_pmu_set_power_domain(pd, power_on); > + > + list_for_each_entry(de, &pd->dev_list, node) { > + pm_clk_suspend(pd->dev); > + } > + > + spin_unlock_irq(&pd->dev_lock); > + > + return ret; > +} > + (...) > +static int rockchip_pm_domain_probe(struct platform_device *pdev) > +{ > + struct device_node *node; > + struct regmap *regmap_pmu; > + struct rockchip_domain *pd; > + const struct of_device_id *match; > + > + match = of_match_node(rockchip_pm_domain_dt_match, pdev->dev.of_node); > + pd = (struct rockchip_domain *)match->data; > + Unnecessary one line space.. > + if (!pd) > + return -ENOMEM; > + > + node = of_parse_phandle(pdev->dev.of_node, "rockchip,pmu", 0); > + regmap_pmu = syscon_node_to_regmap(node); > + of_node_put(node); > + if (IS_ERR(regmap_pmu)) { > + pr_err("%s: failed to get regmap_pmu", __func__); Terminating new line missed... :-) > + return PTR_ERR(regmap_pmu); > + } > + > + pd->regmap_pmu = regmap_pmu; > + pd->dev = &pdev->dev; > + > + INIT_LIST_HEAD(&pd->dev_list); > + > + spin_lock_init(&pd->idle_lock); > + spin_lock_init(&pd->pmu_lock); > + spin_lock_init(&pd->dev_lock); > + > + pm_genpd_init(&pd->base, NULL, false); > + > + return of_genpd_add_provider_simple(pdev->dev.of_node, &pd->base); > +} > + > -- Thanks and Regards, Varka Bhadram.
next prev parent reply other threads:[~2014-10-20 9:12 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-20 9:03 [PATCH v4 0/3] ARM: rk3288 : Add PM Domain support jinkun.hong 2014-10-20 9:03 ` jinkun.hong 2014-10-20 9:03 ` [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform jinkun.hong 2014-10-20 9:03 ` jinkun.hong 2014-10-20 9:09 ` Varka Bhadram [this message] 2014-10-20 9:09 ` Varka Bhadram 2014-10-20 21:31 ` Kevin Hilman 2014-10-20 21:31 ` Kevin Hilman 2014-10-20 21:40 ` Russell King - ARM Linux 2014-10-20 21:40 ` Russell King - ARM Linux 2014-10-22 3:40 ` Hong jinkun 2014-10-22 3:40 ` Hong jinkun 2014-10-20 9:03 ` [PATCH v4 2/3] dt-bindings: add document of Rockchip power domain jinkun.hong 2014-10-20 9:03 ` jinkun.hong 2014-10-20 9:03 ` [PATCH v4 3/3] ARM: dts: add rk3288 power-domain node jinkun.hong 2014-10-20 9:03 ` jinkun.hong 2014-10-20 21:32 ` [PATCH v4 0/3] ARM: rk3288 : Add PM Domain support Kevin Hilman 2014-10-20 21:32 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5444D15C.4030308@gmail.com \ --to=varkabhadram@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jack.dai@rock-chips.com \ --cc=jinkun.hong@rock-chips.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.