From: John Fastabend <john.fastabend@gmail.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S . Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure
Date: Wed, 30 May 2018 06:26:44 -0700 [thread overview]
Message-ID: <544b1334-813e-d02e-3539-fa5905a42238@gmail.com> (raw)
In-Reply-To: <20180530055611.10216-2-bhole_prashant_q7@lab.ntt.co.jp>
On 05/29/2018 10:56 PM, Prashant Bhole wrote:
> Test failures are not identified because exit code of RX/TX threads
> is not checked. Also threads are not returning correct exit code.
>
> - Return exit code from threads depending on test execution status
> - In main thread, check the exit code of RX/TX threads
> - Skip error checking for corked tests as they are expected to timeout
>
> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> ---
> tools/testing/selftests/bpf/test_sockmap.c | 25 ++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
Looks good. Thanks.
Acked-by: John Fastabend <john.fastabend@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: john.fastabend at gmail.com (John Fastabend)
Subject: [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure
Date: Wed, 30 May 2018 06:26:44 -0700 [thread overview]
Message-ID: <544b1334-813e-d02e-3539-fa5905a42238@gmail.com> (raw)
In-Reply-To: <20180530055611.10216-2-bhole_prashant_q7@lab.ntt.co.jp>
On 05/29/2018 10:56 PM, Prashant Bhole wrote:
> Test failures are not identified because exit code of RX/TX threads
> is not checked. Also threads are not returning correct exit code.
>
> - Return exit code from threads depending on test execution status
> - In main thread, check the exit code of RX/TX threads
> - Skip error checking for corked tests as they are expected to timeout
>
> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
> ---
> tools/testing/selftests/bpf/test_sockmap.c | 25 ++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
Looks good. Thanks.
Acked-by: John Fastabend <john.fastabend at gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: john.fastabend@gmail.com (John Fastabend)
Subject: [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure
Date: Wed, 30 May 2018 06:26:44 -0700 [thread overview]
Message-ID: <544b1334-813e-d02e-3539-fa5905a42238@gmail.com> (raw)
Message-ID: <20180530132644.G_vz7Jq1UUJqZ96NvB9jHMrP1wr6ZfKlZIwuvIlnbg0@z> (raw)
In-Reply-To: <20180530055611.10216-2-bhole_prashant_q7@lab.ntt.co.jp>
On 05/29/2018 10:56 PM, Prashant Bhole wrote:
> Test failures are not identified because exit code of RX/TX threads
> is not checked. Also threads are not returning correct exit code.
>
> - Return exit code from threads depending on test execution status
> - In main thread, check the exit code of RX/TX threads
> - Skip error checking for corked tests as they are expected to timeout
>
> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
> ---
> tools/testing/selftests/bpf/test_sockmap.c | 25 ++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
Looks good. Thanks.
Acked-by: John Fastabend <john.fastabend at gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-30 13:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 5:56 [PATCH bpf v3 0/5] fix test_sockmap Prashant Bhole
2018-05-30 5:56 ` Prashant Bhole
2018-05-30 5:56 ` bhole_prashant_q7
2018-05-30 5:56 ` [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-30 5:56 ` Prashant Bhole
2018-05-30 5:56 ` bhole_prashant_q7
2018-05-30 13:26 ` John Fastabend [this message]
2018-05-30 13:26 ` John Fastabend
2018-05-30 13:26 ` john.fastabend
2018-05-30 5:56 ` [PATCH bpf v3 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-30 5:56 ` Prashant Bhole
2018-05-30 5:56 ` bhole_prashant_q7
2018-05-30 5:56 ` [PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout Prashant Bhole
2018-05-30 5:56 ` Prashant Bhole
2018-05-30 5:56 ` bhole_prashant_q7
2018-05-30 13:31 ` John Fastabend
2018-05-30 13:31 ` John Fastabend
2018-05-30 13:31 ` john.fastabend
2018-05-30 19:29 ` Alexei Starovoitov
2018-05-30 19:29 ` Alexei Starovoitov
2018-05-30 19:29 ` alexei.starovoitov
2018-05-30 19:59 ` John Fastabend
2018-05-30 19:59 ` John Fastabend
2018-05-30 19:59 ` john.fastabend
2018-05-31 4:13 ` Prashant Bhole
2018-05-31 4:13 ` Prashant Bhole
2018-05-31 4:13 ` bhole_prashant_q7
2018-06-01 14:03 ` John Fastabend
2018-06-01 14:03 ` John Fastabend
2018-06-01 14:03 ` john.fastabend
2018-05-30 5:56 ` [PATCH bpf v3 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-30 5:56 ` Prashant Bhole
2018-05-30 5:56 ` bhole_prashant_q7
2018-05-30 5:56 ` [PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-30 5:56 ` Prashant Bhole
2018-05-30 5:56 ` bhole_prashant_q7
2018-05-30 13:32 ` [PATCH bpf v3 0/5] fix test_sockmap John Fastabend
2018-05-30 13:32 ` John Fastabend
2018-05-30 13:32 ` john.fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544b1334-813e-d02e-3539-fa5905a42238@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.