From: Steve Dickson <SteveD@redhat.com>
To: Henrique Martins <linux@martins.cc>
Cc: linux-nfs@vger.kernel.org
Subject: Re: F20 nfs-utils exportfs patch
Date: Tue, 04 Nov 2014 12:57:25 -0500 [thread overview]
Message-ID: <54591385.2080007@RedHat.com> (raw)
In-Reply-To: <15531.1414780435@monster.martins.cc>
Re-posting with the patch inlined with comments.
On 10/31/2014 02:33 PM, Henrique Martins wrote:
>
> Re-sending this patch, at Steve Dickson's request.
Thanks... but... :-)
There is no Signed-off-by: line as described in
https://www.kernel.org/doc/Documentation/SubmittingPatches
and there is no description section as the above document
describes
Also, please in-line the patch in the email instead
of attaching them... I just makes is easier to review.
>
> -- Henrique
>
> --------------------------------------------------------------
>
> Attaching path to exportfs that:
> - in client.c/client_lookup:
> changes the (x)log level for unresolvable entries in
> /etc/exports from L_ERROR to L_WARNING,
> - in hostname.c/host_addrinfo:
> changes the (x)log level for unresolvable entries in
> /etc/exports from D_GENERAL to D_PARSE,
> - in export.c/export_read:
> counts the number of exported volume entries and
> generates a (x)log L_ERROR if no volumes are exported.
>
> Built and tested on a Fedora 20 system.
>
> --------------------------------------------------------------
>
--- nfs-utils-1.3.0/support/export/client.c.orig 2014-09-05 08:21:37.568364360 -0700
+++ nfs-utils-1.3.0/support/export/client.c 2014-09-05 08:21:41.709451778 -0700
@@ -277,7 +277,7 @@
if (htype == MCL_FQDN && !canonical) {
ai = host_addrinfo(hname);
if (!ai) {
- xlog(L_ERROR, "Failed to resolve %s", hname);
+ xlog(L_WARNING, "Failed to resolve %s", hname);
goto out;
}
hname = ai->ai_canonname;
--- nfs-utils-1.3.0/support/export/hostname.c.orig 2014-09-05 08:09:07.387551291 -0700
+++ nfs-utils-1.3.0/support/export/hostname.c 2014-09-05 08:09:13.799573723 -0700
@@ -175,11 +175,11 @@
case 0:
return ai;
case EAI_SYSTEM:
- xlog(D_GENERAL, "%s: failed to resolve %s: (%d) %m",
+ xlog(D_PARSE, "%s: failed to resolve %s: (%d) %m",
__func__, hostname, errno);
break;
default:
- xlog(D_GENERAL, "%s: failed to resolve %s: %s",
+ xlog(D_PARSE, "%s: failed to resolve %s: %s",
__func__, hostname, gai_strerror(error));
break;
}
Just curious as to why these changes... What does D_PARSE do that
D_GENERAL does not?
--- nfs-utils-1.3.0/support/export/export.c.orig 2014-03-25 08:12:07.000000000 -0700
+++ nfs-utils-1.3.0/support/export/export.c 2014-09-05 09:23:37.424105125 -0700
@@ -76,15 +76,22 @@
struct exportent *eep;
nfs_export *exp;
+ int volumes = 0;
+
setexportent(fname, "r");
while ((eep = getexportent(0,1)) != NULL) {
exp = export_lookup(eep->e_hostname, eep->e_path, 0);
- if (!exp)
- export_create(eep, 0);
+ if (!exp) {
+ exp = export_create(eep, 0);
+ if (exp)
+ volumes++;
+ }
else
warn_duplicated_exports(exp, eep);
}
endexportent();
+ if (volumes == 0)
+ xlog(L_ERROR, "no or all unresolvable export entries");
}
/**
When testing the patch, I notice two "Failed to resolve" warning messages
are logged for each export... Its not because of this patch but
I wounder how that could be cleaned up a bit....
So please re-post with in correct patch format and we will be good to go!
steved.
next prev parent reply other threads:[~2014-11-04 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:02 F20 nfs-utils exportfs patch Henrique Martins
2014-10-31 18:33 ` Henrique Martins
2014-11-04 17:57 ` Steve Dickson [this message]
2014-11-05 1:30 ` Henrique Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54591385.2080007@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@martins.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.