From: Andreas Ruprecht <rupran@einserver.de>
To: Mark Brown <broonie@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Add dependency to I2S device driver
Date: Fri, 21 Nov 2014 20:42:54 +0100 [thread overview]
Message-ID: <546F95BE.8080808@einserver.de> (raw)
In-Reply-To: <20141121185856.GJ3815@sirena.org.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 21.11.2014 19:58, Mark Brown wrote:
> On Fri, Nov 21, 2014 at 07:35:13PM +0100, Andreas Ruprecht wrote:
>> Currently, CONFIG_SND_SOC_ROCKCHIP_I2S could also be selected
>> without having CONFIG_SND_SOC_ROCKCHIP enabled.
>>
>> As this makes no sense (and breaks the build, when the option
>> CONFIG_SND_SOC_GENERIC_DMAENGINE_PCM - which would be selected
>> by CONFIG_SND_SOC_ROCKCHIP - is not enabled), a Kconfig
>> dependency is added to CONFIG_SND_SOC_ROCKCHIP_I2S. This will
>> make the item visible only if CONFIG_SND_SOC_ROCKCHIP is
>> enabled.
>
> This doesn't seem like an obvious fix - why is the fix not to put
> the select on the I2S driver (which is the thing that actually
> depends on the dmaengine stuff)?
>
I didn't look a lot further into it, I just saw the build error report
and from the other commits touching the Kconfig file it looked like
there could be more options in the future.
I will submit a v2 of the patch in a minute with the select for the
dmaengine support moved to the I2S option.
Regards,
Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJUb5W9AAoJEJBoQA9qo224gp0P/0tSHqlwTn1CnB3KQR+sEdnN
KzJwEZr5NbdXZyu6eBq0n7IS7MdmusW4BZrFkO2YNwyTPCb0kQPo8gD8IRXYYqdv
Hlkx0k4X8lZrkIFQJak1w3ZNVds6pl81ljf33GAZ82cYJA4c/wPDBv6HVggXjlwc
0sVn4i+JuHXnvhTuiQPs1kPC6S0NGo69yow1xK2W2t46WCFqiI4b6ZSPqC3RP3CA
8wMpdzYzA9VXKpwuAkMzFy+uTBfiJFEkAQhhb8kEiOMQoOsIO5SAMMHce7HodFpd
m3nWfIl+C8ZPtIWuJPKcA8BY+L58bjE3OneCLTK50WRQn36AFeLQC7DPij5zHCDJ
lBxEpCP78dv/N058h9hpIloRzbESCjtQxhvyW3nkNbFLYUqKy1MW9yJkKDCzC1v2
yAYmxlo6JAQHzvZGOcy3RVX8Rar5JS7raNygPizLkQCPqrUfqhWUg6h2h32wKgUN
CXRO1pf0Sz9Uaxjx6CBowwxJlIZN9EiVQpCPmV+BeIeIuRgsPZF3rDPuHHw+WwCp
F2Oih8U5ytNBfVwQgcTEM1doYmaYQpFTSBDMIerTTxZKTZsEa+x1EyX3f2aievIW
EPJgOM15cODsAepRh74PsofmPYe6aFL+lTSIVwPv351exK2ELJwfCUBzsk50Hu8z
MQOsYmY33VXh2VemTlek
=xmsJ
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: rupran@einserver.de (Andreas Ruprecht)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: rockchip: i2s: Add dependency to I2S device driver
Date: Fri, 21 Nov 2014 20:42:54 +0100 [thread overview]
Message-ID: <546F95BE.8080808@einserver.de> (raw)
In-Reply-To: <20141121185856.GJ3815@sirena.org.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 21.11.2014 19:58, Mark Brown wrote:
> On Fri, Nov 21, 2014 at 07:35:13PM +0100, Andreas Ruprecht wrote:
>> Currently, CONFIG_SND_SOC_ROCKCHIP_I2S could also be selected
>> without having CONFIG_SND_SOC_ROCKCHIP enabled.
>>
>> As this makes no sense (and breaks the build, when the option
>> CONFIG_SND_SOC_GENERIC_DMAENGINE_PCM - which would be selected
>> by CONFIG_SND_SOC_ROCKCHIP - is not enabled), a Kconfig
>> dependency is added to CONFIG_SND_SOC_ROCKCHIP_I2S. This will
>> make the item visible only if CONFIG_SND_SOC_ROCKCHIP is
>> enabled.
>
> This doesn't seem like an obvious fix - why is the fix not to put
> the select on the I2S driver (which is the thing that actually
> depends on the dmaengine stuff)?
>
I didn't look a lot further into it, I just saw the build error report
and from the other commits touching the Kconfig file it looked like
there could be more options in the future.
I will submit a v2 of the patch in a minute with the select for the
dmaengine support moved to the I2S option.
Regards,
Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJUb5W9AAoJEJBoQA9qo224gp0P/0tSHqlwTn1CnB3KQR+sEdnN
KzJwEZr5NbdXZyu6eBq0n7IS7MdmusW4BZrFkO2YNwyTPCb0kQPo8gD8IRXYYqdv
Hlkx0k4X8lZrkIFQJak1w3ZNVds6pl81ljf33GAZ82cYJA4c/wPDBv6HVggXjlwc
0sVn4i+JuHXnvhTuiQPs1kPC6S0NGo69yow1xK2W2t46WCFqiI4b6ZSPqC3RP3CA
8wMpdzYzA9VXKpwuAkMzFy+uTBfiJFEkAQhhb8kEiOMQoOsIO5SAMMHce7HodFpd
m3nWfIl+C8ZPtIWuJPKcA8BY+L58bjE3OneCLTK50WRQn36AFeLQC7DPij5zHCDJ
lBxEpCP78dv/N058h9hpIloRzbESCjtQxhvyW3nkNbFLYUqKy1MW9yJkKDCzC1v2
yAYmxlo6JAQHzvZGOcy3RVX8Rar5JS7raNygPizLkQCPqrUfqhWUg6h2h32wKgUN
CXRO1pf0Sz9Uaxjx6CBowwxJlIZN9EiVQpCPmV+BeIeIuRgsPZF3rDPuHHw+WwCp
F2Oih8U5ytNBfVwQgcTEM1doYmaYQpFTSBDMIerTTxZKTZsEa+x1EyX3f2aievIW
EPJgOM15cODsAepRh74PsofmPYe6aFL+lTSIVwPv351exK2ELJwfCUBzsk50Hu8z
MQOsYmY33VXh2VemTlek
=xmsJ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-11-21 19:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:35 [PATCH] ASoC: rockchip: i2s: Add dependency to I2S device driver Andreas Ruprecht
2014-11-21 18:35 ` Andreas Ruprecht
2014-11-21 18:58 ` Mark Brown
2014-11-21 18:58 ` Mark Brown
2014-11-21 19:42 ` Andreas Ruprecht [this message]
2014-11-21 19:42 ` Andreas Ruprecht
2014-11-21 19:50 ` [PATCH v2] ASoC: rockchip: i2s: Fix Kconfig for " Andreas Ruprecht
2014-11-21 19:50 ` Andreas Ruprecht
2014-11-24 19:01 ` Mark Brown
2014-11-24 19:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F95BE.8080808@einserver.de \
--to=rupran@einserver.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.