All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Randy Li <ayaka@soulik.info>
Cc: devicetree@vger.kernel.org, mark.rutland@arm.com,
	linux@armlinux.org.uk, kgene@kernel.org, krzk@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh@kernel.org
Subject: Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version
Date: Thu, 01 Sep 2016 15:03:51 +0200	[thread overview]
Message-ID: <5477278.USWYFxDPfA@amdc1976> (raw)
In-Reply-To: <1472648307-3818-1-git-send-email-ayaka@soulik.info>


Hi,

On Wednesday, August 31, 2016 08:58:27 PM Randy Li wrote:
> The TOPEET itop is a samsung exnynos 4412 core board, which have
> two package versions. This patch add the support for SCP version.
> 
> Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and
> PMIC. The future features are in the based board. Also MFC and
> watchdog have been enabled.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 490 ++++++++++++++++++++++++
>  1 file changed, 490 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi

[...]

> +		s5m8767_osc: clocks {

Don't you also need:

			compatible = "samsung,s5m8767-clk";

here?

BTW Does anyone know why there are no users of
"samsung,s2mps11-clk" compatible in the tree
(commit 53c31b3437a6400c6ffc2c9315680217ad84cb6d
"mfd: sec-core: Add of_compatible strings for
clock MFD cells" added it in March 2014)?

> +			#clock-cells = <1>;
> +			clock-output-names = "s5m8767_ap",
> +					"s5m8767_cp", "s5m8767_bt";
> +		};
> +
> +	};
> +};

[...]

> +&rtc {
> +	status = "okay";
> +	clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
> +};

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version
Date: Thu, 01 Sep 2016 15:03:51 +0200	[thread overview]
Message-ID: <5477278.USWYFxDPfA@amdc1976> (raw)
In-Reply-To: <1472648307-3818-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>


Hi,

On Wednesday, August 31, 2016 08:58:27 PM Randy Li wrote:
> The TOPEET itop is a samsung exnynos 4412 core board, which have
> two package versions. This patch add the support for SCP version.
> 
> Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and
> PMIC. The future features are in the based board. Also MFC and
> watchdog have been enabled.
> 
> Signed-off-by: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
> ---
>  arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 490 ++++++++++++++++++++++++
>  1 file changed, 490 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi

[...]

> +		s5m8767_osc: clocks {

Don't you also need:

			compatible = "samsung,s5m8767-clk";

here?

BTW Does anyone know why there are no users of
"samsung,s2mps11-clk" compatible in the tree
(commit 53c31b3437a6400c6ffc2c9315680217ad84cb6d
"mfd: sec-core: Add of_compatible strings for
clock MFD cells" added it in March 2014)?

> +			#clock-cells = <1>;
> +			clock-output-names = "s5m8767_ap",
> +					"s5m8767_cp", "s5m8767_bt";
> +		};
> +
> +	};
> +};

[...]

> +&rtc {
> +	status = "okay";
> +	clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
> +};

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version
Date: Thu, 01 Sep 2016 15:03:51 +0200	[thread overview]
Message-ID: <5477278.USWYFxDPfA@amdc1976> (raw)
In-Reply-To: <1472648307-3818-1-git-send-email-ayaka@soulik.info>


Hi,

On Wednesday, August 31, 2016 08:58:27 PM Randy Li wrote:
> The TOPEET itop is a samsung exnynos 4412 core board, which have
> two package versions. This patch add the support for SCP version.
> 
> Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and
> PMIC. The future features are in the based board. Also MFC and
> watchdog have been enabled.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 490 ++++++++++++++++++++++++
>  1 file changed, 490 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi

[...]

> +		s5m8767_osc: clocks {

Don't you also need:

			compatible = "samsung,s5m8767-clk";

here?

BTW Does anyone know why there are no users of
"samsung,s2mps11-clk" compatible in the tree
(commit 53c31b3437a6400c6ffc2c9315680217ad84cb6d
"mfd: sec-core: Add of_compatible strings for
clock MFD cells" added it in March 2014)?

> +			#clock-cells = <1>;
> +			clock-output-names = "s5m8767_ap",
> +					"s5m8767_cp", "s5m8767_bt";
> +		};
> +
> +	};
> +};

[...]

> +&rtc {
> +	status = "okay";
> +	clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>;
> +	clock-names = "rtc", "rtc_src";
> +};

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  parent reply	other threads:[~2016-09-01 13:04 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21 20:04 [PATCH 0/2] Add a new board for exynos 4412 Randy Li
2016-08-21 20:04 ` Randy Li
2016-08-21 20:04 ` Randy Li
2016-08-21 20:04 ` [PATCH 1/2] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
2016-08-21 20:04   ` Randy Li
2016-08-22  6:50   ` Marek Szyprowski
2016-08-22  6:50     ` Marek Szyprowski
2016-08-22  8:28     ` Ayaka
2016-08-22  8:28       ` Ayaka
2016-08-22 14:45       ` Chanwoo Choi
2016-08-22 14:45         ` Chanwoo Choi
2016-08-22 14:49         ` ayaka
2016-08-22 14:49           ` ayaka
2016-08-22 14:18     ` [PATCH 0/2 v2] Add a new board TOPEET iTOP for exynos 4412 Randy Li
2016-08-22 14:18       ` Randy Li
2016-08-22 14:18       ` Randy Li
2016-08-22 14:18       ` [PATCH 1/2] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
2016-08-22 14:18         ` Randy Li
2016-08-22 14:18       ` [PATCH 2/2] ARM: dts: add TOPEET itop elite based board Randy Li
2016-08-22 14:18         ` Randy Li
2016-08-22 18:59         ` kbuild test robot
2016-08-22 18:59           ` kbuild test robot
2016-08-22 18:59           ` kbuild test robot
2016-08-23 18:14         ` Rob Herring
2016-08-23 18:14           ` Rob Herring
2016-08-23 18:36           ` ayaka
2016-08-23 18:36             ` ayaka
2016-08-23 18:36             ` ayaka
2016-08-23 22:38             ` Rob Herring
2016-08-23 22:38               ` Rob Herring
2016-08-23 22:38               ` Rob Herring
2016-08-24  8:29               ` Ayaka
2016-08-24  8:29                 ` Ayaka
2016-08-24  8:29                 ` Ayaka
2016-08-28 11:21               ` [PATCH 0/4 v3] Add a new board TOPEET iTOP for exynos 4412 Randy Li
2016-08-28 11:21                 ` Randy Li
2016-08-28 11:21                 ` Randy Li
2016-08-28 11:21                 ` [PATCH 1/4] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
2016-08-28 11:21                   ` Randy Li
2016-08-28 21:13                   ` Rask Ingemann Lambertsen
2016-08-28 21:13                     ` Rask Ingemann Lambertsen
2016-08-28 21:13                     ` Rask Ingemann Lambertsen
2016-08-30  7:16                   ` Krzysztof Kozlowski
2016-08-30  7:16                     ` Krzysztof Kozlowski
2016-08-31 12:58                     ` [RESEND PATCH 1/3] " Randy Li
2016-08-31 12:58                       ` Randy Li
2016-08-31 18:42                       ` Krzysztof Kozlowski
2016-08-31 18:42                         ` Krzysztof Kozlowski
2016-08-31 18:42                         ` Krzysztof Kozlowski
2016-08-31 19:49                         ` Ayaka
2016-08-31 19:49                           ` Ayaka
2016-08-31 19:49                           ` Ayaka
2016-09-01 13:03                       ` Bartlomiej Zolnierkiewicz [this message]
2016-09-01 13:03                         ` Bartlomiej Zolnierkiewicz
2016-09-01 13:03                         ` Bartlomiej Zolnierkiewicz
2016-09-01 16:12                         ` Krzysztof Kozlowski
2016-09-01 16:12                           ` Krzysztof Kozlowski
2016-09-01 16:12                           ` Krzysztof Kozlowski
2016-08-28 11:21                 ` [PATCH 2/4] ARM: dts: add TOPEET itop elite based board Randy Li
2016-08-28 11:21                   ` Randy Li
2016-08-30  7:32                   ` Krzysztof Kozlowski
2016-08-30  7:32                     ` Krzysztof Kozlowski
2016-08-31 12:59                     ` [RESEND PATCH 2/3] " Randy Li
2016-08-31 12:59                       ` Randy Li
2016-09-01 13:07                       ` Bartlomiej Zolnierkiewicz
2016-09-01 13:07                         ` Bartlomiej Zolnierkiewicz
2016-08-28 11:21                 ` [PATCH 3/4] ARM: dts: add fimc support in exynos4412 TOPEET iTop Elite board Randy Li
2016-08-28 11:21                   ` Randy Li
2016-08-30  7:33                   ` Krzysztof Kozlowski
2016-08-30  7:33                     ` Krzysztof Kozlowski
2016-08-31 13:00                     ` [PATCH 3/3 v3] devicetree: bindings: Add vendor prefix for Topeet Randy Li
2016-08-31 13:00                       ` Randy Li
2016-08-31 13:00                       ` Randy Li
2016-08-28 11:21                 ` [PATCH 4/4] ARM: dts: samsung: add analog audio codec on TOPEET iTop 4412 Elite Randy Li
2016-08-28 11:21                   ` Randy Li
2016-08-28 11:21                   ` Randy Li
2016-08-30  7:35                   ` Krzysztof Kozlowski
2016-08-30  7:35                     ` Krzysztof Kozlowski
2016-08-30  7:04                 ` [PATCH 0/4 v3] Add a new board TOPEET iTOP for exynos 4412 Krzysztof Kozlowski
2016-08-30  7:04                   ` Krzysztof Kozlowski
2016-08-30  7:04                   ` Krzysztof Kozlowski
2016-08-21 20:04 ` [PATCH 2/2] ARM: dts: add TOPEET itop elite based board Randy Li
2016-08-21 20:04   ` Randy Li
2016-08-21 20:04   ` Randy Li
2016-08-21 20:12   ` [PATCH 2/2 v2] " Randy Li
2016-08-21 20:12     ` Randy Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5477278.USWYFxDPfA@amdc1976 \
    --to=b.zolnierkie@samsung.com \
    --cc=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.