All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: <david.vrabel@citrix.com>
Cc: <x86@kernel.org>, <tglx@linutronix.de>,
	"xen-devel" <xen-devel@lists.xenproject.org>,
	<boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>,
	<mingo@redhat.com>, "Juergen Gross" <JGross@suse.com>,
	<mmarek@suse.cz>, <linux-kbuild@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols
Date: Mon, 15 Dec 2014 11:47:09 +0000	[thread overview]
Message-ID: <548ED84D020000780004F8FB@mail.emea.novell.com> (raw)
In-Reply-To: <548EC841.2000107@citrix.com>

>>> On 15.12.14 at 12:38, <david.vrabel@citrix.com> wrote:
> On 11/12/14 18:04, Juergen Gross wrote:
>> --- a/arch/x86/syscalls/Makefile
>> +++ b/arch/x86/syscalls/Makefile
> 
> Why are these changes here and not in arch/x86/xen/Makefile?

Because this needs to be done in a step that (afaict) has no hook
in the Xen-specific Makefile.

>> @@ -47,10 +50,16 @@ $(out)/syscalls_32.h: $(syscall32) $(systbl)
>>  $(out)/syscalls_64.h: $(syscall64) $(systbl)
>>  	$(call if_changed,systbl)
>>  
>> +$(out)/xen-hypercalls.h: $(srctree)/scripts/xen-hypercalls.sh
>> +	$(call if_changed,hypercalls)
>> +
>> +$(out)/xen-hypercalls.h: $(srctree)/include/xen/interface/xen*.h
> 
> The generated header should end up in asm/xen/

Why is generated/asm/ not good enough?

Jan


WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: david.vrabel@citrix.com
Cc: x86@kernel.org, tglx@linutronix.de,
	xen-devel <xen-devel@lists.xenproject.org>,
	boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
	mingo@redhat.com, Juergen Gross <JGross@suse.com>,
	mmarek@suse.cz, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [Xen-devel] [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols
Date: Mon, 15 Dec 2014 11:47:09 +0000	[thread overview]
Message-ID: <548ED84D020000780004F8FB@mail.emea.novell.com> (raw)
In-Reply-To: <548EC841.2000107@citrix.com>

>>> On 15.12.14 at 12:38, <david.vrabel@citrix.com> wrote:
> On 11/12/14 18:04, Juergen Gross wrote:
>> --- a/arch/x86/syscalls/Makefile
>> +++ b/arch/x86/syscalls/Makefile
> 
> Why are these changes here and not in arch/x86/xen/Makefile?

Because this needs to be done in a step that (afaict) has no hook
in the Xen-specific Makefile.

>> @@ -47,10 +50,16 @@ $(out)/syscalls_32.h: $(syscall32) $(systbl)
>>  $(out)/syscalls_64.h: $(syscall64) $(systbl)
>>  	$(call if_changed,systbl)
>>  
>> +$(out)/xen-hypercalls.h: $(srctree)/scripts/xen-hypercalls.sh
>> +	$(call if_changed,hypercalls)
>> +
>> +$(out)/xen-hypercalls.h: $(srctree)/include/xen/interface/xen*.h
> 
> The generated header should end up in asm/xen/

Why is generated/asm/ not good enough?

Jan


  reply	other threads:[~2014-12-15 11:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 18:04 [PATCH 0/4] xen: auto-generate symbols for xen hypercalls Juergen Gross
2014-12-11 18:04 ` [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols Juergen Gross
2014-12-12 22:48   ` Boris Ostrovsky
2014-12-15  5:20     ` Juergen Gross
2014-12-15 10:00     ` [Xen-devel] " Jan Beulich
2014-12-15 10:00       ` Jan Beulich
2014-12-15 10:00     ` Jan Beulich
2014-12-15 11:38   ` [Xen-devel] " David Vrabel
2014-12-15 11:38     ` David Vrabel
2014-12-15 11:47     ` Jan Beulich [this message]
2014-12-15 11:47       ` Jan Beulich
2014-12-16 14:51       ` David Vrabel
2014-12-16 14:51       ` [Xen-devel] " David Vrabel
2014-12-16 14:51         ` David Vrabel
2014-12-15 11:47     ` Jan Beulich
2014-12-16 14:40     ` [Xen-devel] " Juergen Gross
2014-12-11 18:04 ` [PATCH 2/4] xen: synchronize include/xen/interface/xen.h with xen Juergen Gross
2014-12-15 11:45   ` [Xen-devel] " David Vrabel
2014-12-11 18:04 ` [PATCH 3/4] xen: use generated hypervisor symbols in arch/x86/xen/trace.c Juergen Gross
2014-12-15 11:46   ` [Xen-devel] " David Vrabel
2014-12-15 11:46     ` David Vrabel
2014-12-11 18:04 ` [PATCH 4/4] xen: use generated hypercall symbols in arch/x86/xen/xen-head.S Juergen Gross
2014-12-15 12:05   ` [Xen-devel] " David Vrabel
2014-12-15 12:05     ` David Vrabel
2014-12-16  5:55     ` Juergen Gross
2014-12-16 10:24       ` David Vrabel
2014-12-16 10:24         ` David Vrabel
2014-12-16 10:24         ` David Vrabel
2014-12-16 11:20         ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548ED84D020000780004F8FB@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.