All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: devicetree@vger.kernel.org, "Tony Lindgren" <tony@atomide.com>,
	linux-kernel@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
Date: Mon, 05 Jan 2015 06:47:39 -0600	[thread overview]
Message-ID: <54AA87EB.1000004@ti.com> (raw)
In-Reply-To: <20150103233949.GA4108@earth.universe>

On 01/03/2015 05:39 PM, Sebastian Reichel wrote:

> On Sat, Jan 03, 2015 at 12:30:26PM -0600, Nishanth Menon wrote:
>> [...]
>> +		gpio-fan,speed-map = <0    0
>> +				      13000 1>;
>> [...]
>
> iirc DT maintainers prefer this format:
>
> gpio-fan,speed-map = <0     0>,
>                       <13000 1>;
>
> This should result in the same .dtb, but is a bit easier to read.
>
yes indeed.. :( Thanks for catching it. will repost.

Regards,
Nishanth Menon


WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node
Date: Mon, 05 Jan 2015 06:47:39 -0600	[thread overview]
Message-ID: <54AA87EB.1000004@ti.com> (raw)
In-Reply-To: <20150103233949.GA4108@earth.universe>

On 01/03/2015 05:39 PM, Sebastian Reichel wrote:

> On Sat, Jan 03, 2015 at 12:30:26PM -0600, Nishanth Menon wrote:
>> [...]
>> +		gpio-fan,speed-map = <0    0
>> +				      13000 1>;
>> [...]
>
> iirc DT maintainers prefer this format:
>
> gpio-fan,speed-map = <0     0>,
>                       <13000 1>;
>
> This should result in the same .dtb, but is a bit easier to read.
>
yes indeed.. :( Thanks for catching it. will repost.

Regards,
Nishanth Menon

  reply	other threads:[~2015-01-05 12:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-03 18:30 [PATCH V3] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node Nishanth Menon
2015-01-03 18:30 ` Nishanth Menon
2015-01-03 18:30 ` Nishanth Menon
2015-01-03 23:39 ` Sebastian Reichel
2015-01-03 23:39   ` Sebastian Reichel
2015-01-05 12:47   ` Nishanth Menon [this message]
2015-01-05 12:47     ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AA87EB.1000004@ti.com \
    --to=nm@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.