From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: sh: fsi: Fix clock inversion
Date: Mon, 19 Jan 2015 12:23:38 +0000 [thread overview]
Message-ID: <54BCF74A.10106@cogentembedded.com> (raw)
In-Reply-To: <1421661297-19654-2-git-send-email-lars@metafoo.de>
Hello.
On 1/19/2015 12:54 PM, Lars-Peter Clausen wrote:
> According to the sh7724 hardware user manual (Rev.2.00 Jan 2013) page 1851
> to 1856 the FSI bit-clock is inverted to the bit-clock as specified by the
> I2S standard. This means the bit clock inversion bit should be set for a
> normal I2S clock and should not be set for an inverted I2S clock.
> Similarly when operating in left-justified mode both the frame-clock and the
> bit-clock need to be inverted to be standards compliant.
> This means also that the extra clock inversion setting in the
> armadillo800eva machine driver for CPU component should now be removed.
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
[...]
> diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
> index b87b22e..dfb17f6 100644
> --- a/sound/soc/sh/fsi.c
> +++ b/sound/soc/sh/fsi.c
> @@ -1594,6 +1594,12 @@ static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
>
> static int fsi_set_fmt_dai(struct fsi_priv *fsi, unsigned int fmt)
> {
> + /*
> + * FSI bit clock is inverted to the I2S specification, so we invert it
> + * when a non-inverted I2S clock was requested and vice versa.
> + */
> + fsi->bit_clk_inv = !fsi->bit_clk_inv;
One space too many here. :-)
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: sh: fsi: Fix clock inversion
Date: Mon, 19 Jan 2015 15:23:38 +0300 [thread overview]
Message-ID: <54BCF74A.10106@cogentembedded.com> (raw)
In-Reply-To: <1421661297-19654-2-git-send-email-lars@metafoo.de>
Hello.
On 1/19/2015 12:54 PM, Lars-Peter Clausen wrote:
> According to the sh7724 hardware user manual (Rev.2.00 Jan 2013) page 1851
> to 1856 the FSI bit-clock is inverted to the bit-clock as specified by the
> I2S standard. This means the bit clock inversion bit should be set for a
> normal I2S clock and should not be set for an inverted I2S clock.
> Similarly when operating in left-justified mode both the frame-clock and the
> bit-clock need to be inverted to be standards compliant.
> This means also that the extra clock inversion setting in the
> armadillo800eva machine driver for CPU component should now be removed.
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
[...]
> diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
> index b87b22e..dfb17f6 100644
> --- a/sound/soc/sh/fsi.c
> +++ b/sound/soc/sh/fsi.c
> @@ -1594,6 +1594,12 @@ static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
>
> static int fsi_set_fmt_dai(struct fsi_priv *fsi, unsigned int fmt)
> {
> + /*
> + * FSI bit clock is inverted to the I2S specification, so we invert it
> + * when a non-inverted I2S clock was requested and vice versa.
> + */
> + fsi->bit_clk_inv = !fsi->bit_clk_inv;
One space too many here. :-)
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ASoC: sh: fsi: Fix clock inversion
Date: Mon, 19 Jan 2015 15:23:38 +0300 [thread overview]
Message-ID: <54BCF74A.10106@cogentembedded.com> (raw)
In-Reply-To: <1421661297-19654-2-git-send-email-lars@metafoo.de>
Hello.
On 1/19/2015 12:54 PM, Lars-Peter Clausen wrote:
> According to the sh7724 hardware user manual (Rev.2.00 Jan 2013) page 1851
> to 1856 the FSI bit-clock is inverted to the bit-clock as specified by the
> I2S standard. This means the bit clock inversion bit should be set for a
> normal I2S clock and should not be set for an inverted I2S clock.
> Similarly when operating in left-justified mode both the frame-clock and the
> bit-clock need to be inverted to be standards compliant.
> This means also that the extra clock inversion setting in the
> armadillo800eva machine driver for CPU component should now be removed.
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
[...]
> diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
> index b87b22e..dfb17f6 100644
> --- a/sound/soc/sh/fsi.c
> +++ b/sound/soc/sh/fsi.c
> @@ -1594,6 +1594,12 @@ static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
>
> static int fsi_set_fmt_dai(struct fsi_priv *fsi, unsigned int fmt)
> {
> + /*
> + * FSI bit clock is inverted to the I2S specification, so we invert it
> + * when a non-inverted I2S clock was requested and vice versa.
> + */
> + fsi->bit_clk_inv = !fsi->bit_clk_inv;
One space too many here. :-)
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-01-19 12:23 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 23:18 [GIT PULL] Renesas ARM-based SoC fix for v3.6 Rafael J. Wysocki
2012-08-23 23:18 ` Rafael J. Wysocki
2012-08-27 23:33 ` Olof Johansson
2012-08-27 23:33 ` Olof Johansson
2012-08-30 5:38 ` Simon Horman
2012-08-30 5:38 ` Simon Horman
2012-08-30 5:38 ` [PATCH] ARM: shmobile: marzen: fixup smsc911x id for regulator Simon Horman
2012-08-30 5:38 ` Simon Horman
2012-09-02 15:23 ` [GIT PULL] Renesas ARM-based SoC fix for v3.6 Olof Johansson
2012-09-02 15:23 ` Olof Johansson
2012-09-05 1:34 ` [GIT PULL] Renesas ARM-based SoC fix for v3.6 #2 Simon Horman
2012-09-05 1:34 ` Simon Horman
2012-09-05 1:34 ` [PATCH 1/3] ARM: shmobile: armadillo800eva: fixup: sound card detection order Simon Horman
2012-09-05 1:34 ` Simon Horman
2013-02-22 4:45 ` [PATCH 1/3] ARM: shmobile: armadillo800eva: enable all errata for cache on defconfig Kuninori Morimoto
2013-02-22 22:58 ` Simon Horman
2013-03-01 6:53 ` Simon Horman
2013-03-01 10:01 ` Kuninori Morimoto
2013-03-01 13:02 ` Simon Horman
2013-03-04 0:42 ` Kuninori Morimoto
2013-03-05 5:57 ` Simon Horman
2013-03-06 4:46 ` Simon Horman
2015-01-19 9:54 ` [PATCH 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format Lars-Peter Clausen
2015-01-19 9:54 ` Lars-Peter Clausen
2015-01-19 9:54 ` Lars-Peter Clausen
2015-01-19 9:54 ` [PATCH 2/3] ASoC: sh: fsi: Fix clock inversion Lars-Peter Clausen
2015-01-19 9:54 ` Lars-Peter Clausen
2015-01-19 9:54 ` Lars-Peter Clausen
2015-01-19 12:23 ` Sergei Shtylyov [this message]
2015-01-19 12:23 ` Sergei Shtylyov
2015-01-19 12:23 ` Sergei Shtylyov
2015-01-19 9:54 ` [PATCH 3/3] ASoC: simple-card: Remove support for setting differing DAI formats Lars-Peter Clausen
2015-01-19 9:54 ` Lars-Peter Clausen
2015-01-19 9:54 ` Lars-Peter Clausen
2015-01-20 0:11 ` Kuninori Morimoto
2015-01-20 0:11 ` Kuninori Morimoto
2012-09-05 1:34 ` [PATCH 2/3] ARM: shmobile: mackerel: fixup usb module order Simon Horman
2012-09-05 1:34 ` Simon Horman
2012-09-05 1:34 ` [PATCH 3/3] ARM: shmobile: armadillo800eva: enable rw rootfs mount Simon Horman
2012-09-05 1:34 ` Simon Horman
2013-02-22 4:46 ` [PATCH 3/3] ARM: shmobile: armadillo800eva: enable NEON on defconfig Kuninori Morimoto
2013-02-22 23:09 ` Simon Horman
2013-02-25 0:17 ` Kuninori Morimoto
2013-02-25 0:21 ` Kiyoshi Ishiyama
2013-03-01 9:41 ` Simon Horman
2012-09-05 4:44 ` [GIT PULL] Renesas ARM-based SoC fix for v3.6 #2 Olof Johansson
2012-09-05 4:44 ` Olof Johansson
2012-09-05 4:53 ` Simon Horman
2012-09-05 4:53 ` Simon Horman
2012-09-18 4:46 ` [GIT PULL] Renesas ARM-based SoC fix for v3.6 #3 Simon Horman
2012-09-18 4:46 ` Simon Horman
2012-09-18 4:46 ` [PATCH] ARM: shmobile: kzm9g: bugfix: correct mmcif interrupt settings Simon Horman
2012-09-18 4:46 ` Simon Horman
2012-09-18 14:41 ` [GIT PULL] Renesas ARM-based SoC fix for v3.6 #3 Olof Johansson
2012-09-18 14:41 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BCF74A.10106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.