From: Lars-Peter Clausen <lars@metafoo.de>
To: "Ricardo Ribalda Delgado" <ricardo.ribalda@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] spi/xilinx: Use automatic bus number on device tree
Date: Wed, 21 Jan 2015 17:02:41 +0100 [thread overview]
Message-ID: <54BFCDA1.4060205@metafoo.de> (raw)
In-Reply-To: <1421855590-9210-2-git-send-email-ricardo.ribalda@gmail.com>
On 01/21/2015 04:53 PM, Ricardo Ribalda Delgado wrote:
> If there is more than one spi device on a device tree, the second one
> will fail to probe due to a duplicated bus_num.
> [...]
This should already be fixed. See commit 4b153a2137c5 ("spi: xilinx: Use
pdev->id instead of pdev->dev.id for the SPI bus number")[1]. If the device
was registered using devicetree pdev->id is -1, so dynamic numbers will be used.
- Lars
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/spi/spi-xilinx.c?id=4b153a2137c5d2914794c8944d78c731c1b0ae9d
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] spi/xilinx: Use automatic bus number on device tree
Date: Wed, 21 Jan 2015 17:02:41 +0100 [thread overview]
Message-ID: <54BFCDA1.4060205@metafoo.de> (raw)
In-Reply-To: <1421855590-9210-2-git-send-email-ricardo.ribalda@gmail.com>
On 01/21/2015 04:53 PM, Ricardo Ribalda Delgado wrote:
> If there is more than one spi device on a device tree, the second one
> will fail to probe due to a duplicated bus_num.
> [...]
This should already be fixed. See commit 4b153a2137c5 ("spi: xilinx: Use
pdev->id instead of pdev->dev.id for the SPI bus number")[1]. If the device
was registered using devicetree pdev->id is -1, so dynamic numbers will be used.
- Lars
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/spi/spi-xilinx.c?id=4b153a2137c5d2914794c8944d78c731c1b0ae9d
next prev parent reply other threads:[~2015-01-21 16:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 15:53 [PATCH 0/3] xilinx-spi: Support more spi modes and multiple device tree Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
2015-01-21 15:53 ` [PATCH 1/3] spi/xilinx: Use automatic bus number on " Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
2015-01-21 16:02 ` Lars-Peter Clausen [this message]
2015-01-21 16:02 ` Lars-Peter Clausen
2015-01-21 16:51 ` Ricardo Ribalda Delgado
2015-01-21 16:51 ` Ricardo Ribalda Delgado
2015-01-21 16:51 ` Ricardo Ribalda Delgado
2015-01-21 15:53 ` [PATCH 2/3] spi/xilinx: Support for spi mode LSB_FIRST Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
2015-01-21 15:53 ` [PATCH 3/3] spi/xilinx: Support for spi mode LOOP Ricardo Ribalda Delgado
2015-01-21 15:53 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BFCDA1.4060205@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ricardo.ribalda@gmail.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.