From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ricardo Ribalda Delgado" <ricardo.ribalda@gmail.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Minghsiu Tsai" <minghsiu.tsai@mediatek.com>,
"Houlong Wei" <houlong.wei@mediatek.com>,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Tiffany Lin" <tiffany.lin@mediatek.com>,
"Yunfei Dong" <yunfei.dong@mediatek.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Pi-Hsun Shih" <pihsun@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] media: mediatek: vcodec: avoid -Wcast-function-type-strict warning
Date: Tue, 27 Feb 2024 13:30:07 +0100 [thread overview]
Message-ID: <54dcfb0c-9861-4abb-8a1f-83b5d1722ca8@app.fastmail.com> (raw)
In-Reply-To: <CAPybu_2JoNfr158FXqYGUV=JuTW8i85XM6cf7K40_xZe9m2qyg@mail.gmail.com>
On Tue, Feb 27, 2024, at 12:38, Ricardo Ribalda Delgado wrote:
> On Sat, Feb 24, 2024 at 1:11 PM Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The ipi handler here tries hard to maintain const-ness of its argument,
>> but by doing that causes a warning about function type casts:
>
> I worked on the same issue, but in instead of removing the const, I
> tried to constify everything:
> https://patchwork.linuxtv.org/project/linux-media/patch/20240226-fix-clang-warnings-v2-3-fa1bc931d17e@chromium.org/
I had almost the same patch originally but ended up not sending
it because I could not figure out what to do about
typedef int (*rpmsg_rx_cb_t)(struct rpmsg_device *, void *, int, void *, u32);
which is a generic part of rpmsg that takes a non-const pointer
and gets called by mtk_rpmsg_ipi_handler(), which would now
get a const pointer.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ricardo Ribalda Delgado" <ricardo.ribalda@gmail.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Minghsiu Tsai" <minghsiu.tsai@mediatek.com>,
"Houlong Wei" <houlong.wei@mediatek.com>,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Tiffany Lin" <tiffany.lin@mediatek.com>,
"Yunfei Dong" <yunfei.dong@mediatek.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Pi-Hsun Shih" <pihsun@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] media: mediatek: vcodec: avoid -Wcast-function-type-strict warning
Date: Tue, 27 Feb 2024 13:30:07 +0100 [thread overview]
Message-ID: <54dcfb0c-9861-4abb-8a1f-83b5d1722ca8@app.fastmail.com> (raw)
In-Reply-To: <CAPybu_2JoNfr158FXqYGUV=JuTW8i85XM6cf7K40_xZe9m2qyg@mail.gmail.com>
On Tue, Feb 27, 2024, at 12:38, Ricardo Ribalda Delgado wrote:
> On Sat, Feb 24, 2024 at 1:11 PM Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The ipi handler here tries hard to maintain const-ness of its argument,
>> but by doing that causes a warning about function type casts:
>
> I worked on the same issue, but in instead of removing the const, I
> tried to constify everything:
> https://patchwork.linuxtv.org/project/linux-media/patch/20240226-fix-clang-warnings-v2-3-fa1bc931d17e@chromium.org/
I had almost the same patch originally but ended up not sending
it because I could not figure out what to do about
typedef int (*rpmsg_rx_cb_t)(struct rpmsg_device *, void *, int, void *, u32);
which is a generic part of rpmsg that takes a non-const pointer
and gets called by mtk_rpmsg_ipi_handler(), which would now
get a const pointer.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-27 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 12:10 [PATCH] media: mediatek: vcodec: avoid -Wcast-function-type-strict warning Arnd Bergmann
2024-02-24 12:10 ` Arnd Bergmann
2024-02-27 11:38 ` Ricardo Ribalda Delgado
2024-02-27 11:38 ` Ricardo Ribalda Delgado
2024-02-27 12:30 ` Arnd Bergmann [this message]
2024-02-27 12:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54dcfb0c-9861-4abb-8a1f-83b5d1722ca8@app.fastmail.com \
--to=arnd@arndb.de \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@kernel.org \
--cc=houlong.wei@mediatek.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=nicolas.dufresne@collabora.com \
--cc=pihsun@chromium.org \
--cc=ricardo.ribalda@gmail.com \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.