Re: [PATCH 1/5] clk: mediatek: Add initial common clock support for Mediatek SoCs.

From: Matthias Brugger <matthias.bgg@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	YH Chen <yh.chen@mediatek.com>,
	kernel@pengutronix.de, Yingjoe Chen <Yingjoe.Chen@mediatek.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Henry Chen <henryc.chen@mediatek.com>,
	James Liao <jamesjj.liao@mediatek.com>
Subject: Re: [PATCH 1/5] clk: mediatek: Add initial common clock support for Mediatek SoCs.
Date: Fri, 13 Mar 2015 17:46:32 +0100	[thread overview]
Message-ID: <55031468.2040109@gmail.com> (raw)
In-Reply-To: <1424605765-19751-2-git-send-email-s.hauer@pengutronix.de>

On 22/02/15 12:49, Sascha Hauer wrote:
> From: James Liao <jamesjj.liao@mediatek.com>

> diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h
> new file mode 100644
> index 0000000..c7c0d35
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mtk.h

[...]

> +void __init mtk_clk_register_plls(struct device_node *node,
> +		const struct mtk_pll_data *plls, int num_plls);
> +
> +#ifdef CONFIG_RESET_CONTROLLER
> +void mtk_register_reset_controller(struct device_node *np,
> +			unsigned int num_regs, int regofs);
> +#else
> +static inline void mtk_register_reset_controller(struct device_node *np,
> +			unsigned int num_regs, int regofs)
> +{
> +}
> +#endif

This lines should only be added once in [2/5], compiling ends with:

In file included from drivers/clk/mediatek/clk-mtk.c:24:0:
drivers/clk/mediatek/clk-mtk.h:168:20: error: redefinition of ‘mtk_register_reset_controller’
drivers/clk/mediatek/clk-mtk.h:158:20: note: previous definition of ‘mtk_register_reset_controller’ was here

Cheers,
Matthias