From: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
PJ Waskiewicz
<pj.waskiewicz-PrFOU5CTvK1l57MIdRCFDg@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Tatyana Nikolova
<Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Yan Burman <yanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>,
Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
Colin Ian King
<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>,
Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Eugenia Emantayev
<eugenia-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 1/2] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Wed, 25 Mar 2015 12:12:50 +0100 [thread overview]
Message-ID: <55129832.2070707@profitbricks.com> (raw)
There are too many lengthy code to check the transport type of IB device,
or the link layer type of it's port, this patch set try to use some
helper to
refine and save us some code.
TODO:
Currently we inferred from the transport type and link layer type
to identify
the way of management, it will be better if we can directly get the
indicator
from vendor.
Sean proposed one suggestion:
https://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg23339.html
It may need a big work to adapt current implementation to utilize
these flags elegantly.
Also the performance concern on query_port() need to be addressed,
may be
some new callback like query_mgmt() could works.
Michael Wang (2):
[PATCH 1/2] IB/Verbs: Use helpers to check transport and link layer
[PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology
---
drivers/infiniband/core/agent.c | 2 -
drivers/infiniband/core/cm.c | 2 -
drivers/infiniband/core/cma.c | 33
++++++++++++------------------
drivers/infiniband/core/mad.c | 6 ++---
drivers/infiniband/core/multicast.c | 11 +++-------
drivers/infiniband/core/sa_query.c | 14 ++++++------
drivers/infiniband/core/ucm.c | 3 --
drivers/infiniband/core/user_mad.c | 2 -
drivers/infiniband/core/verbs.c | 5 +---
drivers/infiniband/hw/mlx4/ah.c | 2 -
drivers/infiniband/hw/mlx4/cq.c | 4 ---
drivers/infiniband/hw/mlx4/mad.c | 14 +++---------
drivers/infiniband/hw/mlx4/main.c | 8 ++-----
drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 -
drivers/infiniband/hw/mlx4/qp.c | 21 ++++++-------------
drivers/infiniband/hw/mlx4/sysfs.c | 6 +----
drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 ++---
include/rdma/ib_verbs.h | 30
+++++++++++++++++++++++++++
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 --
19 files changed, 87 insertions(+), 87 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
Ira Weiny <ira.weiny@intel.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
"David S. Miller" <davem@davemloft.net>,
Moni Shoua <monis@mellanox.com>,
PJ Waskiewicz <pj.waskiewicz@solidfire.com>,
Steve Wise <swise@opengridcomputing.com>,
Tatyana Nikolova <Tatyana.E.Nikolova@intel.com>,
Yan Burman <yanb@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Yann Droneaud <ydroneaud@opteya.com>,
Bart Van Assche <bvanassche@acm.org>,
Colin Ian King <colin.king@canonical.com>,
Mel Gorman <mgorman@suse.de>, Majd Dibbiny <majd@mellanox.com>,
Jiri Kosina <jkosina@suse.cz>, Matan Barak <matanb@mellanox.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Eugenia Emantayev <eugenia@mellanox.co.il>,
Doug Ledford <dledford@redhat.com>,
Alex Estrin <alex.estrin@intel.com>,
Erez Shitrit <erezsh@mellanox.com>,
Eric Dumazet <edumazet@google.com>, Tom Gundersen <teg@jklm.no>,
Sagi Grimberg <sagig@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
Shachar Raindel <raindel@mellanox.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Tom Tucker <tom@ogc.us>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH 1/2] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Wed, 25 Mar 2015 12:12:50 +0100 [thread overview]
Message-ID: <55129832.2070707@profitbricks.com> (raw)
There are too many lengthy code to check the transport type of IB device,
or the link layer type of it's port, this patch set try to use some
helper to
refine and save us some code.
TODO:
Currently we inferred from the transport type and link layer type
to identify
the way of management, it will be better if we can directly get the
indicator
from vendor.
Sean proposed one suggestion:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html
It may need a big work to adapt current implementation to utilize
these flags elegantly.
Also the performance concern on query_port() need to be addressed,
may be
some new callback like query_mgmt() could works.
Michael Wang (2):
[PATCH 1/2] IB/Verbs: Use helpers to check transport and link layer
[PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology
---
drivers/infiniband/core/agent.c | 2 -
drivers/infiniband/core/cm.c | 2 -
drivers/infiniband/core/cma.c | 33
++++++++++++------------------
drivers/infiniband/core/mad.c | 6 ++---
drivers/infiniband/core/multicast.c | 11 +++-------
drivers/infiniband/core/sa_query.c | 14 ++++++------
drivers/infiniband/core/ucm.c | 3 --
drivers/infiniband/core/user_mad.c | 2 -
drivers/infiniband/core/verbs.c | 5 +---
drivers/infiniband/hw/mlx4/ah.c | 2 -
drivers/infiniband/hw/mlx4/cq.c | 4 ---
drivers/infiniband/hw/mlx4/mad.c | 14 +++---------
drivers/infiniband/hw/mlx4/main.c | 8 ++-----
drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 -
drivers/infiniband/hw/mlx4/qp.c | 21 ++++++-------------
drivers/infiniband/hw/mlx4/sysfs.c | 6 +----
drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 ++---
include/rdma/ib_verbs.h | 30
+++++++++++++++++++++++++++
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 --
19 files changed, 87 insertions(+), 87 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
PJ Waskiewicz
<pj.waskiewicz-PrFOU5CTvK1l57MIdRCFDg@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Tatyana Nikolova
<Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Yan Burman <yanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>,
Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
Colin Ian King
<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>,
Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Eugenia Emantayev
<eugenia-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Tom Gundersen <
Subject: [PATCH 1/2] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Wed, 25 Mar 2015 12:12:50 +0100 [thread overview]
Message-ID: <55129832.2070707@profitbricks.com> (raw)
There are too many lengthy code to check the transport type of IB device,
or the link layer type of it's port, this patch set try to use some
helper to
refine and save us some code.
TODO:
Currently we inferred from the transport type and link layer type
to identify
the way of management, it will be better if we can directly get the
indicator
from vendor.
Sean proposed one suggestion:
https://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg23339.html
It may need a big work to adapt current implementation to utilize
these flags elegantly.
Also the performance concern on query_port() need to be addressed,
may be
some new callback like query_mgmt() could works.
Michael Wang (2):
[PATCH 1/2] IB/Verbs: Use helpers to check transport and link layer
[PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology
---
drivers/infiniband/core/agent.c | 2 -
drivers/infiniband/core/cm.c | 2 -
drivers/infiniband/core/cma.c | 33
++++++++++++------------------
drivers/infiniband/core/mad.c | 6 ++---
drivers/infiniband/core/multicast.c | 11 +++-------
drivers/infiniband/core/sa_query.c | 14 ++++++------
drivers/infiniband/core/ucm.c | 3 --
drivers/infiniband/core/user_mad.c | 2 -
drivers/infiniband/core/verbs.c | 5 +---
drivers/infiniband/hw/mlx4/ah.c | 2 -
drivers/infiniband/hw/mlx4/cq.c | 4 ---
drivers/infiniband/hw/mlx4/mad.c | 14 +++---------
drivers/infiniband/hw/mlx4/main.c | 8 ++-----
drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 -
drivers/infiniband/hw/mlx4/qp.c | 21 ++++++-------------
drivers/infiniband/hw/mlx4/sysfs.c | 6 +----
drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 ++---
include/rdma/ib_verbs.h | 30
+++++++++++++++++++++++++++
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 --
19 files changed, 87 insertions(+), 87 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2015-03-25 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 11:12 Michael Wang [this message]
2015-03-25 11:12 ` [PATCH 1/2] IB/Verbs: Use helpers to refine the checking on transport and link layer Michael Wang
2015-03-25 11:12 ` Michael Wang
2015-03-25 11:14 ` [PATCH 1/2] IB/Verbs: Use helpers to check " Michael Wang
2015-03-25 11:14 ` Michael Wang
2015-03-25 11:14 ` Michael Wang
[not found] ` <55129832.2070707-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-03-25 11:16 ` [PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology Michael Wang
2015-03-25 11:16 ` Michael Wang
2015-03-25 11:16 ` Michael Wang
2015-03-25 11:19 ` [PATCH 1/2] IB/Verbs: Use helpers to refine the checking on transport and link layer Michael Wang
2015-03-25 11:19 ` Michael Wang
2015-03-25 11:19 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55129832.2070707@profitbricks.com \
--to=yun.wang-eikl63zcoxah+58jc4qpia@public.gmane.org \
--cc=Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=eugenia-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=mgorman-l3A5Bk7waGM@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pj.waskiewicz-PrFOU5CTvK1l57MIdRCFDg@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
--cc=trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
--cc=yanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.