From: Lars-Peter Clausen <lars@metafoo.de> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Simon <horms@verge.net.au>, Linux-SH <linux-sh@vger.kernel.org> Subject: Re: [alsa-devel] [PATCH 3/3] ASoC: simple-card: Remove support for setting differing DAI formats Date: Fri, 10 Apr 2015 09:25:58 +0000 [thread overview] Message-ID: <55279726.7090208@metafoo.de> (raw) In-Reply-To: <87vbh4730i.wl%kuninori.morimoto.gx@renesas.com> On 04/10/2015 11:21 AM, Kuninori Morimoto wrote: > This means we can put it under soc_probe_link_dais() > I can send formal patch if this is OK. Looks perfect. > > # But, I wonder what is good explain about this patch ... > # indeed I noticed this issue from > # 1efb53a220b78fdfdbb97b726a2156713e75bdab > # (ASoC: simple-card: Remove support for setting differing DAI formats) > # but, it is simple-card user only... > > -------- > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 76bfff2..9777e78 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -1324,6 +1324,9 @@ static int soc_probe_link_dais(struct snd_soc_card *card, int num, int order) > } > } > > + if (dai_link->dai_fmt) > + snd_soc_runtime_set_dai_fmt(rtd, dai_link->dai_fmt); > + > ret = soc_post_component_init(rtd, dai_link->name); > if (ret) > return ret; > @@ -1642,12 +1645,6 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card) > snd_soc_dapm_add_routes(&card->dapm, card->of_dapm_routes, > card->num_of_dapm_routes); > > - for (i = 0; i < card->num_links; i++) { > - if (card->dai_link[i].dai_fmt) > - snd_soc_runtime_set_dai_fmt(&card->rtd[i], > - card->dai_link[i].dai_fmt); > - } > - > snprintf(card->snd_card->shortname, sizeof(card->snd_card->shortname), > "%s", card->name); > snprintf(card->snd_card->longname, sizeof(card->snd_card->longname), > --------- > > Best regards > --- > Kuninori Morimoto > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Simon <horms@verge.net.au>, Linux-SH <linux-sh@vger.kernel.org> Subject: Re: [PATCH 3/3] ASoC: simple-card: Remove support for setting differing DAI formats Date: Fri, 10 Apr 2015 11:25:58 +0200 [thread overview] Message-ID: <55279726.7090208@metafoo.de> (raw) In-Reply-To: <87vbh4730i.wl%kuninori.morimoto.gx@renesas.com> On 04/10/2015 11:21 AM, Kuninori Morimoto wrote: > This means we can put it under soc_probe_link_dais() > I can send formal patch if this is OK. Looks perfect. > > # But, I wonder what is good explain about this patch ... > # indeed I noticed this issue from > # 1efb53a220b78fdfdbb97b726a2156713e75bdab > # (ASoC: simple-card: Remove support for setting differing DAI formats) > # but, it is simple-card user only... > > -------- > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 76bfff2..9777e78 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -1324,6 +1324,9 @@ static int soc_probe_link_dais(struct snd_soc_card *card, int num, int order) > } > } > > + if (dai_link->dai_fmt) > + snd_soc_runtime_set_dai_fmt(rtd, dai_link->dai_fmt); > + > ret = soc_post_component_init(rtd, dai_link->name); > if (ret) > return ret; > @@ -1642,12 +1645,6 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card) > snd_soc_dapm_add_routes(&card->dapm, card->of_dapm_routes, > card->num_of_dapm_routes); > > - for (i = 0; i < card->num_links; i++) { > - if (card->dai_link[i].dai_fmt) > - snd_soc_runtime_set_dai_fmt(&card->rtd[i], > - card->dai_link[i].dai_fmt); > - } > - > snprintf(card->snd_card->shortname, sizeof(card->snd_card->shortname), > "%s", card->name); > snprintf(card->snd_card->longname, sizeof(card->snd_card->longname), > --------- > > Best regards > --- > Kuninori Morimoto > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
next prev parent reply other threads:[~2015-04-10 9:25 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-24 1:05 [PATCH 0/3] ARM: shmobile: armadillo: fixup CPU settings Kuninori Morimoto 2015-03-24 1:06 ` [PATCH 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format Kuninori Morimoto 2015-03-24 1:06 ` [PATCH 2/3] ARM: shmobile: armadillo800eva: fix clock inversion Kuninori Morimoto 2015-03-24 1:07 ` [PATCH 3/3] ASoC: simple-card: Remove support for setting differing DAI formats Kuninori Morimoto 2015-03-24 1:07 ` Kuninori Morimoto 2015-04-10 7:15 ` Kuninori Morimoto 2015-04-10 8:52 ` [alsa-devel] " Lars-Peter Clausen 2015-04-10 8:52 ` Lars-Peter Clausen 2015-04-10 9:21 ` [alsa-devel] " Kuninori Morimoto 2015-04-10 9:25 ` Lars-Peter Clausen [this message] 2015-04-10 9:25 ` Lars-Peter Clausen 2015-03-26 17:36 ` [PATCH 0/3] ARM: shmobile: armadillo: fixup CPU settings Mark Brown 2015-03-26 17:36 ` Mark Brown 2015-03-27 0:55 ` Simon Horman 2015-03-27 0:55 ` Simon Horman 2015-03-27 1:35 ` Mark Brown 2015-03-27 1:35 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55279726.7090208@metafoo.de \ --to=lars@metafoo.de \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=horms@verge.net.au \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=lgirdwood@gmail.com \ --cc=linux-sh@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.