From: Neil Armstrong <narmstrong@baylibre.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-amlogic@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org, sboyd@codeaurora.org,
mturquette@baylibre.com
Subject: Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver
Date: Tue, 16 Aug 2016 15:35:09 +0200 [thread overview]
Message-ID: <5529118a-63f0-cb54-f6a4-305603da168f@baylibre.com> (raw)
In-Reply-To: <CAP=VYLphcuq16vDueOOJ6anrW-ifYAK+1ijSjkGbxw48+m4xrw@mail.gmail.com>
On 08/15/2016 02:08 AM, Paul Gortmaker wrote:
> On Tue, Aug 9, 2016 at 5:13 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> Adds a Clock and Reset controller driver for the Always-On part
>> of the Amlogic Meson GXBB SoC.
>>
>> It exports paired Clocks and Resets lines that will be used by
>> peripherals in the Always-On subsystem.
>
> [...]
>
>> +static const struct of_device_id gxbb_aoclkc_match_table[] = {
>> + { .compatible = "amlogic,gxbb-aoclkc" },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
>> +
>> +static struct platform_driver gxbb_aoclkc_driver = {
>> + .probe = gxbb_aoclkc_probe,
>> + .driver = {
>> + .name = "gxbb-aoclkc",
>> + .of_match_table = gxbb_aoclkc_match_table,
>> + },
>> +};
>> +
>> +module_platform_driver(gxbb_aoclkc_driver);
>> +
>> +MODULE_DESCRIPTION("AmLogic Meson GXBB AO Clock Controller Driver");
>> +MODULE_LICENSE("Dual BSD/GPL");
>> +MODULE_ALIAS("platform:gxbb-aoclkc");
>> +MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
>
> Since this driver is controlled by a bool Kconfig, you can dump the module.h
> include and all the MODULE_<xyz> tags above.
>
> Or, if there is a genuine use case for it to be modular, then make it tristate?
>
> Thanks,
> Paul.
>
It will be non-modular.
Thanks,
Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver
Date: Tue, 16 Aug 2016 15:35:09 +0200 [thread overview]
Message-ID: <5529118a-63f0-cb54-f6a4-305603da168f@baylibre.com> (raw)
In-Reply-To: <CAP=VYLphcuq16vDueOOJ6anrW-ifYAK+1ijSjkGbxw48+m4xrw@mail.gmail.com>
On 08/15/2016 02:08 AM, Paul Gortmaker wrote:
> On Tue, Aug 9, 2016 at 5:13 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> Adds a Clock and Reset controller driver for the Always-On part
>> of the Amlogic Meson GXBB SoC.
>>
>> It exports paired Clocks and Resets lines that will be used by
>> peripherals in the Always-On subsystem.
>
> [...]
>
>> +static const struct of_device_id gxbb_aoclkc_match_table[] = {
>> + { .compatible = "amlogic,gxbb-aoclkc" },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
>> +
>> +static struct platform_driver gxbb_aoclkc_driver = {
>> + .probe = gxbb_aoclkc_probe,
>> + .driver = {
>> + .name = "gxbb-aoclkc",
>> + .of_match_table = gxbb_aoclkc_match_table,
>> + },
>> +};
>> +
>> +module_platform_driver(gxbb_aoclkc_driver);
>> +
>> +MODULE_DESCRIPTION("AmLogic Meson GXBB AO Clock Controller Driver");
>> +MODULE_LICENSE("Dual BSD/GPL");
>> +MODULE_ALIAS("platform:gxbb-aoclkc");
>> +MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
>
> Since this driver is controlled by a bool Kconfig, you can dump the module.h
> include and all the MODULE_<xyz> tags above.
>
> Or, if there is a genuine use case for it to be modular, then make it tristate?
>
> Thanks,
> Paul.
>
It will be non-modular.
Thanks,
Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver
Date: Tue, 16 Aug 2016 15:35:09 +0200 [thread overview]
Message-ID: <5529118a-63f0-cb54-f6a4-305603da168f@baylibre.com> (raw)
In-Reply-To: <CAP=VYLphcuq16vDueOOJ6anrW-ifYAK+1ijSjkGbxw48+m4xrw@mail.gmail.com>
On 08/15/2016 02:08 AM, Paul Gortmaker wrote:
> On Tue, Aug 9, 2016 at 5:13 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> Adds a Clock and Reset controller driver for the Always-On part
>> of the Amlogic Meson GXBB SoC.
>>
>> It exports paired Clocks and Resets lines that will be used by
>> peripherals in the Always-On subsystem.
>
> [...]
>
>> +static const struct of_device_id gxbb_aoclkc_match_table[] = {
>> + { .compatible = "amlogic,gxbb-aoclkc" },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, gxbb_aoclkc_match_table);
>> +
>> +static struct platform_driver gxbb_aoclkc_driver = {
>> + .probe = gxbb_aoclkc_probe,
>> + .driver = {
>> + .name = "gxbb-aoclkc",
>> + .of_match_table = gxbb_aoclkc_match_table,
>> + },
>> +};
>> +
>> +module_platform_driver(gxbb_aoclkc_driver);
>> +
>> +MODULE_DESCRIPTION("AmLogic Meson GXBB AO Clock Controller Driver");
>> +MODULE_LICENSE("Dual BSD/GPL");
>> +MODULE_ALIAS("platform:gxbb-aoclkc");
>> +MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
>
> Since this driver is controlled by a bool Kconfig, you can dump the module.h
> include and all the MODULE_<xyz> tags above.
>
> Or, if there is a genuine use case for it to be modular, then make it tristate?
>
> Thanks,
> Paul.
>
It will be non-modular.
Thanks,
Neil
next prev parent reply other threads:[~2016-08-16 13:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 9:13 [PATCH 0/3] clk: Add Meson GXBB Always-On Reset + Clocks Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-13 1:29 ` Stephen Boyd
2016-08-13 1:29 ` Stephen Boyd
2016-08-13 1:29 ` Stephen Boyd
2016-08-16 13:34 ` Neil Armstrong
2016-08-16 13:34 ` Neil Armstrong
2016-08-16 13:34 ` Neil Armstrong
2016-08-16 17:29 ` Stephen Boyd
2016-08-16 17:29 ` Stephen Boyd
2016-08-16 17:29 ` Stephen Boyd
2016-08-15 0:08 ` Paul Gortmaker
2016-08-15 0:08 ` Paul Gortmaker
2016-08-15 0:08 ` Paul Gortmaker
2016-08-15 0:08 ` Paul Gortmaker
2016-08-16 13:35 ` Neil Armstrong [this message]
2016-08-16 13:35 ` Neil Armstrong
2016-08-16 13:35 ` Neil Armstrong
2016-08-16 13:35 ` Neil Armstrong
2016-08-09 9:13 ` [PATCH 2/3] dt-bindings: clock: reset: Add GXBB AO Clock and Reset Bindings Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-10 21:40 ` Rob Herring
2016-08-10 21:40 ` Rob Herring
2016-08-10 21:40 ` Rob Herring
2016-08-10 21:40 ` Rob Herring
2016-08-09 9:13 ` [PATCH 3/3] ARM64: dts: meson-gxbb: Add GXBB AO Clock and Reset node Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
2016-08-09 9:13 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5529118a-63f0-cb54-f6a4-305603da168f@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul.gortmaker@windriver.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.