From: Caesar Wang <wxt@rock-chips.com> To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>, Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Caesar Wang <caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [patch] thermal: rockchip: fix an error code Date: Tue, 28 Apr 2015 00:35:50 +0000 [thread overview] Message-ID: <553ED5E6.3090800@rock-chips.com> (raw) In-Reply-To: <55371080.4090307-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Dan, 在 2015年04月22日 11:07, Caesar Wang 写道: > > > 在 2015年04月21日 17:34, Dan Carpenter 写道: >> There is a copy and paste bug, "->clk" vs "->pclk", so we return the >> wrong error code here. >> >> Fixes: cbac8f639437 ('thermal: rockchip: add driver for thermal') >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> >> diff --git a/drivers/thermal/rockchip_thermal.c >> b/drivers/thermal/rockchip_thermal.c >> index 3aa46ac..cd8f5f93 100644 >> --- a/drivers/thermal/rockchip_thermal.c >> +++ b/drivers/thermal/rockchip_thermal.c >> @@ -529,7 +529,7 @@ static int rockchip_thermal_probe(struct >> platform_device *pdev) >> thermal->pclk = devm_clk_get(&pdev->dev, "apb_pclk"); >> if (IS_ERR(thermal->pclk)) { >> - error = PTR_ERR(thermal->clk); >> + error = PTR_ERR(thermal->pclk); > Yeah, you are right. > Reviewed-by: Caesar Wang <wxt@rock-chips.com> > Tested-by: Caesar Wang <wxt@rock-chips.com> > Thanks. > > Caesar >> dev_err(&pdev->dev, "failed to get apb_pclk clock: %d\n", >> error); >> return error; >> >> >> > -- ************************************************************************************** 王晓腾 Caesar Wang Product R&D Dept.III Fuzhou Rockchip Electronics Co.Ltd Addr: NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters) 21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen (Shenzhen Office) Tel:+86-591-83991906/07 - 8221 Mobile:+86 15059456742 E-mail : wxt@rock-chips.com *************************************************************************************** *************************************************************************************** IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you. ***************************************************************************************
WARNING: multiple messages have this Message-ID (diff)
From: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>, Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Caesar Wang <caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [patch] thermal: rockchip: fix an error code Date: Tue, 28 Apr 2015 08:35:50 +0800 [thread overview] Message-ID: <553ED5E6.3090800@rock-chips.com> (raw) In-Reply-To: <55371080.4090307-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Dan, 在 2015年04月22日 11:07, Caesar Wang 写道: > > > 在 2015年04月21日 17:34, Dan Carpenter 写道: >> There is a copy and paste bug, "->clk" vs "->pclk", so we return the >> wrong error code here. >> >> Fixes: cbac8f639437 ('thermal: rockchip: add driver for thermal') >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> >> diff --git a/drivers/thermal/rockchip_thermal.c >> b/drivers/thermal/rockchip_thermal.c >> index 3aa46ac..cd8f5f93 100644 >> --- a/drivers/thermal/rockchip_thermal.c >> +++ b/drivers/thermal/rockchip_thermal.c >> @@ -529,7 +529,7 @@ static int rockchip_thermal_probe(struct >> platform_device *pdev) >> thermal->pclk = devm_clk_get(&pdev->dev, "apb_pclk"); >> if (IS_ERR(thermal->pclk)) { >> - error = PTR_ERR(thermal->clk); >> + error = PTR_ERR(thermal->pclk); > Yeah, you are right. > Reviewed-by: Caesar Wang <wxt@rock-chips.com> > Tested-by: Caesar Wang <wxt@rock-chips.com> > Thanks. > > Caesar >> dev_err(&pdev->dev, "failed to get apb_pclk clock: %d\n", >> error); >> return error; >> >> >> > -- ************************************************************************************** 王晓腾 Caesar Wang Product R&D Dept.III Fuzhou Rockchip Electronics Co.Ltd Addr: NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters) 21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen (Shenzhen Office) Tel:+86-591-83991906/07 - 8221 Mobile:+86 15059456742 E-mail : wxt@rock-chips.com *************************************************************************************** *************************************************************************************** IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you. *************************************************************************************** _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2015-04-28 0:35 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-21 9:34 [patch] thermal: rockchip: fix an error code Dan Carpenter 2015-04-21 9:34 ` Dan Carpenter 2015-04-22 3:07 ` Caesar Wang 2015-04-22 3:07 ` Caesar Wang [not found] ` <55371080.4090307-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2015-04-28 0:35 ` Caesar Wang [this message] 2015-04-28 0:35 ` Caesar Wang 2015-04-27 17:50 ` Doug Anderson 2015-04-27 17:50 ` Doug Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=553ED5E6.3090800@rock-chips.com \ --to=wxt@rock-chips.com \ --cc=caesar.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \ --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \ --cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.