From: Vlastimil Babka <vbabka@suse.cz> To: Jan Kara <jack@suse.cz>, linux-mm@kvack.org Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>, dri-devel@lists.freedesktop.org, Pawel Osciak <pawel@osciak.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, mgorman@suse.de, Marek Szyprowski <m.szyprowski@samsung.com>, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Date: Wed, 06 May 2015 12:46:42 +0200 [thread overview] Message-ID: <5549F112.1000405@suse.cz> (raw) In-Reply-To: <1430897296-5469-4-git-send-email-jack@suse.cz> On 05/06/2015 09:28 AM, Jan Kara wrote: > Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of > hand made mapping of virtual address to physical address. Also the > function leaked page reference from get_user_pages() so fix that by > properly release the reference when omap_vout_buffer_release() is > called. > > Signed-off-by: Jan Kara <jack@suse.cz> > --- > drivers/media/platform/omap/omap_vout.c | 67 +++++++++++++++------------------ > 1 file changed, 31 insertions(+), 36 deletions(-) > ... > + vec = frame_vector_create(1); > + if (!vec) > + return -ENOMEM; > > - if (res == nr_pages) { > - physp = __pa(page_address(&pages[0]) + > - (virtp & ~PAGE_MASK)); > - } else { > - printk(KERN_WARNING VOUT_NAME > - "get_user_pages failed\n"); > - return 0; > - } > + ret = get_vaddr_frames(virtp, 1, 1, 0, vec); Use true/false where appropriate.
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: Jan Kara <jack@suse.cz>, linux-mm@kvack.org Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>, dri-devel@lists.freedesktop.org, Pawel Osciak <pawel@osciak.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, mgorman@suse.de, Marek Szyprowski <m.szyprowski@samsung.com>, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Date: Wed, 06 May 2015 12:46:42 +0200 [thread overview] Message-ID: <5549F112.1000405@suse.cz> (raw) In-Reply-To: <1430897296-5469-4-git-send-email-jack@suse.cz> On 05/06/2015 09:28 AM, Jan Kara wrote: > Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of > hand made mapping of virtual address to physical address. Also the > function leaked page reference from get_user_pages() so fix that by > properly release the reference when omap_vout_buffer_release() is > called. > > Signed-off-by: Jan Kara <jack@suse.cz> > --- > drivers/media/platform/omap/omap_vout.c | 67 +++++++++++++++------------------ > 1 file changed, 31 insertions(+), 36 deletions(-) > ... > + vec = frame_vector_create(1); > + if (!vec) > + return -ENOMEM; > > - if (res == nr_pages) { > - physp = __pa(page_address(&pages[0]) + > - (virtp & ~PAGE_MASK)); > - } else { > - printk(KERN_WARNING VOUT_NAME > - "get_user_pages failed\n"); > - return 0; > - } > + ret = get_vaddr_frames(virtp, 1, 1, 0, vec); Use true/false where appropriate. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-06 10:46 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-06 7:28 [PATCH 0/9 v4] Helper to abstract vma handling in media layer Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 1/9] [media] vb2: Push mmap_sem down to memops Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 2/9] mm: Provide new get_vaddr_frames() helper Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 10:45 ` Vlastimil Babka 2015-05-06 10:45 ` Vlastimil Babka 2015-05-06 14:58 ` Jan Kara 2015-05-06 14:58 ` Jan Kara 2015-05-06 14:58 ` Jan Kara 2015-05-08 14:49 ` Mel Gorman 2015-05-08 14:49 ` Mel Gorman 2015-05-11 14:00 ` Jan Kara 2015-05-11 14:00 ` Jan Kara 2015-05-11 14:00 ` Jan Kara 2015-05-11 14:47 ` Mel Gorman 2015-05-11 14:47 ` Mel Gorman 2015-05-06 7:28 ` [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 10:46 ` Vlastimil Babka [this message] 2015-05-06 10:46 ` Vlastimil Babka 2015-05-06 15:01 ` Jan Kara 2015-05-06 15:01 ` Jan Kara 2015-05-06 7:28 ` [PATCH 4/9] vb2: Provide helpers for mapping virtual addresses Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() " Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() " Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 8/9] media: vb2: Remove unused functions Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames() Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 7:28 ` Jan Kara 2015-05-06 10:47 ` Vlastimil Babka 2015-05-06 10:47 ` Vlastimil Babka 2015-05-06 15:02 ` Jan Kara 2015-05-06 15:02 ` Jan Kara -- strict thread matches above, loose matches on Subject: below -- 2015-07-13 14:55 [PATCH 0/9 v7] Helper to abstract vma handling in media layer Jan Kara 2015-07-13 14:55 ` [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Jan Kara 2015-07-13 14:55 ` Jan Kara 2015-05-13 13:08 [PATCH 0/9 v5] Helper to abstract vma handling in media layer Jan Kara 2015-05-13 13:08 ` [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Jan Kara 2015-05-13 13:08 ` Jan Kara 2015-05-13 13:08 ` Jan Kara 2015-05-05 16:01 [PATCH 0/9 v3] Helper to abstract vma handling in media layer Jan Kara 2015-05-05 16:01 ` [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Jan Kara 2015-05-05 16:01 ` Jan Kara 2015-05-05 16:01 ` Jan Kara 2015-03-17 11:56 [PATCH 0/9 v2] Helper to abstract vma handling in media layer Jan Kara 2015-03-17 11:56 ` [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Jan Kara 2015-03-17 11:56 ` Jan Kara 2015-03-17 11:56 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5549F112.1000405@suse.cz \ --to=vbabka@suse.cz \ --cc=dri-devel@lists.freedesktop.org \ --cc=hverkuil@xs4all.nl \ --cc=jack@suse.cz \ --cc=linux-media@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mchehab@osg.samsung.com \ --cc=mgorman@suse.de \ --cc=pawel@osciak.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.