From: Jiang Liu <jiang.liu@linux.intel.com> To: Hanjun Guo <hanjun.guo@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Bjorn Helgaas <bhelgaas@google.com>, Marc Zyngier <marc.zyngier@arm.com>, Yijing Wang <wangyijing@huawei.com>, Len Brown <lenb@kernel.org> Cc: Lv Zheng <lv.zheng@intel.com>, LKML <linux-kernel@vger.kernel.org>, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" <x86@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Date: Thu, 14 May 2015 09:09:19 +0800 [thread overview] Message-ID: <5553F5BF.2080802@linux.intel.com> (raw) In-Reply-To: <555350B2.8050301@linaro.org> On 2015/5/13 21:25, Hanjun Guo wrote: > On 2015年05月13日 20:24, Jiang Liu wrote: >> On 2015/5/13 17:29, Hanjun Guo wrote: >>> Hi Jiang, >>> >>> On 2015年05月05日 10:46, Jiang Liu wrote: >>> >>> struct pci_controller { >>> struct acpi_device *companion; >>> void *iommu; >>> int segment; >>> int node; /* nearest node with memory or >>> NUMA_NO_NODE for global allocation */ >>> >>> void *platform_data; >>> }; >>> >>> except void *platform_data; >>> >>> On ARM64, the structure is almost the same, so how about >>> introduce >>> >>> struct pci_controller { >>> struct acpi_device *companion; /* ACPI companion device */ >>> void *iommu; /* IOMMU private data */ >>> int segment; /* PCI domain */ >>> int node; /* NUMA node */ >>> #ifdef CONFIG_IA64 >>> void *platform_data; >>> #endif >>> }; >>> >>> in this file, then can be used for all architectures? >> Current mode is that architecture defines its own version of >> struct pci_controller. It would be better to keep this pattern. > > OK, thanks for the clarify :) So how about add my basic > PCI support patch for ARM64 on top of you patch set to fix > this problem? Sure, please send me the patches and I will send out v3 to cover your review comments. Thanks! > > Thanks > Hanjun > >
WARNING: multiple messages have this Message-ID (diff)
From: jiang.liu@linux.intel.com (Jiang Liu) To: linux-arm-kernel@lists.infradead.org Subject: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Date: Thu, 14 May 2015 09:09:19 +0800 [thread overview] Message-ID: <5553F5BF.2080802@linux.intel.com> (raw) In-Reply-To: <555350B2.8050301@linaro.org> On 2015/5/13 21:25, Hanjun Guo wrote: > On 2015?05?13? 20:24, Jiang Liu wrote: >> On 2015/5/13 17:29, Hanjun Guo wrote: >>> Hi Jiang, >>> >>> On 2015?05?05? 10:46, Jiang Liu wrote: >>> >>> struct pci_controller { >>> struct acpi_device *companion; >>> void *iommu; >>> int segment; >>> int node; /* nearest node with memory or >>> NUMA_NO_NODE for global allocation */ >>> >>> void *platform_data; >>> }; >>> >>> except void *platform_data; >>> >>> On ARM64, the structure is almost the same, so how about >>> introduce >>> >>> struct pci_controller { >>> struct acpi_device *companion; /* ACPI companion device */ >>> void *iommu; /* IOMMU private data */ >>> int segment; /* PCI domain */ >>> int node; /* NUMA node */ >>> #ifdef CONFIG_IA64 >>> void *platform_data; >>> #endif >>> }; >>> >>> in this file, then can be used for all architectures? >> Current mode is that architecture defines its own version of >> struct pci_controller. It would be better to keep this pattern. > > OK, thanks for the clarify :) So how about add my basic > PCI support patch for ARM64 on top of you patch set to fix > this problem? Sure, please send me the patches and I will send out v3 to cover your review comments. Thanks! > > Thanks > Hanjun > >
next prev parent reply other threads:[~2015-05-14 1:09 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-05 2:46 [RFC v2 0/7] Consolidate ACPI PCI root common code into ACPI core Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` [RFC v2 1/7] ACPI/PCI: Enhance ACPI core to support sparse IO space Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-11 13:01 ` Hanjun Guo 2015-05-11 13:01 ` Hanjun Guo 2015-05-11 13:01 ` Hanjun Guo 2015-05-05 2:46 ` [RFC v2 2/7] ia64/PCI/ACPI: Use common ACPI resource parsing interface for host bridge Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-11 13:04 ` Hanjun Guo 2015-05-11 13:04 ` Hanjun Guo 2015-05-11 13:04 ` Hanjun Guo 2015-05-05 2:46 ` [RFC v2 3/7] ia64/PCI: Use common struct resource_entry to replace struct iospace_resource Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` [RFC v2 4/7] x86/PCI: Rename struct pci_sysdata as struct pci_controller Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-11 13:36 ` Hanjun Guo 2015-05-11 13:36 ` Hanjun Guo 2015-05-11 13:36 ` Hanjun Guo 2015-05-13 5:36 ` Jiang Liu 2015-05-13 5:36 ` Jiang Liu 2015-05-13 5:36 ` Jiang Liu 2015-05-13 9:29 ` Hanjun Guo 2015-05-13 9:29 ` Hanjun Guo 2015-05-13 12:24 ` Jiang Liu 2015-05-13 12:24 ` Jiang Liu 2015-05-13 13:25 ` Hanjun Guo 2015-05-13 13:25 ` Hanjun Guo 2015-05-14 1:09 ` Jiang Liu [this message] 2015-05-14 1:09 ` Jiang Liu 2015-05-14 4:05 ` Hanjun Guo 2015-05-14 4:05 ` Hanjun Guo 2015-05-14 4:42 ` Jiang Liu 2015-05-14 4:42 ` Jiang Liu 2015-05-14 4:42 ` Jiang Liu 2015-05-05 2:46 ` [RFC v2 6/7] x86/PCI/ACPI: Use common interface to support PCI host bridge Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-12 12:19 ` Hanjun Guo 2015-05-12 12:19 ` Hanjun Guo 2015-05-13 5:38 ` Jiang Liu 2015-05-13 5:38 ` Jiang Liu 2015-05-05 2:46 ` [RFC v2 7/7] ia64/PCI/ACPI: " Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 2:46 ` Jiang Liu 2015-05-05 3:10 ` [RFC v2 0/7] Consolidate ACPI PCI root common code into ACPI core Hanjun Guo 2015-05-05 3:10 ` Hanjun Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5553F5BF.2080802@linux.intel.com \ --to=jiang.liu@linux.intel.com \ --cc=bhelgaas@google.com \ --cc=hanjun.guo@linaro.org \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lv.zheng@intel.com \ --cc=marc.zyngier@arm.com \ --cc=rjw@rjwysocki.net \ --cc=wangyijing@huawei.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.