From: Giuseppe CAVALLARO <peppe.cavallaro-qxv4g6HH51o@public.gmane.org> To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> Cc: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, Roger <roger.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org, David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, linux-arm-kernel <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [PATCH net-next 00/11] convert stmmac glue layers into platform drivers Date: Fri, 15 May 2015 11:11:14 +0200 [thread overview] Message-ID: <5555B832.3080708@st.com> (raw) In-Reply-To: <5463867.jjPLKQomlR@wuerfel> Hi Arnd On 5/15/2015 10:44 AM, Arnd Bergmann wrote: > On Friday 15 May 2015 09:45:47 Giuseppe CAVALLARO wrote: >> Hello >> >> On 5/14/2015 5:24 PM, Chen-Yu Tsai wrote: >>> On Thu, May 14, 2015 at 6:10 PM, Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >>>> This patch set aims to convert the current dwmac glue layers into >>>> proper platform drivers as request by Arnd[1]. These changes start >>>> from patch 3 and onwards. >>>> >>>> Overview: >>>> Platform driver functions like probe and remove are exported from >>>> the stmmac platform and then used in subsequent glue later >>>> conversions. The conversion involes adding the platform driver >>>> boiler plate code and adding it to the build system. The last patch >>>> removes the driver from the stmmac platform code thus making it into >>>> a library for common platform driver functions. >>>> >>>> The two first patches adds glue layer for my platform. I chose to >>>> first add old style glue layer and then convert it. The churn this >>>> creates is just 3 lines. >>>> >>>> I would be very nice if people could test this patch set on their >>>> respective platform. My testing has been limited to compiling and >>>> testing on my (LPC18xx) platform. Thanks! >> >> I wonder if this will make the compatibility with old >> platforms (like SH4) not based on DT, where there was not used >> any glue-logic around the driver and just the platform was the >> reference. > > With patch 11, this gets handled by the dwmac-generic driver. ok > >> To be honest, I prefer to not have the Kconfig options. >> The device-tree compatibility will select the glue-logic >> needed and we will just pay some bytes when compile. >> >> In my opinion, the Koption(s) introduce a problem when touch >> the driver and we want to guarantee that, at least, >> all its parts build fine on all the platforms. > > The current model is not scalable and requires modifying the base > driver for each variation, and the change brings the driver > in line with how we do things for other platform drivers. > > We should always be able to build all soc-specific glue drivers > with 'allmodconfig' for build testing, and a lot of us run that > frequently to find regressions. thx for your prompt feedback Peppe > > Arnd > >
WARNING: multiple messages have this Message-ID (diff)
From: peppe.cavallaro@st.com (Giuseppe CAVALLARO) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next 00/11] convert stmmac glue layers into platform drivers Date: Fri, 15 May 2015 11:11:14 +0200 [thread overview] Message-ID: <5555B832.3080708@st.com> (raw) In-Reply-To: <5463867.jjPLKQomlR@wuerfel> Hi Arnd On 5/15/2015 10:44 AM, Arnd Bergmann wrote: > On Friday 15 May 2015 09:45:47 Giuseppe CAVALLARO wrote: >> Hello >> >> On 5/14/2015 5:24 PM, Chen-Yu Tsai wrote: >>> On Thu, May 14, 2015 at 6:10 PM, Joachim Eastwood <manabian@gmail.com> wrote: >>>> This patch set aims to convert the current dwmac glue layers into >>>> proper platform drivers as request by Arnd[1]. These changes start >>>> from patch 3 and onwards. >>>> >>>> Overview: >>>> Platform driver functions like probe and remove are exported from >>>> the stmmac platform and then used in subsequent glue later >>>> conversions. The conversion involes adding the platform driver >>>> boiler plate code and adding it to the build system. The last patch >>>> removes the driver from the stmmac platform code thus making it into >>>> a library for common platform driver functions. >>>> >>>> The two first patches adds glue layer for my platform. I chose to >>>> first add old style glue layer and then convert it. The churn this >>>> creates is just 3 lines. >>>> >>>> I would be very nice if people could test this patch set on their >>>> respective platform. My testing has been limited to compiling and >>>> testing on my (LPC18xx) platform. Thanks! >> >> I wonder if this will make the compatibility with old >> platforms (like SH4) not based on DT, where there was not used >> any glue-logic around the driver and just the platform was the >> reference. > > With patch 11, this gets handled by the dwmac-generic driver. ok > >> To be honest, I prefer to not have the Kconfig options. >> The device-tree compatibility will select the glue-logic >> needed and we will just pay some bytes when compile. >> >> In my opinion, the Koption(s) introduce a problem when touch >> the driver and we want to guarantee that, at least, >> all its parts build fine on all the platforms. > > The current model is not scalable and requires modifying the base > driver for each variation, and the change brings the driver > in line with how we do things for other platform drivers. > > We should always be able to build all soc-specific glue drivers > with 'allmodconfig' for build testing, and a lot of us run that > frequently to find regressions. thx for your prompt feedback Peppe > > Arnd > >
next prev parent reply other threads:[~2015-05-15 9:11 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-14 10:10 [PATCH net-next 00/11] convert stmmac glue layers into platform drivers Joachim Eastwood 2015-05-14 10:10 ` Joachim Eastwood 2015-05-14 10:10 ` [PATCH net-next 01/11] stmmac: add dwmac glue for NXP 18xx/43xx family Joachim Eastwood 2015-05-14 10:10 ` Joachim Eastwood 2015-05-14 10:10 ` [PATCH net-next 02/11] doc: dt: add documentation for nxp,lpc1850-dwmac Joachim Eastwood 2015-05-14 10:10 ` [PATCH net-next 02/11] doc: dt: add documentation for nxp, lpc1850-dwmac Joachim Eastwood 2015-05-14 10:10 ` [PATCH net-next 03/11] stmmac: prepare stmmac platform to support stand alone drivers Joachim Eastwood 2015-05-14 10:10 ` Joachim Eastwood 2015-05-14 10:10 ` [PATCH net-next 04/11] stmmac: add a generic dwmac driver Joachim Eastwood 2015-05-14 10:10 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 05/11] stmmac: convert dwmac-lpc18xx to a platform driver Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 06/11] stmmac: convert dwmac-meson to " Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 07/11] stmmac: convert dwmac-rk " Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 08/11] stmmac: convert dwmac-socfpga " Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 09/11] stmmac: convert dwmac-sti " Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 10/11] stmmac: convert dwmac-sunxi " Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 10:11 ` [PATCH net-next 11/11] stmmac: drop driver from stmmac platform code Joachim Eastwood 2015-05-14 10:11 ` Joachim Eastwood 2015-05-14 15:24 ` [PATCH net-next 00/11] convert stmmac glue layers into platform drivers Chen-Yu Tsai 2015-05-14 15:24 ` Chen-Yu Tsai [not found] ` <CAGb2v663efjkwgRjPdxV4CQxeesiu7jxkMf9j_oPU_bSHbNNiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-15 7:45 ` Giuseppe CAVALLARO 2015-05-15 7:45 ` Giuseppe CAVALLARO [not found] ` <5555A42B.3040205-qxv4g6HH51o@public.gmane.org> 2015-05-15 8:44 ` Arnd Bergmann 2015-05-15 8:44 ` Arnd Bergmann 2015-05-15 9:11 ` Giuseppe CAVALLARO [this message] 2015-05-15 9:11 ` Giuseppe CAVALLARO 2015-05-14 19:53 ` Dinh Nguyen 2015-05-14 19:53 ` Dinh Nguyen 2015-05-14 19:53 ` Dinh Nguyen 2015-05-15 16:44 ` David Miller 2015-05-15 16:44 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5555B832.3080708@st.com \ --to=peppe.cavallaro-qxv4g6hh51o@public.gmane.org \ --cc=arnd-r2nGTMty4D4@public.gmane.org \ --cc=b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=roger.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=wens-jdAy2FN1RRM@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.