All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Pantelis Antoniou <pantelis.antoniou@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-kbuild@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] kbuild: Create a rule for building device tree overlay objects
Date: Fri, 15 May 2015 17:47:38 -0700	[thread overview]
Message-ID: <555693AA.1000105@gmail.com> (raw)
In-Reply-To: <D4386733-8722-478F-8BB6-FB86597D9E37@gmail.com>

On 5/12/2015 7:33 AM, Pantelis Antoniou wrote:
> Hi Geert,
> 
>> On May 12, 2015, at 14:56 , Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>>
>> This allows to handle device tree overlays like plain device trees.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Questions:
>>  - Do we want dtso files under arch/<arch>/boot/dts/, too?
>>  - Do we want to move the dts files outside the kernel repository
>>    first?
>>
> 
> Oh that’s a nice hornet’s nest you’ve kicked here.
> 
> arch/<arch>/boot/dts should not be the place, cause overlays are not related with boot per se.
> As they are right now are board (family) specific.

Aren't overlays meant to describe child boards (capes, shields, whatever) that may
vary from system to system, but are not expected to be hot-plugged while the OS
is up?  Or is hot-plug a design goal?

If no hot-plug, then to me an overlay is just as related to boot as the base dts.
It is a mere implementation detail that overlays are "loaded" from userspace
instead of by the booting kernel (I don't really know the details of using
overlays, so please correct me if I am wrong about how the kernel becomes aware
of an overlay).

> 
> I think we should try to keep an external kernel repo with them for now until we
> figure out where to put them.
> 
>> scripts/Makefile.lib | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 79e86613712f2230..4b14eef1d4b2ce8f 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -292,6 +292,9 @@ cmd_dtc = mkdir -p $(dir ${dtc-tmp}) ; \
>> $(obj)/%.dtb: $(src)/%.dts FORCE
>> 	$(call if_changed_dep,dtc)
>>
>> +$(obj)/%.dtbo: $(src)/%.dtso FORCE
>> +	$(call if_changed_dep,dtc)
>> +
>> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>>
>> # Bzip2
>> -- 
>> 1.9.1
> 
> Regards
> 
> — Pantelis
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Pantelis Antoniou <pantelis.antoniou@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-kbuild@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] kbuild: Create a rule for building device tree overlay objects
Date: Fri, 15 May 2015 17:47:38 -0700	[thread overview]
Message-ID: <555693AA.1000105@gmail.com> (raw)
In-Reply-To: <D4386733-8722-478F-8BB6-FB86597D9E37@gmail.com>

On 5/12/2015 7:33 AM, Pantelis Antoniou wrote:
> Hi Geert,
> 
>> On May 12, 2015, at 14:56 , Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>>
>> This allows to handle device tree overlays like plain device trees.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Questions:
>>  - Do we want dtso files under arch/<arch>/boot/dts/, too?
>>  - Do we want to move the dts files outside the kernel repository
>>    first?
>>
> 
> Oh that’s a nice hornet’s nest you’ve kicked here.
> 
> arch/<arch>/boot/dts should not be the place, cause overlays are not related with boot per se.
> As they are right now are board (family) specific.

Aren't overlays meant to describe child boards (capes, shields, whatever) that may
vary from system to system, but are not expected to be hot-plugged while the OS
is up?  Or is hot-plug a design goal?

If no hot-plug, then to me an overlay is just as related to boot as the base dts.
It is a mere implementation detail that overlays are "loaded" from userspace
instead of by the booting kernel (I don't really know the details of using
overlays, so please correct me if I am wrong about how the kernel becomes aware
of an overlay).

> 
> I think we should try to keep an external kernel repo with them for now until we
> figure out where to put them.
> 
>> scripts/Makefile.lib | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 79e86613712f2230..4b14eef1d4b2ce8f 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -292,6 +292,9 @@ cmd_dtc = mkdir -p $(dir ${dtc-tmp}) ; \
>> $(obj)/%.dtb: $(src)/%.dts FORCE
>> 	$(call if_changed_dep,dtc)
>>
>> +$(obj)/%.dtbo: $(src)/%.dtso FORCE
>> +	$(call if_changed_dep,dtc)
>> +
>> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>>
>> # Bzip2
>> -- 
>> 1.9.1
> 
> Regards
> 
> — Pantelis
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-05-16  0:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 11:56 [PATCH/RFC] kbuild: Create a rule for building device tree overlay objects Geert Uytterhoeven
2015-05-12 14:33 ` Pantelis Antoniou
2015-05-12 14:33   ` Pantelis Antoniou
2015-05-16  0:47   ` Frank Rowand [this message]
2015-05-16  0:47     ` Frank Rowand
2015-05-16  2:16     ` Frank Rowand
2015-05-16  2:16       ` Frank Rowand
2015-05-18 14:13       ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555693AA.1000105@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pantelis.antoniou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.