All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Arnd Bergmann <arnd@arndb.de>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	<xen-devel@lists.xenproject.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS
Date: Tue, 19 May 2015 16:15:13 +0100	[thread overview]
Message-ID: <555B5381.8070808@citrix.com> (raw)
In-Reply-To: <555B4D70.7050900@oracle.com>

On 19/05/15 15:49, Boris Ostrovsky wrote:
> On 05/19/2015 10:36 AM, Arnd Bergmann wrote:
>> On Tuesday 19 May 2015 09:57:19 Boris Ostrovsky wrote:
>>> On 05/19/2015 08:58 AM, Arnd Bergmann wrote:
>>>> A recent bug fix for x86 broke Xen on ARM for the case that
>>>> CONFIG_HIBERNATE_CALLBACKS is enabled:
>>>>
>>>> drivers/built-in.o: In function `do_suspend':
>>>> /git/arm-soc/drivers/xen/manage.c:134: undefined reference to
>>>> `xen_arch_suspend'
>>>> drivers/built-in.o:(.debug_addr+0xc3f4): undefined reference to
>>>> `xen_arch_suspend'
>>>>
>>>> It is not clear to me what needs to be done here, but this
>>>> patch avoids the build error by adding a stub for the
>>>> missing function.
>>> This is already fixed in Xen staging tree.
>> I see. Any chance to get that fix into linux-next soon?
> 
> 
> David, are you going to send pull request to Linus before rc5?

Yes.

David

WARNING: multiple messages have this Message-ID (diff)
From: david.vrabel@citrix.com (David Vrabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS
Date: Tue, 19 May 2015 16:15:13 +0100	[thread overview]
Message-ID: <555B5381.8070808@citrix.com> (raw)
In-Reply-To: <555B4D70.7050900@oracle.com>

On 19/05/15 15:49, Boris Ostrovsky wrote:
> On 05/19/2015 10:36 AM, Arnd Bergmann wrote:
>> On Tuesday 19 May 2015 09:57:19 Boris Ostrovsky wrote:
>>> On 05/19/2015 08:58 AM, Arnd Bergmann wrote:
>>>> A recent bug fix for x86 broke Xen on ARM for the case that
>>>> CONFIG_HIBERNATE_CALLBACKS is enabled:
>>>>
>>>> drivers/built-in.o: In function `do_suspend':
>>>> /git/arm-soc/drivers/xen/manage.c:134: undefined reference to
>>>> `xen_arch_suspend'
>>>> drivers/built-in.o:(.debug_addr+0xc3f4): undefined reference to
>>>> `xen_arch_suspend'
>>>>
>>>> It is not clear to me what needs to be done here, but this
>>>> patch avoids the build error by adding a stub for the
>>>> missing function.
>>> This is already fixed in Xen staging tree.
>> I see. Any chance to get that fix into linux-next soon?
> 
> 
> David, are you going to send pull request to Linus before rc5?

Yes.

David

  reply	other threads:[~2015-05-19 15:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 12:58 [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS Arnd Bergmann
2015-05-19 12:58 ` Arnd Bergmann
2015-05-19 13:57 ` Boris Ostrovsky
2015-05-19 13:57 ` Boris Ostrovsky
2015-05-19 13:57   ` Boris Ostrovsky
2015-05-19 14:36   ` Arnd Bergmann
2015-05-19 14:36   ` Arnd Bergmann
2015-05-19 14:36     ` Arnd Bergmann
2015-05-19 14:49     ` Boris Ostrovsky
2015-05-19 14:49     ` Boris Ostrovsky
2015-05-19 14:49       ` Boris Ostrovsky
2015-05-19 15:15       ` David Vrabel [this message]
2015-05-19 15:15         ` David Vrabel
2015-05-19 15:15       ` David Vrabel
2015-05-19 12:58 Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555B5381.8070808@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=arnd@arndb.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.