All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene@kernel.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property
Date: Sat, 23 May 2015 11:20:06 +0900	[thread overview]
Message-ID: <555FE3D6.7030009@kernel.org> (raw)
In-Reply-To: <CABxcv=mKLGVWj2swi63-AkdF_-D5eVM=-785dJ8WjUNC-D1zpg@mail.gmail.com>

On 05/21/15 16:23, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On Thu, May 21, 2015 at 4:18 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>> support for PMU regmap") the Exynos PMU driver provides regmap to access
>> the MIPI DPHY registers. The MIPI DPHY node uses a phandle to syscon to
>> get this regmap. The 'reg' field is obsolete.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos4.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 1c74c1296ab7..6e7f0b4afa84 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -78,7 +78,6 @@
>>
>>         mipi_phy: video-phy@10020710 {
>>                 compatible = "samsung,s5pv210-mipi-video-phy";
>> -               reg = <0x10020710 8>;
>>                 #phy-cells = <1>;
>>                 syscon = <&pmu_system_controller>;
>>         };
> 
> Indeed, is even removed from the DT binding so this is clearly a left over.
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
Thanks, applied this series.

- Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property
Date: Sat, 23 May 2015 11:20:06 +0900	[thread overview]
Message-ID: <555FE3D6.7030009@kernel.org> (raw)
In-Reply-To: <CABxcv=mKLGVWj2swi63-AkdF_-D5eVM=-785dJ8WjUNC-D1zpg@mail.gmail.com>

On 05/21/15 16:23, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On Thu, May 21, 2015 at 4:18 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> Since e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>> support for PMU regmap") the Exynos PMU driver provides regmap to access
>> the MIPI DPHY registers. The MIPI DPHY node uses a phandle to syscon to
>> get this regmap. The 'reg' field is obsolete.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos4.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 1c74c1296ab7..6e7f0b4afa84 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -78,7 +78,6 @@
>>
>>         mipi_phy: video-phy at 10020710 {
>>                 compatible = "samsung,s5pv210-mipi-video-phy";
>> -               reg = <0x10020710 8>;
>>                 #phy-cells = <1>;
>>                 syscon = <&pmu_system_controller>;
>>         };
> 
> Indeed, is even removed from the DT binding so this is clearly a left over.
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
Thanks, applied this series.

- Kukjin

  reply	other threads:[~2015-05-23  2:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21  2:18 [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property Krzysztof Kozlowski
2015-05-21  2:18 ` Krzysztof Kozlowski
2015-05-21  2:18 ` [PATCH 2/2] ARM: dts: exynos4415: Add syscon property to the MIPI DPHY Krzysztof Kozlowski
2015-05-21  2:18   ` Krzysztof Kozlowski
2015-05-21  7:24   ` Javier Martinez Canillas
2015-05-21  7:24     ` Javier Martinez Canillas
2015-05-21  7:24     ` Javier Martinez Canillas
2015-05-21  7:23 ` [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property Javier Martinez Canillas
2015-05-21  7:23   ` Javier Martinez Canillas
2015-05-21  7:23   ` Javier Martinez Canillas
2015-05-23  2:20   ` Kukjin Kim [this message]
2015-05-23  2:20     ` Kukjin Kim
2015-05-23  2:20     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555FE3D6.7030009@kernel.org \
    --to=kgene@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.