From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC
Date: Mon, 25 May 2015 14:27:22 +0200 [thread overview]
Message-ID: <5563152A.4020104@collabora.co.uk> (raw)
In-Reply-To: <1432554253-25886-1-git-send-email-k.kozlowski.k@gmail.com>
Hello Krzysztof,
On 05/25/2015 01:44 PM, Krzysztof Kozlowski wrote:
> The IRQB of S2MPS11 PMIC is wired to XEINT4 (GPX0-4) through pull-up
> resistor.
>
> Add interrupt properties and pinctrl configuration to enable RTC wake
> alarm of rtc-s5m driver. This also removes a warning:
> sec_pmic 4-0066: No interrupt specified, no interrupts
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
I haven't checked with the board schematics but the patch
looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC
Date: Mon, 25 May 2015 14:27:22 +0200 [thread overview]
Message-ID: <5563152A.4020104@collabora.co.uk> (raw)
In-Reply-To: <1432554253-25886-1-git-send-email-k.kozlowski.k@gmail.com>
Hello Krzysztof,
On 05/25/2015 01:44 PM, Krzysztof Kozlowski wrote:
> The IRQB of S2MPS11 PMIC is wired to XEINT4 (GPX0-4) through pull-up
> resistor.
>
> Add interrupt properties and pinctrl configuration to enable RTC wake
> alarm of rtc-s5m driver. This also removes a warning:
> sec_pmic 4-0066: No interrupt specified, no interrupts
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
I haven't checked with the board schematics but the patch
looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
next prev parent reply other threads:[~2015-05-25 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 11:44 [PATCH] ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC Krzysztof Kozlowski
2015-05-25 11:44 ` Krzysztof Kozlowski
2015-05-25 12:27 ` Javier Martinez Canillas [this message]
2015-05-25 12:27 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5563152A.4020104@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski.k@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.