From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> To: Markus Pargmann <mpa@pengutronix.de> Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Timur Tabi <timur@tabi.org>, Nicolin Chen <nicoleotsuka@gmail.com>, Xiubo Li <Xiubo.Lee@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>, linuxppc-dev@lists.ozlabs.org, linux-kernel <linux-kernel@vger.kernel.org>, Fabio Estevam <festevam@gmail.com> Subject: Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates Date: Fri, 31 Jul 2015 16:38:20 +0200 [thread overview] Message-ID: <55BB885C.3040305@maciej.szmigiero.name> (raw) In-Reply-To: <20150731055357.GW30895@pengutronix.de> Hi Markus, Thanks for looking into the changes. On 31.07.2015 07:53, Markus Pargmann wrote: > On Fri, Jul 31, 2015 at 07:27:19AM +0200, Markus Pargmann wrote: >> Hi, >> >> On Thu, Jul 30, 2015 at 04:34:19PM +0200, Maciej S. Szmigiero wrote: >>> AC'97 bus can support asymmetric playback/capture rates >>> so enable them in this case in fsl_ssi driver. >>> >>> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name> >>> --- >>> sound/soc/fsl/fsl_ssi.c | 4 +++- >>> 1 files changed, 3 insertions(+), 1 deletions(-) >>> >>> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c >>> index a83b900..7f4f0b9 100644 >>> --- a/sound/soc/fsl/fsl_ssi.c >>> +++ b/sound/soc/fsl/fsl_ssi.c >>> @@ -1377,7 +1377,9 @@ static int fsl_ssi_probe(struct platform_device *pdev) >>> >>> /* Are the RX and the TX clocks locked? */ >>> if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { >>> - ssi_private->cpu_dai_drv.symmetric_rates = 1; >>> + if (!fsl_ssi_is_ac97(ssi_private)) >>> + ssi_private->cpu_dai_drv.symmetric_rates = 1; >>> + >> >> Why don't you use the DT property that is parsed here to enable >> asymmetric rates? Because in the AC'97 mode the driver supports only one channel config and one sample format anyway the remaining settings controlled by this property don't do anything. Since it should be safe to enable asymmetric rates with any AC'97 CODEC I think it is good to do it in driver than to add "fsl,ssi-asynchronous" to every AC'97 DT node. Also the description of this property in fsl,ssi.txt looks like that it only makes sense in non-AC'97 mode. > Just found the last version of this series. Please use v2 and describe > changes for a new iteration of a series. This is just a resubmission, there are no functional differences since it was originally submitted a month ago. > There is also a different setup with AC97 which does not use DMA. See > the long comment at the top of the file about how ac97 is already used. I understand that the problem with FIQ handler described in comment on top of fsl_ssi.c only pertains incoming data, that is capture. This patch effectively does not touch capture rates as they are already limited to 48kHz only since this is the only capture rate defined in fsl_ssi AC'97 DAI driver capture capabilities. > Regards, > > Markus Best regards, Maciej Szmigiero
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> To: Markus Pargmann <mpa@pengutronix.de> Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Xiubo Li <Xiubo.Lee@gmail.com>, Takashi Iwai <tiwai@suse.de>, linux-kernel <linux-kernel@vger.kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Timur Tabi <timur@tabi.org>, Nicolin Chen <nicoleotsuka@gmail.com>, Mark Brown <broonie@kernel.org>, Fabio Estevam <festevam@gmail.com>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates Date: Fri, 31 Jul 2015 16:38:20 +0200 [thread overview] Message-ID: <55BB885C.3040305@maciej.szmigiero.name> (raw) In-Reply-To: <20150731055357.GW30895@pengutronix.de> Hi Markus, Thanks for looking into the changes. On 31.07.2015 07:53, Markus Pargmann wrote: > On Fri, Jul 31, 2015 at 07:27:19AM +0200, Markus Pargmann wrote: >> Hi, >> >> On Thu, Jul 30, 2015 at 04:34:19PM +0200, Maciej S. Szmigiero wrote: >>> AC'97 bus can support asymmetric playback/capture rates >>> so enable them in this case in fsl_ssi driver. >>> >>> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name> >>> --- >>> sound/soc/fsl/fsl_ssi.c | 4 +++- >>> 1 files changed, 3 insertions(+), 1 deletions(-) >>> >>> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c >>> index a83b900..7f4f0b9 100644 >>> --- a/sound/soc/fsl/fsl_ssi.c >>> +++ b/sound/soc/fsl/fsl_ssi.c >>> @@ -1377,7 +1377,9 @@ static int fsl_ssi_probe(struct platform_device *pdev) >>> >>> /* Are the RX and the TX clocks locked? */ >>> if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { >>> - ssi_private->cpu_dai_drv.symmetric_rates = 1; >>> + if (!fsl_ssi_is_ac97(ssi_private)) >>> + ssi_private->cpu_dai_drv.symmetric_rates = 1; >>> + >> >> Why don't you use the DT property that is parsed here to enable >> asymmetric rates? Because in the AC'97 mode the driver supports only one channel config and one sample format anyway the remaining settings controlled by this property don't do anything. Since it should be safe to enable asymmetric rates with any AC'97 CODEC I think it is good to do it in driver than to add "fsl,ssi-asynchronous" to every AC'97 DT node. Also the description of this property in fsl,ssi.txt looks like that it only makes sense in non-AC'97 mode. > Just found the last version of this series. Please use v2 and describe > changes for a new iteration of a series. This is just a resubmission, there are no functional differences since it was originally submitted a month ago. > There is also a different setup with AC97 which does not use DMA. See > the long comment at the top of the file about how ac97 is already used. I understand that the problem with FIQ handler described in comment on top of fsl_ssi.c only pertains incoming data, that is capture. This patch effectively does not touch capture rates as they are already limited to 48kHz only since this is the only capture rate defined in fsl_ssi AC'97 DAI driver capture capabilities. > Regards, > > Markus Best regards, Maciej Szmigiero
next prev parent reply other threads:[~2015-07-31 14:38 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-30 14:34 [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates Maciej S. Szmigiero 2015-07-31 5:27 ` Markus Pargmann 2015-07-31 5:53 ` Markus Pargmann 2015-07-31 14:38 ` Maciej S. Szmigiero [this message] 2015-07-31 14:38 ` Maciej S. Szmigiero 2015-08-02 18:46 ` Markus Pargmann -- strict thread matches above, loose matches on Subject: below -- 2015-06-28 13:46 Maciej S. Szmigiero 2015-06-28 13:46 ` Maciej S. Szmigiero 2015-06-28 14:01 ` Timur Tabi 2015-06-28 14:01 ` Timur Tabi 2015-06-28 19:12 ` Maciej S. Szmigiero
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55BB885C.3040305@maciej.szmigiero.name \ --to=mail@maciej.szmigiero.name \ --cc=Xiubo.Lee@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=festevam@gmail.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpa@pengutronix.de \ --cc=nicoleotsuka@gmail.com \ --cc=perex@perex.cz \ --cc=timur@tabi.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.