From: Vignesh R <vigneshr@ti.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Huang Shijie <b32955@freescale.com>, <linux-omap@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<linux-spi@vger.kernel.org>
Subject: Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi
Date: Mon, 3 Aug 2015 10:36:44 +0530 [thread overview]
Message-ID: <55BEF6E4.2000905@ti.com> (raw)
In-Reply-To: <20150731212847.GH10676@google.com>
On 08/01/2015 02:58 AM, Brian Norris wrote:
> On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote:
>> Add qspi memory mapped region entries for DRA7xx based SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ade28c790f4b..5317a0f24ab9 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -902,7 +902,9 @@
>>
>> qspi: qspi@47900000 {
>> compatible = "ti,am4372-qspi";
>> - reg = <0x47900000 0x100>;
>> + reg = <0x47900000 0x100>,
>> + <0x30000000 0x3ffffff>;
>
> Are you sure this region is 1 byte shy of 64MB in length? Same question
> for patch 5.
>
Oops, my bad... Its 64MB in length, I entered offset of last byte
instead of length. Will correct this in the actual patch.
>> + reg-names = "qspi_base", "qspi_mmap";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> ti,hwmods = "qspi";
>> --
>> 2.4.6
>>
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi
Date: Mon, 3 Aug 2015 10:36:44 +0530 [thread overview]
Message-ID: <55BEF6E4.2000905@ti.com> (raw)
In-Reply-To: <20150731212847.GH10676-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On 08/01/2015 02:58 AM, Brian Norris wrote:
> On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote:
>> Add qspi memory mapped region entries for DRA7xx based SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ade28c790f4b..5317a0f24ab9 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -902,7 +902,9 @@
>>
>> qspi: qspi@47900000 {
>> compatible = "ti,am4372-qspi";
>> - reg = <0x47900000 0x100>;
>> + reg = <0x47900000 0x100>,
>> + <0x30000000 0x3ffffff>;
>
> Are you sure this region is 1 byte shy of 64MB in length? Same question
> for patch 5.
>
Oops, my bad... Its 64MB in length, I entered offset of last byte
instead of length. Will correct this in the actual patch.
>> + reg-names = "qspi_base", "qspi_mmap";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> ti,hwmods = "qspi";
>> --
>> 2.4.6
>>
--
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi
Date: Mon, 3 Aug 2015 10:36:44 +0530 [thread overview]
Message-ID: <55BEF6E4.2000905@ti.com> (raw)
In-Reply-To: <20150731212847.GH10676-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On 08/01/2015 02:58 AM, Brian Norris wrote:
> On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote:
>> Add qspi memory mapped region entries for DRA7xx based SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ade28c790f4b..5317a0f24ab9 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -902,7 +902,9 @@
>>
>> qspi: qspi@47900000 {
>> compatible = "ti,am4372-qspi";
>> - reg = <0x47900000 0x100>;
>> + reg = <0x47900000 0x100>,
>> + <0x30000000 0x3ffffff>;
>
> Are you sure this region is 1 byte shy of 64MB in length? Same question
> for patch 5.
>
Oops, my bad... Its 64MB in length, I entered offset of last byte
instead of length. Will correct this in the actual patch.
>> + reg-names = "qspi_base", "qspi_mmap";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> ti,hwmods = "qspi";
>> --
>> 2.4.6
>>
--
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi
Date: Mon, 3 Aug 2015 10:36:44 +0530 [thread overview]
Message-ID: <55BEF6E4.2000905@ti.com> (raw)
In-Reply-To: <20150731212847.GH10676@google.com>
On 08/01/2015 02:58 AM, Brian Norris wrote:
> On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote:
>> Add qspi memory mapped region entries for DRA7xx based SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ade28c790f4b..5317a0f24ab9 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -902,7 +902,9 @@
>>
>> qspi: qspi at 47900000 {
>> compatible = "ti,am4372-qspi";
>> - reg = <0x47900000 0x100>;
>> + reg = <0x47900000 0x100>,
>> + <0x30000000 0x3ffffff>;
>
> Are you sure this region is 1 byte shy of 64MB in length? Same question
> for patch 5.
>
Oops, my bad... Its 64MB in length, I entered offset of last byte
instead of length. Will correct this in the actual patch.
>> + reg-names = "qspi_base", "qspi_mmap";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> ti,hwmods = "qspi";
>> --
>> 2.4.6
>>
--
Regards
Vignesh
next prev parent reply other threads:[~2015-08-03 5:07 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 8:41 [RFC PATCH 0/5] Add memory mapped read support for TI QSPI Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` [RFC PATCH 1/5] spi: introduce flag for memory mapped read Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-31 18:17 ` Mark Brown
2015-07-31 18:17 ` Mark Brown
2015-07-31 18:17 ` Mark Brown
2015-08-03 4:57 ` Vignesh R
2015-08-03 4:57 ` Vignesh R
2015-08-03 4:57 ` Vignesh R
2015-08-04 15:51 ` Mark Brown
2015-08-04 15:51 ` Mark Brown
2015-08-04 17:59 ` R, Vignesh
2015-08-04 17:59 ` R, Vignesh
2015-08-04 17:59 ` R, Vignesh
2015-08-04 17:59 ` R, Vignesh
2015-08-05 5:21 ` Michal Suchanek
2015-08-05 5:21 ` Michal Suchanek
2015-08-05 5:21 ` Michal Suchanek
2015-08-05 5:21 ` Michal Suchanek
2015-08-05 5:35 ` Vignesh R
2015-08-05 5:35 ` Vignesh R
2015-08-05 5:35 ` Vignesh R
2015-08-05 5:35 ` Vignesh R
2015-08-05 5:57 ` Michal Suchanek
2015-08-05 5:57 ` Michal Suchanek
2015-08-05 5:57 ` Michal Suchanek
2015-08-05 5:57 ` Michal Suchanek
2015-08-05 11:50 ` Mark Brown
2015-08-05 11:50 ` Mark Brown
2015-08-05 12:40 ` Michal Suchanek
2015-08-05 12:40 ` Michal Suchanek
2015-08-05 12:40 ` Michal Suchanek
2015-08-05 12:40 ` Michal Suchanek
2015-08-05 12:44 ` Mark Brown
2015-08-05 12:44 ` Mark Brown
2015-08-05 12:44 ` Mark Brown
2015-08-05 12:44 ` Mark Brown
2015-08-05 12:56 ` Michal Suchanek
2015-08-05 12:56 ` Michal Suchanek
2015-08-05 12:56 ` Michal Suchanek
2015-08-06 9:02 ` Mark Brown
2015-08-06 9:02 ` Mark Brown
2015-08-06 9:02 ` Mark Brown
2015-08-06 10:01 ` Michal Suchanek
2015-08-06 10:01 ` Michal Suchanek
2015-08-06 10:01 ` Michal Suchanek
2015-08-06 10:22 ` Russell King - ARM Linux
2015-08-06 10:22 ` Russell King - ARM Linux
2015-08-06 10:22 ` Russell King - ARM Linux
2015-08-06 10:22 ` Russell King - ARM Linux
2015-08-06 11:00 ` Mark Brown
2015-08-06 11:00 ` Mark Brown
2015-08-06 11:00 ` Mark Brown
2015-08-06 11:02 ` Michal Suchanek
2015-08-06 11:02 ` Michal Suchanek
2015-08-06 11:02 ` Michal Suchanek
2015-08-06 11:02 ` Michal Suchanek
2015-08-06 12:25 ` Vignesh R
2015-08-06 12:25 ` Vignesh R
2015-08-06 12:25 ` Vignesh R
2015-08-06 12:25 ` Vignesh R
2015-08-06 12:25 ` Vignesh R
2015-08-06 13:51 ` Russell King - ARM Linux
2015-08-06 13:51 ` Russell King - ARM Linux
2015-08-06 13:51 ` Russell King - ARM Linux
2015-08-06 16:14 ` Geert Uytterhoeven
2015-08-06 16:14 ` Geert Uytterhoeven
2015-08-06 16:14 ` Geert Uytterhoeven
2015-08-06 16:14 ` Geert Uytterhoeven
2015-08-06 18:20 ` Michal Suchanek
2015-08-06 18:20 ` Michal Suchanek
2015-08-06 18:20 ` Michal Suchanek
2015-08-06 18:20 ` Michal Suchanek
2015-08-06 21:33 ` Russell King - ARM Linux
2015-08-06 21:33 ` Russell King - ARM Linux
2015-08-06 21:33 ` Russell King - ARM Linux
2015-08-06 21:33 ` Russell King - ARM Linux
2015-08-07 7:38 ` Michal Suchanek
2015-08-07 7:38 ` Michal Suchanek
2015-08-07 7:38 ` Michal Suchanek
2015-08-07 7:38 ` Michal Suchanek
2015-08-07 8:35 ` Vignesh R
2015-08-07 8:35 ` Vignesh R
2015-08-07 8:35 ` Vignesh R
2015-08-07 8:25 ` Martin Sperl
2015-08-07 8:25 ` Martin Sperl
2015-08-07 8:25 ` Martin Sperl
2015-08-07 8:25 ` Martin Sperl
2015-08-07 10:16 ` Michal Suchanek
2015-08-07 10:16 ` Michal Suchanek
2015-08-07 10:16 ` Michal Suchanek
2015-08-12 9:27 ` Vignesh R
2015-08-12 9:27 ` Vignesh R
2015-08-12 9:27 ` Vignesh R
2015-08-12 9:27 ` Vignesh R
2015-08-06 16:46 ` Mark Brown
2015-08-06 16:46 ` Mark Brown
2015-08-06 16:46 ` Mark Brown
2015-08-06 16:46 ` Mark Brown
2015-08-06 18:20 ` Mark Brown
2015-08-06 18:20 ` Mark Brown
2015-08-06 18:20 ` Mark Brown
2015-08-06 11:23 ` Mark Brown
2015-08-06 11:23 ` Mark Brown
2015-08-06 11:23 ` Mark Brown
2015-08-06 11:23 ` Mark Brown
2015-08-06 11:42 ` Michal Suchanek
2015-08-06 11:42 ` Michal Suchanek
2015-08-06 11:42 ` Michal Suchanek
2015-08-06 16:03 ` Mark Brown
2015-08-06 16:03 ` Mark Brown
2015-08-06 16:03 ` Mark Brown
2015-07-28 8:41 ` [RFC PATCH 2/5] spi: spi-ti-qspi: Add memory mapped read support Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` [RFC PATCH 3/5] mtd: devices: m25p80: set flag to request memory mapped read Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-31 13:48 ` Sekhar Nori
2015-07-31 13:48 ` Sekhar Nori
2015-07-31 13:48 ` Sekhar Nori
2015-08-03 5:09 ` Vignesh R
2015-08-03 5:09 ` Vignesh R
2015-08-03 5:09 ` Vignesh R
2015-08-03 5:09 ` Vignesh R
2015-07-31 18:19 ` Mark Brown
2015-07-31 18:19 ` Mark Brown
2015-07-31 18:19 ` Mark Brown
2015-08-03 5:02 ` Vignesh R
2015-08-03 5:02 ` Vignesh R
2015-08-03 5:02 ` Vignesh R
2015-08-03 5:02 ` Vignesh R
2015-08-04 15:52 ` Mark Brown
2015-08-04 15:52 ` Mark Brown
2015-08-04 15:52 ` Mark Brown
2015-07-31 21:28 ` Brian Norris
2015-07-31 21:28 ` Brian Norris
2015-08-03 5:06 ` Vignesh R [this message]
2015-08-03 5:06 ` Vignesh R
2015-08-03 5:06 ` Vignesh R
2015-08-03 5:06 ` Vignesh R
2015-07-28 8:41 ` [RFC PATCH 5/5] ARM: dts: AM4372: " Vignesh R
2015-07-28 8:41 ` Vignesh R
2015-07-28 8:41 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BEF6E4.2000905@ti.com \
--to=vigneshr@ti.com \
--cc=b32955@freescale.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.