From: Archit Taneja <architt@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Rob Clark <robdclark@gmail.com>, Hai Li <hali@codeaurora.org>
Cc: Stephane Viau <sviau@codeaurora.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: msm: dsi: Don't attempt changing voltage of switches
Date: Fri, 28 Aug 2015 15:57:09 +0530 [thread overview]
Message-ID: <55E0377D.2050603@codeaurora.org> (raw)
In-Reply-To: <1439919272-19793-1-git-send-email-bjorn.andersson@sonymobile.com>
Hi,
On 08/18/2015 11:04 PM, Bjorn Andersson wrote:
> In some configurations the supplies are voltage switches and not LDOs,
> making the set voltage call to fail. Check with the regulator framework
> if the supply can change voltage before attempting.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 8c16d6a3ca78..ece3de6a8157 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -278,7 +278,7 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host)
> }
>
> for (i = 0; i < num; i++) {
> - if ((regs[i].min_voltage >= 0) && (regs[i].max_voltage >= 0)) {
> + if (regulator_can_change_voltage(s[i].consumer)) {
> ret = regulator_set_voltage(s[i].consumer,
> regs[i].min_voltage, regs[i].max_voltage);
> if (ret < 0) {
> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> index 401ff58d6893..f1f955f571fa 100644
> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> @@ -178,7 +178,7 @@ static int dsi_phy_regulator_init(struct msm_dsi_phy *phy)
> }
>
> for (i = 0; i < num; i++) {
> - if ((regs[i].min_voltage >= 0) && (regs[i].max_voltage >= 0)) {
> + if (regulator_can_change_voltage(s[i].consumer)) {
> ret = regulator_set_voltage(s[i].consumer,
> regs[i].min_voltage, regs[i].max_voltage);
> if (ret < 0) {
>
Looks good to me.
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <architt@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Rob Clark <robdclark@gmail.com>, Hai Li <hali@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: msm: dsi: Don't attempt changing voltage of switches
Date: Fri, 28 Aug 2015 15:57:09 +0530 [thread overview]
Message-ID: <55E0377D.2050603@codeaurora.org> (raw)
In-Reply-To: <1439919272-19793-1-git-send-email-bjorn.andersson@sonymobile.com>
Hi,
On 08/18/2015 11:04 PM, Bjorn Andersson wrote:
> In some configurations the supplies are voltage switches and not LDOs,
> making the set voltage call to fail. Check with the regulator framework
> if the supply can change voltage before attempting.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 8c16d6a3ca78..ece3de6a8157 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -278,7 +278,7 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host)
> }
>
> for (i = 0; i < num; i++) {
> - if ((regs[i].min_voltage >= 0) && (regs[i].max_voltage >= 0)) {
> + if (regulator_can_change_voltage(s[i].consumer)) {
> ret = regulator_set_voltage(s[i].consumer,
> regs[i].min_voltage, regs[i].max_voltage);
> if (ret < 0) {
> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> index 401ff58d6893..f1f955f571fa 100644
> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> @@ -178,7 +178,7 @@ static int dsi_phy_regulator_init(struct msm_dsi_phy *phy)
> }
>
> for (i = 0; i < num; i++) {
> - if ((regs[i].min_voltage >= 0) && (regs[i].max_voltage >= 0)) {
> + if (regulator_can_change_voltage(s[i].consumer)) {
> ret = regulator_set_voltage(s[i].consumer,
> regs[i].min_voltage, regs[i].max_voltage);
> if (ret < 0) {
>
Looks good to me.
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-08-28 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 17:34 [PATCH] drm: msm: dsi: Don't attempt changing voltage of switches Bjorn Andersson
2015-08-18 17:34 ` Bjorn Andersson
2015-08-28 10:27 ` Archit Taneja [this message]
2015-08-28 10:27 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E0377D.2050603@codeaurora.org \
--to=architt@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hali@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sviau@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.